From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ACF2C433EF for ; Mon, 25 Apr 2022 11:19:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235811AbiDYLW5 (ORCPT ); Mon, 25 Apr 2022 07:22:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241695AbiDYLWf (ORCPT ); Mon, 25 Apr 2022 07:22:35 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE266C8A81 for ; Mon, 25 Apr 2022 04:19:28 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id A7B0C68AFE; Mon, 25 Apr 2022 13:19:25 +0200 (CEST) Date: Mon, 25 Apr 2022 13:19:25 +0200 From: Christoph Hellwig To: Qu Wenruo Cc: Christoph Hellwig , Josef Bacik , David Sterba , Qu Wenruo , Naohiro Aota , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 03/10] btrfs: split btrfs_submit_data_bio Message-ID: <20220425111925.GA25233@lst.de> References: <20220425075418.2192130-1-hch@lst.de> <20220425075418.2192130-4-hch@lst.de> <62f71a43-8167-f29f-8e9f-d95bc6667e0e@gmx.com> <20220425091920.GC16446@lst.de> <458ba4e0-15f3-93e4-bc17-ae464bdf13e7@gmx.com> <20220425110928.GA24430@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Apr 25, 2022 at 07:16:21PM +0800, Qu Wenruo wrote: > I'm wondering how would you iterate the bvec of a cloned bio then. We just stop doing that. All iteration should be on the originally constructed bio. I've fixed the two places that are doing that right in work in progress patches.