All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
	edumazet@google.com
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	netdev@vger.kernel.org, anthony.l.nguyen@intel.com
Subject: [PATCH net-next v2 07/10] ice: remove return value comment for ice_reset_all_vfs
Date: Thu,  5 May 2022 13:03:56 -0700	[thread overview]
Message-ID: <20220505200359.3080110-8-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20220505200359.3080110-1-anthony.l.nguyen@intel.com>

From: Jacob Keller <jacob.e.keller@intel.com>

Since commit fe99d1c06c16 ("ice: make ice_reset_all_vfs void"), the
ice_reset_all_vfs function has not returned anything. The function comment
still indicated it did. Fix this.

While here, also add a line to clarify the function resets all VFs at once
in response to hardware resets such as a PF reset.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
index aefd66a4db80..24cf6a5b49fe 100644
--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
@@ -359,12 +359,12 @@ ice_vf_clear_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m)
  * ice_reset_all_vfs - reset all allocated VFs in one go
  * @pf: pointer to the PF structure
  *
+ * Reset all VFs at once, in response to a PF or other device reset.
+ *
  * First, tell the hardware to reset each VF, then do all the waiting in one
  * chunk, and finally finish restoring each VF after the wait. This is useful
  * during PF routines which need to reset all VFs, as otherwise it must perform
  * these resets in a serialized fashion.
- *
- * Returns true if any VFs were reset, and false otherwise.
  */
 void ice_reset_all_vfs(struct ice_pf *pf)
 {
-- 
2.35.1


  parent reply	other threads:[~2022-05-05 20:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05 20:03 [PATCH net-next v2 00/10][pull request] 100GbE Intel Wired LAN Driver Updates 2022-05-05 Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 01/10] ice: use min_t() to make code cleaner in ice_gnss Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 02/10] ice: introduce common helper for retrieving VSI by vsi_num Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 03/10] ice: return ENOSPC when exceeding ICE_MAX_CHAIN_WORDS Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 04/10] ice: get switch id on switchdev devices Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 05/10] ice: add newline to dev_dbg in ice_vf_fdir_dump_info Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 06/10] ice: always check VF VSI pointer values Tony Nguyen
2022-05-05 20:03 ` Tony Nguyen [this message]
2022-05-05 20:03 ` [PATCH net-next v2 08/10] ice: fix wording in comment for ice_reset_vf Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 09/10] ice: add a function comment for ice_cfg_mac_antispoof Tony Nguyen
2022-05-05 20:03 ` [PATCH net-next v2 10/10] ice: remove period on argument description in ice_for_each_vf Tony Nguyen
2022-05-06 10:40 ` [PATCH net-next v2 00/10][pull request] 100GbE Intel Wired LAN Driver Updates 2022-05-05 patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220505200359.3080110-8-anthony.l.nguyen@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.