Re: [PATCH 1/1 v2] add support for mws4 board

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

On Sun, May 08, 2022 at 05:47:58PM +0200, Marian Ulbricht wrote:
> Am 08.05.22 um 16:21 schrieb Tom Rini:
> > On Sun, May 08, 2022 at 03:46:55PM +0200, Marian Ulbricht wrote:
> > 
> > > mws4 is an arm based nuclear probe hardware used from german government to
> > > monitor nuclear activity
> > > 
> > > Signed-off-by: Marian Ulbricht <ulbricht@innoroute.de>
> > 
> > Thanks for the submission.  Have you submitted the board dts files to
> > upstream Linux?  Also, please remove all of the commented out code in
> > the board files, etc.
> > 
> Hi,
> not yet, i started from bottom up: u-boot -> buildroot -> kernel

OK.  We require the board dts itself to be submitted to the kernel
first, as we keep that as an unchanged copy of the file in upstream and
try and sync them down periodically.

> [PATCH 1/1 v2] add support for mws4 board
> 
> mws4 is an arm based nuclear probe hardware used from german government to
> monitor nuclear activity
> 
> Signed-off-by: Marian Ulbricht <ulbricht@innoroute.de>
> ---
> Changes v2:
> 
> * code cleanup

Note that there's a number of whitespace, etc, issues that checkpatch.pl
reports.  For the dts files, you can set that aside and follow what
upstream says there, but the rest need to be addressed.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]