From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F5AC2F28 for ; Sun, 22 May 2022 16:04:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653235472; x=1684771472; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sM/fEM1Cz4Fu5jERVYNMoQaN0mOPoZxzUJZYlTqChOc=; b=bBn6JQd/+i/ski7ISsjzLo79HJn/3KyPbBdYjFkkZoF5RugYVmhUyuKA HlgddoY7+saz3fwoaIPwhR3+QWwxEpyVvBmY+TZm9+pE7hYca8XuMCIWQ em6fIA1PJk6om4KJ6mNmU2Mn1onBPj46L5yyjU1mkM+fFbgNb6DT2rnqW ljpi+rB5RPtOZ4YkW+kuhiBeTxVPDok8sllLXSmXTerti6ALMDCOBF/jz xTolvgw5l7Bwzq3dam0SUkyF9u57+U9+m5JiA7AaxIVepi3VK6WKenUI4 0HqZtsHCYKXlolYcJYu6GsCzJqYItTYSYC/jbd7My097GnKGt8ljmeWQ0 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10355"; a="271834471" X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="271834471" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2022 09:04:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="558265341" Received: from lkp-server01.sh.intel.com (HELO db63a1be7222) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 22 May 2022 09:04:26 -0700 Received: from kbuild by db63a1be7222 with local (Exim 4.95) (envelope-from ) id 1nso49-0000Ru-WA; Sun, 22 May 2022 16:04:25 +0000 Date: Mon, 23 May 2022 00:03:28 +0800 From: kernel test robot To: Li Chen , Mark Brown , linux-kernel , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-gpio , Linus Walleij , linux-arm-kernel , Patrice Chotard , linux-sunxi , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Philipp Zabel Cc: kbuild-all@lists.01.org Subject: Re: [PATCH 4/4] pinctrl: st: Switch to use regmap_field_test_bits Message-ID: <202205222359.yQ35dVuB-lkp@intel.com> References: <180e705f8de.1012cdc8c45890.1645144071309904245@zohomail.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <180e705f8de.1012cdc8c45890.1645144071309904245@zohomail.com> Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on broonie-regmap/for-next] [also build test ERROR on linusw-pinctrl/devel broonie-sound/for-next v5.18-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Li-Chen/Add-regmap_field-helpers-for-simple-bit-operations/20220521-224352 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20220522/202205222359.yQ35dVuB-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/73189e14ed111777ac60a95ae3008337c69589da git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Li-Chen/Add-regmap_field-helpers-for-simple-bit-operations/20220521-224352 git checkout 73189e14ed111777ac60a95ae3008337c69589da # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/pinctrl/pinctrl-st.c: In function 'st_pinconf_get_direction': >> drivers/pinctrl/pinctrl-st.c:587:53: error: 'od_value' undeclared (first use in this function); did you mean 'si_value'? 587 | if (regmap_field_test_bits(pc->od, &od_value, BIT(pin))) | ^~~~~~~~ | si_value drivers/pinctrl/pinctrl-st.c:587:53: note: each undeclared identifier is reported only once for each function it appears in >> drivers/pinctrl/pinctrl-st.c:587:21: error: too many arguments to function 'regmap_field_test_bits' 587 | if (regmap_field_test_bits(pc->od, &od_value, BIT(pin))) | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-st.c:18: include/linux/regmap.h:1353:5: note: declared here 1353 | int regmap_field_test_bits(struct regmap_field *field, unsigned int bits); | ^~~~~~~~~~~~~~~~~~~~~~ vim +587 drivers/pinctrl/pinctrl-st.c 572 573 static void st_pinconf_get_direction(struct st_pio_control *pc, 574 int pin, unsigned long *config) 575 { 576 if (pc->oe) { 577 if (regmap_field_test_bits(pc->oe, BIT(pin))) 578 ST_PINCONF_PACK_OE(*config); 579 } 580 581 if (pc->pu) { 582 if (regmap_field_test_bits(pc->pu, BIT(pin))) 583 ST_PINCONF_PACK_PU(*config); 584 } 585 586 if (pc->od) { > 587 if (regmap_field_test_bits(pc->od, &od_value, BIT(pin))) 588 ST_PINCONF_PACK_OD(*config); 589 } 590 } 591 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B872C433F5 for ; Sun, 22 May 2022 16:06:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7O2e2my8pXvFGWKAYwP7mUmwX71P+Wam1K2StnliP8Y=; b=NdqHVbcIybH3Rd HU6sge/RwCY0BHRNR/55eD6UAG+IBGvIutARC9Iu+eL/wgRaiU8We3Y3izYmVnwhKC8uLUZDG2tDW vX9vBqYCRKq7VMhB9hRR3oaK8T9HoDqJkTjrOTHYAYIxyJiIQBiYf0vs2YYA3Uh1bzR0QnWxRporj y9ZL7YSw4Rg0aaEpKy+ekzpyVqMq8KwooUg+++IDiZBHmFjsSA2ABv+/mb84nywF2Ch2C5I8AZaWh qiofZN75fjgkqvsmSFKIA6DnQs0pTm53pxWu/KpODtlxaanaSMCu4FeulEqH7NUSbDfHAYZ21pfBc oNowK8tB1ZoYQLc6pQew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nso4M-001dC6-W9; Sun, 22 May 2022 16:04:39 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nso4I-001dBW-OA for linux-arm-kernel@lists.infradead.org; Sun, 22 May 2022 16:04:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653235474; x=1684771474; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sM/fEM1Cz4Fu5jERVYNMoQaN0mOPoZxzUJZYlTqChOc=; b=iY9ovPHuksRZchMtc4xIeVANA0G89upYR0DpdqDXuHGxw8U8ZVdUsan/ qA0XRso5CynbXcQQKwk2sHhZyQyaxFYsPVEEZqrZk9BqR4G5BXDSDJTeY s7e3NkUz+aYkEha7P5UthQ6u5kfUyh1wS/qTM2Pn5dorJoynVNa6BKgMv RF5qnskqx1Jl/QWI9KF1s64fhqzsGJ24KEVEW5CMplqtiZeItZw4Tt0nR tFtQE0ovgRjOFR6X8qYS8OD6GxFugV/oq4LePKVbYZDTmoCUN96EEGqUB Y5an0exqEDO9DQudsdbUjbqVH6NA8KuDaK04De2NqG9y/aV9Xmqbxd89G g==; X-IronPort-AV: E=McAfee;i="6400,9594,10355"; a="359412476" X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="359412476" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2022 09:04:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,244,1647327600"; d="scan'208";a="558265341" Received: from lkp-server01.sh.intel.com (HELO db63a1be7222) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 22 May 2022 09:04:26 -0700 Received: from kbuild by db63a1be7222 with local (Exim 4.95) (envelope-from ) id 1nso49-0000Ru-WA; Sun, 22 May 2022 16:04:25 +0000 Date: Mon, 23 May 2022 00:03:28 +0800 From: kernel test robot To: Li Chen , Mark Brown , linux-kernel , Greg Kroah-Hartman , "Rafael J. Wysocki" , linux-gpio , Linus Walleij , linux-arm-kernel , Patrice Chotard , linux-sunxi , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Philipp Zabel Cc: kbuild-all@lists.01.org Subject: Re: [PATCH 4/4] pinctrl: st: Switch to use regmap_field_test_bits Message-ID: <202205222359.yQ35dVuB-lkp@intel.com> References: <180e705f8de.1012cdc8c45890.1645144071309904245@zohomail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <180e705f8de.1012cdc8c45890.1645144071309904245@zohomail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220522_090434_860127_934EDA69 X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Li, Thank you for the patch! Yet something to improve: [auto build test ERROR on broonie-regmap/for-next] [also build test ERROR on linusw-pinctrl/devel broonie-sound/for-next v5.18-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Li-Chen/Add-regmap_field-helpers-for-simple-bit-operations/20220521-224352 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20220522/202205222359.yQ35dVuB-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/73189e14ed111777ac60a95ae3008337c69589da git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Li-Chen/Add-regmap_field-helpers-for-simple-bit-operations/20220521-224352 git checkout 73189e14ed111777ac60a95ae3008337c69589da # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/pinctrl/pinctrl-st.c: In function 'st_pinconf_get_direction': >> drivers/pinctrl/pinctrl-st.c:587:53: error: 'od_value' undeclared (first use in this function); did you mean 'si_value'? 587 | if (regmap_field_test_bits(pc->od, &od_value, BIT(pin))) | ^~~~~~~~ | si_value drivers/pinctrl/pinctrl-st.c:587:53: note: each undeclared identifier is reported only once for each function it appears in >> drivers/pinctrl/pinctrl-st.c:587:21: error: too many arguments to function 'regmap_field_test_bits' 587 | if (regmap_field_test_bits(pc->od, &od_value, BIT(pin))) | ^~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/pinctrl/pinctrl-st.c:18: include/linux/regmap.h:1353:5: note: declared here 1353 | int regmap_field_test_bits(struct regmap_field *field, unsigned int bits); | ^~~~~~~~~~~~~~~~~~~~~~ vim +587 drivers/pinctrl/pinctrl-st.c 572 573 static void st_pinconf_get_direction(struct st_pio_control *pc, 574 int pin, unsigned long *config) 575 { 576 if (pc->oe) { 577 if (regmap_field_test_bits(pc->oe, BIT(pin))) 578 ST_PINCONF_PACK_OE(*config); 579 } 580 581 if (pc->pu) { 582 if (regmap_field_test_bits(pc->pu, BIT(pin))) 583 ST_PINCONF_PACK_PU(*config); 584 } 585 586 if (pc->od) { > 587 if (regmap_field_test_bits(pc->od, &od_value, BIT(pin))) 588 ST_PINCONF_PACK_OD(*config); 589 } 590 } 591 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel