From: Christoph Hellwig <hch@lst.de>
To: Filipe Manana <fdmanana@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 8/9] btrfs: test repair with sectors corrupted in multiple mirrors
Date: Thu, 2 Jun 2022 14:07:43 +0200 [thread overview]
Message-ID: <20220602120743.GA27700@lst.de> (raw)
In-Reply-To: <20220602113056.GA3347231@falcondesktop>
On Thu, Jun 02, 2022 at 12:30:56PM +0100, Filipe Manana wrote:
> On Tue, May 24, 2022 at 09:18:37AM +0200, Christoph Hellwig wrote:
> > Test that repair handles the case where it needs to read from more than
> > a single mirror on the raid1c3 profile.
>
> The test currently fails (at least on current misc-next branch), as the
> repair does not happen, see below. Is it a bug in the repair code for
> raid1c3 (I haven't checked)?
Yes, it only repairs the previously bad copy and doesn't propagate
the repair.
> Also why only raid1c3 coverage and not raid1c4 as well?
Because I've really wanted any coverage at all for mutiple mirror
repair operations. raid1c4 is probably useful to test, but won't
increase the coverage of the read repair code much.
next prev parent reply other threads:[~2022-06-02 12:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 7:18 two more btrfs read repair tests v2 Christoph Hellwig
2022-05-24 7:18 ` [PATCH 1/9] btrfs: add a helpers for read repair testing Christoph Hellwig
2022-05-24 13:18 ` Qu Wenruo
2022-05-27 11:22 ` Nikolay Borisov
2022-05-27 13:33 ` Christoph Hellwig
2022-05-24 7:18 ` [PATCH 2/9] btrfs/140: use common read repair helpers Christoph Hellwig
2022-05-24 13:21 ` Qu Wenruo
2022-05-24 7:18 ` [PATCH 3/9] btrfs/141: " Christoph Hellwig
2022-05-24 13:21 ` Qu Wenruo
2022-05-24 7:18 ` [PATCH 4/9] btrfs/142: " Christoph Hellwig
2022-05-24 13:21 ` Qu Wenruo
2022-05-24 7:18 ` [PATCH 5/9] btrfs/143: " Christoph Hellwig
2022-05-24 13:21 ` Qu Wenruo
2022-05-24 7:18 ` [PATCH 6/9] btrfs/157: use _btrfs_get_first_logical Christoph Hellwig
2022-05-24 13:21 ` Qu Wenruo
2022-05-24 7:18 ` [PATCH 7/9] btrfs/215: " Christoph Hellwig
2022-05-24 13:21 ` Qu Wenruo
2022-05-24 7:18 ` [PATCH 8/9] btrfs: test repair with sectors corrupted in multiple mirrors Christoph Hellwig
2022-05-24 13:28 ` Qu Wenruo
2022-06-02 11:30 ` Filipe Manana
2022-06-02 12:07 ` Christoph Hellwig [this message]
2022-05-24 7:18 ` [PATCH 9/9] btrfs: test repair with corrupted sectors interleaved over " Christoph Hellwig
2022-05-24 13:30 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220602120743.GA27700@lst.de \
--to=hch@lst.de \
--cc=fdmanana@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.