[PATCH 14/14] mtd: physmap: Drop if with an always false condition - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: kernel@pengutronix.de, linux-mtd@lists.infradead.org
Subject: [PATCH 14/14] mtd: physmap: Drop if with an always false condition
Date: Fri,  3 Jun 2022 23:07:58 +0200	[thread overview]
Message-ID: <20220603210758.148493-15-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20220603210758.148493-1-u.kleine-koenig@pengutronix.de>

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so info is never NULL.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/mtd/maps/physmap-core.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/mtd/maps/physmap-core.c b/drivers/mtd/maps/physmap-core.c
index d433df84a394..85eca6a192e6 100644
--- a/drivers/mtd/maps/physmap-core.c
+++ b/drivers/mtd/maps/physmap-core.c
@@ -69,10 +69,6 @@ static int physmap_flash_remove(struct platform_device *dev)
 	int i;
 
 	info = platform_get_drvdata(dev);
-	if (!info) {
-		err = -EINVAL;
-		goto out;
-	}
 
 	if (info->cmtd) {
 		WARN_ON(mtd_device_unregister(info->cmtd));
-- 
2.36.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
