Re: [PATCH V2 2/2] mm/mmap: Drop generic protection_map[] array

From: kernel test robot <lkp@intel.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] mm/mmap: Drop generic protection_map[] array
Date: Mon, 13 Jun 2022 19:13:26 +0800	[thread overview]
Message-ID: <202206131931.ZJuanaBo-lkp@intel.com> (raw)
In-Reply-To: <20220613053354.553579-3-anshuman.khandual@arm.com>

Hi Anshuman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/mm-mmap-Drop-__SXXX-__PXXX-macros-from-across-platforms/20220613-133456
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: powerpc64-randconfig-r016-20220613 (https://download.01.org/0day-ci/archive/20220613/202206131931.ZJuanaBo-lkp@intel.com/config)
compiler: powerpc64le-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/696f81b49f7b6316f652d795da4c0008efef4487
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Anshuman-Khandual/mm-mmap-Drop-__SXXX-__PXXX-macros-from-across-platforms/20220613-133456
        git checkout 696f81b49f7b6316f652d795da4c0008efef4487
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/mm/book3s64/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/include/asm/page.h:306,
                    from arch/powerpc/include/asm/mmu.h:149,
                    from arch/powerpc/include/asm/lppaca.h:46,
                    from arch/powerpc/include/asm/paca.h:18,
                    from arch/powerpc/include/asm/current.h:13,
                    from include/linux/sched.h:12,
                    from arch/powerpc/mm/book3s64/pgtable.c:6:
   arch/powerpc/mm/book3s64/pgtable.c: In function 'vm_get_page_prot':
>> arch/powerpc/mm/book3s64/pgtable.c:557:41: error: 'protection_map' undeclared (first use in this function)
     557 |         unsigned long prot = pgprot_val(protection_map[vm_flags &
         |                                         ^~~~~~~~~~~~~~
   arch/powerpc/include/asm/pgtable-be-types.h:68:27: note: in definition of macro 'pgprot_val'
      68 | #define pgprot_val(x)   ((x).pgprot)
         |                           ^
   arch/powerpc/mm/book3s64/pgtable.c:557:41: note: each undeclared identifier is reported only once for each function it appears in
     557 |         unsigned long prot = pgprot_val(protection_map[vm_flags &
         |                                         ^~~~~~~~~~~~~~
   arch/powerpc/include/asm/pgtable-be-types.h:68:27: note: in definition of macro 'pgprot_val'
      68 | #define pgprot_val(x)   ((x).pgprot)
         |                           ^

vim +/protection_map +557 arch/powerpc/mm/book3s64/pgtable.c

634093c59a12fc Anshuman Khandual 2022-04-28  553  
847c271152e941 Anshuman Khandual 2022-06-13  554  /* Note due to the way vm flags are laid out, the bits are XWR */
634093c59a12fc Anshuman Khandual 2022-04-28  555  pgprot_t vm_get_page_prot(unsigned long vm_flags)
634093c59a12fc Anshuman Khandual 2022-04-28  556  {
634093c59a12fc Anshuman Khandual 2022-04-28 @557  	unsigned long prot = pgprot_val(protection_map[vm_flags &
634093c59a12fc Anshuman Khandual 2022-04-28  558  					(VM_READ|VM_WRITE|VM_EXEC|VM_SHARED)]);
634093c59a12fc Anshuman Khandual 2022-04-28  559  
634093c59a12fc Anshuman Khandual 2022-04-28  560  	if (vm_flags & VM_SAO)
634093c59a12fc Anshuman Khandual 2022-04-28  561  		prot |= _PAGE_SAO;
634093c59a12fc Anshuman Khandual 2022-04-28  562  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp