From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEEAC19F28 for ; Wed, 27 Jul 2022 16:23:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234980AbiG0QXQ (ORCPT ); Wed, 27 Jul 2022 12:23:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235059AbiG0QWl (ORCPT ); Wed, 27 Jul 2022 12:22:41 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B27884D167 for ; Wed, 27 Jul 2022 09:22:37 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 4CEFA68AA6; Wed, 27 Jul 2022 18:22:34 +0200 (CEST) Date: Wed, 27 Jul 2022 18:22:34 +0200 From: Christoph Hellwig To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, ZiyangZhang , Christoph Hellwig Subject: Re: [PATCH V2 3/5] ublk_drv: add SET_PARAM/GET_PARAM control command Message-ID: <20220727162234.GB18969@lst.de> References: <20220727141628.985429-1-ming.lei@redhat.com> <20220727141628.985429-4-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220727141628.985429-4-ming.lei@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org As stated in the previous discussion I think this is a very bad idea that leads to a lot of boiler plate code. If you don't want to rely on zeroed fields we can add a mask of valid fields, similar to how e.g. the statx API works.