From: Sam James <sam@gentoo.org>
To: Pavel Shilovsky <pshilovsky@samba.org>, linux-cifs@vger.kernel.org
Cc: Pavel Shilovsky <piastryyy@gmail.com>, Sam James <sam@gentoo.org>
Subject: [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX
Date: Tue, 16 Aug 2022 01:43:34 +0100 [thread overview]
Message-ID: <20220816004335.2634169-1-sam@gentoo.org> (raw)
Needed to build on musl. It only works on glibc because of transitive includes
(which could break in future).
Example failure:
```
getcifsacl.c: In function 'getcifsacl':
getcifsacl.c:429:24: error: 'XATTR_SIZE_MAX' undeclared (first use in this function)
429 | if (bufsize >= XATTR_SIZE_MAX) {
| ^~~~~~~~~~~~~~
```
Bug: https://bugs.gentoo.org/842195
Signed-off-by: Sam James <sam@gentoo.org>
---
getcifsacl.c | 1 +
setcifsacl.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/getcifsacl.c b/getcifsacl.c
index 1c01062..d69d40a 100644
--- a/getcifsacl.c
+++ b/getcifsacl.c
@@ -34,6 +34,7 @@
#include <errno.h>
#include <limits.h>
#include <ctype.h>
+#include <linux/limits.h>
#include <sys/xattr.h>
#include "cifsacl.h"
#include "idmap_plugin.h"
diff --git a/setcifsacl.c b/setcifsacl.c
index d832cec..b7079ab 100644
--- a/setcifsacl.c
+++ b/setcifsacl.c
@@ -48,6 +48,7 @@
#include <errno.h>
#include <limits.h>
#include <ctype.h>
+#include <linux/limits.h>
#include <sys/xattr.h>
#include "cifsacl.h"
--
2.37.2
next reply other threads:[~2022-08-16 4:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 0:43 Sam James [this message]
2022-08-16 0:43 ` [PATCH 2/2] getcifsacl, setcifsacl: add missing <endian.h> include for le32toh Sam James
2024-03-26 1:26 ` [PATCH 1/2] getcifsacl, setcifsacl: add missing <linux/limits.h> include for XATTR_SIZE_MAX Pavel Shilovsky
-- strict thread matches above, loose matches on Subject: below --
2023-02-11 22:39 Sam James
2022-06-24 4:54 Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816004335.2634169-1-sam@gentoo.org \
--to=sam@gentoo.org \
--cc=linux-cifs@vger.kernel.org \
--cc=piastryyy@gmail.com \
--cc=pshilovsky@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.