All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Zhao <yuzhao@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Yu Zhao <yuzhao@google.com>,
	 David Rientjes <rientjes@google.com>
Subject: [PATCH v14-fix 06/11] mm: multi-gen LRU: delete overcautious VM_WARN_ON_ONCE()
Date: Sun, 18 Sep 2022 14:47:50 -0600	[thread overview]
Message-ID: <20220918204755.3135720-6-yuzhao@google.com> (raw)
In-Reply-To: <20220918204755.3135720-1-yuzhao@google.com>

As commented, it is "unlikely but not a bug when reset_batch_size() is
pending". This one was never reported but another similar one in
lru_gen_use_mm(), which is already deleted, indeed happened.

kernel BUG at mm/vmscan.c:4592!
Call Trace:
 ? get_nr_to_scan+0x89/0x2a0
 lru_gen_shrink_lruvec+0x1aa/0x2b0
 shrink_node_memcg+0x68/0x450
 shrink_node+0x25c/0x620
 shrink_zones+0xf4/0x170
 do_try_to_free_pages+0xa5/0x280
 try_to_free_mem_cgroup_pages+0x161/0x1f0
 try_charge+0x2b1/0x940
 __mem_cgroup_try_charge+0x102/0x3d0
 do_anonymous_page+0x152/0x440
 handle_mm_fault+0x9d2/0x1030
 __do_page_fault+0x388/0x550
 do_page_fault+0x2b/0x60
 page_fault+0x45/0x50

Reported-by: David Rientjes <rientjes@google.com>
Signed-off-by: Yu Zhao <yuzhao@google.com>
---
 mm/vmscan.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index e509e896c019..77d2d08950ba 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -5171,9 +5171,6 @@ static bool __maybe_unused state_is_valid(struct lruvec *lruvec)
 		for_each_gen_type_zone(gen, type, zone) {
 			if (!list_empty(&lrugen->lists[gen][type][zone]))
 				return false;
-
-			/* unlikely but not a bug when reset_batch_size() is pending */
-			VM_WARN_ON_ONCE(lrugen->nr_pages[gen][type][zone]);
 		}
 	}
 
-- 
2.37.3.968.ga6b4b080e4-goog



  parent reply	other threads:[~2022-09-18 20:48 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  7:13 [PATCH v14 00/14] Multi-Gen LRU Framework Yu Zhao
2022-08-15  7:13 ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 01/14] mm: x86, arm64: add arch_has_hw_pte_young() Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 02/14] mm: x86: add CONFIG_ARCH_HAS_NONLEAF_PMD_YOUNG Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 03/14] mm/vmscan.c: refactor shrink_node() Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 04/14] Revert "include/linux/mm_inline.h: fold __update_lru_size() into its sole caller" Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 05/14] mm: multi-gen LRU: groundwork Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 06/14] mm: multi-gen LRU: minimal implementation Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 07/14] mm: multi-gen LRU: exploit locality in rmap Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-09-01  9:18   ` Nadav Amit
2022-09-01  9:18     ` Nadav Amit
2022-09-02  1:17     ` Yu Zhao
2022-09-02  1:17       ` Yu Zhao
2022-09-02  1:28       ` Yu Zhao
2022-09-02  1:28         ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 08/14] mm: multi-gen LRU: support page table walks Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-10-13 15:04   ` Peter Zijlstra
2022-10-13 15:04     ` Peter Zijlstra
2022-10-19  5:51     ` Yu Zhao
2022-10-19  5:51       ` Yu Zhao
2022-10-19 17:40       ` Linus Torvalds
2022-10-19 17:40         ` Linus Torvalds
2022-10-20 14:13         ` Peter Zijlstra
2022-10-20 14:13           ` Peter Zijlstra
2022-10-20 17:29           ` Yu Zhao
2022-10-20 17:29             ` Yu Zhao
2022-10-20 17:35           ` Linus Torvalds
2022-10-20 17:35             ` Linus Torvalds
2022-10-20 18:55             ` Peter Zijlstra
2022-10-20 18:55               ` Peter Zijlstra
2022-10-21  2:10               ` Linus Torvalds
2022-10-21  2:10                 ` Linus Torvalds
2022-10-21  3:38                 ` Matthew Wilcox
2022-10-21  3:38                   ` Matthew Wilcox
2022-10-21 16:50                   ` Linus Torvalds
2022-10-21 16:50                     ` Linus Torvalds
2022-10-23 14:44                     ` David Gow
2022-10-23 14:44                       ` David Gow
2022-10-23 17:55                     ` Maciej W. Rozycki
2022-10-23 17:55                       ` Maciej W. Rozycki
2022-10-23 18:35                       ` Linus Torvalds
2022-10-23 18:35                         ` Linus Torvalds
2022-10-24  7:30                         ` Arnd Bergmann
2022-10-24  7:30                           ` Arnd Bergmann
2022-10-25 16:28                         ` Maciej W. Rozycki
2022-10-25 16:28                           ` Maciej W. Rozycki
2022-10-26 15:43                           ` Arnd Bergmann
2022-10-26 15:43                             ` Arnd Bergmann
2022-10-27 23:08                             ` Maciej W. Rozycki
2022-10-27 23:08                               ` Maciej W. Rozycki
2022-10-28  7:27                               ` Arnd Bergmann
2022-10-28  7:27                                 ` Arnd Bergmann
2022-10-21 10:12                 ` Peter Zijlstra
2022-10-21 10:12                   ` Peter Zijlstra
2022-10-24 18:20                 ` Gareth Poole
2022-10-24 18:20                   ` Gareth Poole
2022-10-24 19:28                 ` Serentty
2022-10-24 19:28                   ` Serentty
2022-08-15  7:13 ` [PATCH v14 09/14] mm: multi-gen LRU: optimize multiple memcgs Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 10/14] mm: multi-gen LRU: kill switch Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 11/14] mm: multi-gen LRU: thrashing prevention Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 12/14] mm: multi-gen LRU: debugfs interface Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  7:13 ` [PATCH v14 13/14] mm: multi-gen LRU: admin guide Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  9:06   ` Bagas Sanjaya
2022-08-15  9:06     ` Bagas Sanjaya
2022-08-15  9:12   ` Mike Rapoport
2022-08-15  9:12     ` Mike Rapoport
2022-08-17 22:46     ` Yu Zhao
2022-08-17 22:46       ` Yu Zhao
2022-09-20  7:43   ` Bagas Sanjaya
2022-09-20  7:43     ` Bagas Sanjaya
2022-08-15  7:13 ` [PATCH v14 14/14] mm: multi-gen LRU: design doc Yu Zhao
2022-08-15  7:13   ` Yu Zhao
2022-08-15  9:07   ` Bagas Sanjaya
2022-08-15  9:07     ` Bagas Sanjaya
2022-08-31  4:17 ` OpenWrt / MIPS benchmark with MGLRU Yu Zhao
2022-08-31  4:17   ` Yu Zhao
2022-08-31  9:44   ` Arnd Bergmann
2022-08-31 12:12   ` Arnd Bergmann
2022-08-31 12:12     ` Arnd Bergmann
2022-08-31 15:13   ` Dave Hansen
2022-08-31 15:13     ` Dave Hansen
2022-08-31 22:18   ` Yu Zhao
2022-08-31 22:18     ` Yu Zhao
2022-09-12  0:08 ` [PATCH v14 00/14] Multi-Gen LRU Framework Andrew Morton
2022-09-12  0:08   ` Andrew Morton
2022-09-15 17:56   ` Yu Zhao
2022-09-15 17:56     ` Yu Zhao
2022-09-18 20:40     ` Yu Zhao
2022-09-18 20:40       ` Yu Zhao
2022-09-18 20:47       ` [PATCH v14-fix 01/11] mm: multi-gen LRU: update admin guide Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 02/11] mm: multi-gen LRU: add comment in lru_gen_use_mm() Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 03/11] mm: multi-gen LRU: warn on !ptep_test_and_clear_young() Yu Zhao
2022-09-18 23:47           ` Andrew Morton
2022-09-18 23:53             ` Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 04/11] mm: multi-gen LRU: fix warning from __rcu Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 05/11] mm: multi-gen LRU: fix warning from seq_is_valid() Yu Zhao
2022-09-18 20:47         ` Yu Zhao [this message]
2022-09-18 20:47         ` [PATCH v14-fix 07/11] mm: multi-gen LRU: dial down MAX_LRU_BATCH Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 08/11] mm: multi-gen LRU: delete newline in kswapd_age_node() Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 09/11] mm: multi-gen LRU: add comment in lru_gen_look_around() Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 10/11] mm: multi-gen LRU: fixed long-tailed direct reclaim latency Yu Zhao
2022-09-18 20:47         ` [PATCH v14-fix 11/11] mm: multi-gen LRU: refactor get_nr_evictable() Yu Zhao
2022-09-18 23:47       ` [PATCH v14 00/14] Multi-Gen LRU Framework Andrew Morton
2022-09-18 23:47         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220918204755.3135720-6-yuzhao@google.com \
    --to=yuzhao@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.