From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: fix direct IO writes with nowait and dsync iocb not syncing
Date: Mon, 31 Oct 2022 17:26:20 +0100 [thread overview]
Message-ID: <20221031162620.GD5824@twin.jikos.cz> (raw)
In-Reply-To: <cover.1667215075.git.fdmanana@suse.com>
On Mon, Oct 31, 2022 at 11:43:54AM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> This fixes direct IO writes with nowait and dsync not getting synced after
> the writes complete (except when we fallback to blocking context). The first
> patch is the fix, while the second one only updates a comment that is now
> stale after 6.1-rc1.
The nowait + dsync combination is proably not a typical one but maybe
there are use cases I don't know about. Anyway, thanks for fixing it.
> Patch only applies to current misc-next, because a function prototype
> declaration was recently moved out of ctree.h into btrfs_inode.h. I left
> a version that applies cleanly against 6.0.6 and 6.1-rc at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/fdmanana/linux.git/log/?h=async_dio_fsync_fix_6.1_6.0
Great, thanks, that helps.
prev parent reply other threads:[~2022-10-31 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 11:43 [PATCH 0/2] btrfs: fix direct IO writes with nowait and dsync iocb not syncing fdmanana
2022-10-31 11:43 ` [PATCH 1/2] btrfs: fix lost file sync on direct IO write with nowait and dsync iocb fdmanana
2022-11-01 0:49 ` Wang Yugui
2022-11-01 1:04 ` Wang Yugui
2022-11-01 7:53 ` Filipe Manana
2022-11-01 7:48 ` Filipe Manana
2022-10-31 11:43 ` [PATCH 2/2] btrfs: update stale comment for nowait direct IO writes fdmanana
2022-10-31 16:26 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221031162620.GD5824@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.