From: kernel test robot <lkp@intel.com>
To: "Íñigo Huguet" <ihuguet@redhat.com>,
ecree.xilinx@gmail.com, habetsm.xilinx@gmail.com,
richardcochran@gmail.com
Cc: oe-kbuild-all@lists.linux.dev, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, "Íñigo Huguet" <ihuguet@redhat.com>,
"Yalin Li" <yalli@redhat.com>
Subject: Re: [PATCH net 4/4] sfc: remove expired unicast PTP filters
Date: Thu, 2 Feb 2023 00:09:41 +0800 [thread overview]
Message-ID: <202302020019.2MT9fEOy-lkp@intel.com> (raw)
In-Reply-To: <20230131160506.47552-5-ihuguet@redhat.com>
Hi Íñigo,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net/master]
url: https://github.com/intel-lab-lkp/linux/commits/igo-Huguet/sfc-store-PTP-filters-in-a-list/20230201-000831
patch link: https://lore.kernel.org/r/20230131160506.47552-5-ihuguet%40redhat.com
patch subject: [PATCH net 4/4] sfc: remove expired unicast PTP filters
config: parisc-randconfig-s033-20230129 (https://download.01.org/0day-ci/archive/20230202/202302020019.2MT9fEOy-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 12.1.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://github.com/intel-lab-lkp/linux/commit/d631c3b59ac7ba7f62da245114156866ea74a15b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review igo-Huguet/sfc-store-PTP-filters-in-a-list/20230201-000831
git checkout d631c3b59ac7ba7f62da245114156866ea74a15b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=parisc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/sfc/ptp.c:1515:30: sparse: sparse: incompatible types for operation (<):
>> drivers/net/ethernet/sfc/ptp.c:1515:30: sparse: struct efx_ptp_rxfilter *[assigned] rxfilter
>> drivers/net/ethernet/sfc/ptp.c:1515:30: sparse: int
vim +1515 drivers/net/ethernet/sfc/ptp.c
1493
1494 static int efx_ptp_insert_unicast_filter(struct efx_nic *efx,
1495 struct sk_buff *skb)
1496 {
1497 struct efx_ptp_data *ptp = efx->ptp_data;
1498 struct efx_ptp_rxfilter *rxfilter;
1499
1500 if (!efx_ptp_valid_unicast_event_pkt(skb))
1501 return -EINVAL;
1502
1503 if (skb->protocol == htons(ETH_P_IP)) {
1504 __be32 addr = ip_hdr(skb)->saddr;
1505
1506 rxfilter = efx_ptp_insert_ipv4_filter(efx, &ptp->rxfilters_ucast,
1507 addr, PTP_EVENT_PORT);
1508 if (IS_ERR(rxfilter))
1509 goto fail;
1510
1511 rxfilter->expiry = jiffies + UCAST_FILTER_EXPIRY_JIFFIES;
1512
1513 rxfilter = efx_ptp_insert_ipv4_filter(efx, &ptp->rxfilters_ucast,
1514 addr, PTP_GENERAL_PORT);
> 1515 if (rxfilter < 0)
1516 goto fail;
1517
1518 rxfilter->expiry = jiffies + UCAST_FILTER_EXPIRY_JIFFIES;
1519 } else if (efx_ptp_use_mac_tx_timestamps(efx)) {
1520 /* IPv6 PTP only supported by devices with MAC hw timestamp */
1521 struct in6_addr *addr = &ipv6_hdr(skb)->saddr;
1522
1523 rxfilter = efx_ptp_insert_ipv6_filter(efx, &ptp->rxfilters_ucast,
1524 addr, PTP_EVENT_PORT);
1525 if (IS_ERR(rxfilter))
1526 goto fail;
1527
1528 rxfilter->expiry = jiffies + UCAST_FILTER_EXPIRY_JIFFIES;
1529
1530 rxfilter = efx_ptp_insert_ipv6_filter(efx, &ptp->rxfilters_ucast,
1531 addr, PTP_GENERAL_PORT);
1532 if (IS_ERR(rxfilter))
1533 goto fail;
1534
1535 rxfilter->expiry = jiffies + UCAST_FILTER_EXPIRY_JIFFIES;
1536 } else {
1537 return -EOPNOTSUPP;
1538 }
1539
1540 return 0;
1541
1542 fail:
1543 efx_ptp_remove_filters(efx, &ptp->rxfilters_ucast);
1544 return PTR_ERR(rxfilter);
1545 }
1546
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-01 16:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 16:05 [PATCH net 0/4] sfc: support unicast PTP Íñigo Huguet
2023-01-31 16:05 ` [PATCH net 1/4] sfc: store PTP filters in a list Íñigo Huguet
2023-01-31 16:05 ` [PATCH net 2/4] sfc: allow insertion of filters for unicast PTP Íñigo Huguet
2023-01-31 16:05 ` [PATCH net 3/4] sfc: support " Íñigo Huguet
2023-01-31 16:05 ` [PATCH net 4/4] sfc: remove expired unicast PTP filters Íñigo Huguet
2023-01-31 17:46 ` kernel test robot
2023-02-01 16:09 ` kernel test robot [this message]
2023-02-01 8:08 ` [PATCH net-next v2 0/4] sfc: support unicast PTP Íñigo Huguet
2023-02-01 8:08 ` [PATCH net-next v2 1/4] sfc: store PTP filters in a list Íñigo Huguet
2023-02-02 12:13 ` Martin Habets
2023-02-01 8:08 ` [PATCH net-next v2 2/4] sfc: allow insertion of filters for unicast PTP Íñigo Huguet
2023-02-01 8:08 ` [PATCH net-next v2 3/4] sfc: support " Íñigo Huguet
2023-02-02 13:22 ` Martin Habets
2023-02-01 8:08 ` [PATCH net-next v2 4/4] sfc: remove expired unicast PTP filters Íñigo Huguet
2023-02-02 14:12 ` Martin Habets
2023-02-03 15:18 ` Íñigo Huguet
2023-02-03 15:29 ` Íñigo Huguet
2023-02-01 19:05 ` [PATCH net-next v2 0/4] sfc: support unicast PTP Jakub Kicinski
2023-02-02 7:08 ` Íñigo Huguet
2023-02-02 8:34 ` Leon Romanovsky
2023-02-02 9:17 ` Íñigo Huguet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302020019.2MT9fEOy-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=ihuguet@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=yalli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.