From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F62BC05027 for ; Fri, 3 Feb 2023 16:02:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232866AbjBCQC2 (ORCPT ); Fri, 3 Feb 2023 11:02:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231866AbjBCQC1 (ORCPT ); Fri, 3 Feb 2023 11:02:27 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C16F39D063 for ; Fri, 3 Feb 2023 08:02:24 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNyVz-0004Uw-SP; Fri, 03 Feb 2023 17:02:15 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pNyVy-0001d2-2W; Fri, 03 Feb 2023 17:02:14 +0100 Date: Fri, 3 Feb 2023 17:02:14 +0100 From: Sascha Hauer To: Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pegutronix.de, Michael Riesch Subject: Re: [PATCH 18/18] dt-bindings: devfreq: event: convert Rockchip DFI binding to yaml Message-ID: <20230203160214.GZ13319@pengutronix.de> References: <20230203125012.3804008-1-s.hauer@pengutronix.de> <20230203125012.3804008-19-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Feb 03, 2023 at 04:14:56PM +0100, Krzysztof Kozlowski wrote: > On 03/02/2023 13:50, Sascha Hauer wrote: > > Convert the Rockchip DFI binding to yaml. While at it add the newly > > supported rk3568-dfi to the binding. > > > > Signed-off-by: Sascha Hauer > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. That's what I did. I skipped you and Rob because I know you're wathcing the list anyway. > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > new file mode 100644 > > index 0000000000000..e082a0df7895a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > rockchip,dfi.yaml ok. > > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip DFI > > + > > +maintainers: > > + - Sascha Hauer > > + > > +properties: > > + compatible: > > + enum: > > + - rk3399-dfi > > + - rk3568-dfi > > These are not correct compatibles. What's wrong with them? > > > + > > + clocks: > > + maxItems: 1 > > + > > + rockchip,pmu: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the syscon managing the "PMU general register files". > > + > > +required: > > + - compatible > > + - reg > > clocks were required They are no longer, the RK3568 doesn't have a clock. Do I have to add something to make the clock optional on RK3568 only? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05BEAC61DA4 for ; Fri, 3 Feb 2023 16:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UWJkPjo7NuzBJtX6X7/WyFiQhkx90E6tePhK9kGuXso=; b=cI8BIoB4PMduEE FxjwNrH+2b/I6zMt+xXbBJgZzy3v+ABv8VpcWhm0Nun8pjHCJKb/OdENHxdhPPi8/6JBBVwh1Pbsf zV7gRfTaGgdwBpAn2mqi6m17S5k44qnZ0T8J1USXlKHpwJeUvgrHmvMR4zA5tskPWZI6stKdkagFo A8tEMgeiKz8TeKtXXlWhv7J5lApShvSiRYPweZ80+7E4Zg4Gl9WPFXUydMvh1bWCwbJoRK6O8hf42 H/Rd7j9wbzatcc1RRBM6cxr0qjNIpL2/TYU34/JASTk9FUevXSPvr0TYmeXnKa04CPlezgMI7cBcr 66euyDJCuWqou58bW8tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyWG-002qZM-WB; Fri, 03 Feb 2023 16:02:33 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyW5-002qV9-47 for linux-rockchip@lists.infradead.org; Fri, 03 Feb 2023 16:02:23 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNyVz-0004Uw-SP; Fri, 03 Feb 2023 17:02:15 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pNyVy-0001d2-2W; Fri, 03 Feb 2023 17:02:14 +0100 Date: Fri, 3 Feb 2023 17:02:14 +0100 From: Sascha Hauer To: Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pegutronix.de, Michael Riesch Subject: Re: [PATCH 18/18] dt-bindings: devfreq: event: convert Rockchip DFI binding to yaml Message-ID: <20230203160214.GZ13319@pengutronix.de> References: <20230203125012.3804008-1-s.hauer@pengutronix.de> <20230203125012.3804008-19-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_080221_184149_D7516AE0 X-CRM114-Status: GOOD ( 26.44 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 04:14:56PM +0100, Krzysztof Kozlowski wrote: > On 03/02/2023 13:50, Sascha Hauer wrote: > > Convert the Rockchip DFI binding to yaml. While at it add the newly > > supported rk3568-dfi to the binding. > > > > Signed-off-by: Sascha Hauer > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. That's what I did. I skipped you and Rob because I know you're wathcing the list anyway. > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > new file mode 100644 > > index 0000000000000..e082a0df7895a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > rockchip,dfi.yaml ok. > > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip DFI > > + > > +maintainers: > > + - Sascha Hauer > > + > > +properties: > > + compatible: > > + enum: > > + - rk3399-dfi > > + - rk3568-dfi > > These are not correct compatibles. What's wrong with them? > > > + > > + clocks: > > + maxItems: 1 > > + > > + rockchip,pmu: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the syscon managing the "PMU general register files". > > + > > +required: > > + - compatible > > + - reg > > clocks were required They are no longer, the RK3568 doesn't have a clock. Do I have to add something to make the clock optional on RK3568 only? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 064DEC61DA4 for ; Fri, 3 Feb 2023 16:03:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EeHjRDOwqnDLCtr+P1mUgMi9nuk7CUDRSMxmKsWMG80=; b=xWL0h3DjnlZLqH YLfbxGEbFjpQWjDZwFtWnNyONdBCCcjxZop11tJ76JwdjWLRZpJtploN1/5+YgMmEFiG65CkWFE6y 7tVUIN4W/QER//LowYyrq0Lp+QPMJaUpnj6FN2uwoNQeCx6R2bQ8YxP570ZQnujvHvuAov8MZRo4Q lh665mMvd3kOI0fVN7IgtvaO/dKxiShey+evB+WulNGWtgq5a9Ke3wquAMnewRVFe+r0L/4UGdNa0 vVGrCRced5420svCdzODdYQTjIIgQJAy1T6FHLu54/6GB+yNNIr22L57rDenIH0o6UEbUmOGHti5o z4M3kSTClfhuHCVZvcjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyW9-002qXN-Id; Fri, 03 Feb 2023 16:02:25 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyW5-002qV8-48 for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 16:02:23 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNyVz-0004Uw-SP; Fri, 03 Feb 2023 17:02:15 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pNyVy-0001d2-2W; Fri, 03 Feb 2023 17:02:14 +0100 Date: Fri, 3 Feb 2023 17:02:14 +0100 From: Sascha Hauer To: Krzysztof Kozlowski Cc: linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Heiko Stuebner , Kyungmin Park , MyungJoo Ham , Will Deacon , Mark Rutland , kernel@pegutronix.de, Michael Riesch Subject: Re: [PATCH 18/18] dt-bindings: devfreq: event: convert Rockchip DFI binding to yaml Message-ID: <20230203160214.GZ13319@pengutronix.de> References: <20230203125012.3804008-1-s.hauer@pengutronix.de> <20230203125012.3804008-19-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_080221_184178_582B7608 X-CRM114-Status: GOOD ( 27.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 04:14:56PM +0100, Krzysztof Kozlowski wrote: > On 03/02/2023 13:50, Sascha Hauer wrote: > > Convert the Rockchip DFI binding to yaml. While at it add the newly > > supported rk3568-dfi to the binding. > > > > Signed-off-by: Sascha Hauer > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. That's what I did. I skipped you and Rob because I know you're wathcing the list anyway. > > diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > new file mode 100644 > > index 0000000000000..e082a0df7895a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip-dfi.yaml > > rockchip,dfi.yaml ok. > > > @@ -0,0 +1,38 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/devfreq/event/rockchip-dfi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip DFI > > + > > +maintainers: > > + - Sascha Hauer > > + > > +properties: > > + compatible: > > + enum: > > + - rk3399-dfi > > + - rk3568-dfi > > These are not correct compatibles. What's wrong with them? > > > + > > + clocks: > > + maxItems: 1 > > + > > + rockchip,pmu: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: > > + Phandle to the syscon managing the "PMU general register files". > > + > > +required: > > + - compatible > > + - reg > > clocks were required They are no longer, the RK3568 doesn't have a clock. Do I have to add something to make the clock optional on RK3568 only? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel