All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>,
	Len Brown <len.brown@intel.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	x86@kernel.org
Subject: Re: [tip: sched/core] sched/topology: Introduce sched_group::flags
Date: Tue, 23 May 2023 12:59:35 +0200	[thread overview]
Message-ID: <20230523105935.GN83892@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <163344312261.25758.16010066552550079330.tip-bot2@tip-bot2>

On Tue, Oct 05, 2021 at 02:12:02PM -0000, tip-bot2 for Ricardo Neri wrote:

> index 4e8698e..c56faae 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -716,8 +716,20 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)
>  		tmp = sd;
>  		sd = sd->parent;
>  		destroy_sched_domain(tmp);
> -		if (sd)
> +		if (sd) {
> +			struct sched_group *sg = sd->groups;
> +
> +			/*
> +			 * sched groups hold the flags of the child sched
> +			 * domain for convenience. Clear such flags since
> +			 * the child is being destroyed.
> +			 */
> +			do {
> +				sg->flags = 0;
> +			} while (sg != sd->groups);


I happened to be reading this here code and aren't we missing:

	sg = sg->next;

somewhere in that loop?

  reply	other threads:[~2023-05-23 11:40 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  1:18 [PATCH v5 0/6] sched/fair: Fix load balancing of SMT siblings with ASYM_PACKING Ricardo Neri
2021-09-11  1:18 ` Ricardo Neri
2021-09-11  1:18 ` [PATCH v5 1/6] x86/sched: Decrease further the priorities of SMT siblings Ricardo Neri
2021-09-11  1:18   ` Ricardo Neri
2021-09-21  7:27   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2021-10-05 14:12   ` tip-bot2 for Ricardo Neri
2021-09-11  1:18 ` [PATCH v5 2/6] sched/topology: Introduce sched_group::flags Ricardo Neri
2021-09-11  1:18   ` Ricardo Neri
2021-09-17 15:26   ` Vincent Guittot
2021-09-17 15:26     ` Vincent Guittot
2021-09-21  7:27   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2021-10-05 14:12   ` tip-bot2 for Ricardo Neri
2023-05-23 10:59     ` Peter Zijlstra [this message]
2023-05-24 13:02       ` Vincent Guittot
2021-09-11  1:18 ` [PATCH v5 3/6] sched/fair: Optimize checking for group_asym_packing Ricardo Neri
2021-09-11  1:18   ` Ricardo Neri
2021-09-17 15:26   ` Vincent Guittot
2021-09-17 15:26     ` Vincent Guittot
2021-09-21  7:27   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2021-10-05 14:12   ` tip-bot2 for Ricardo Neri
2021-09-11  1:18 ` [PATCH v5 4/6] sched/fair: Provide update_sg_lb_stats() with sched domain statistics Ricardo Neri
2021-09-11  1:18   ` Ricardo Neri
2021-09-17 15:27   ` Vincent Guittot
2021-09-17 15:27     ` Vincent Guittot
2021-09-21  7:27   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2021-10-05 14:12   ` tip-bot2 for Ricardo Neri
2021-09-11  1:18 ` [PATCH v5 5/6] sched/fair: Carve out logic to mark a group for asymmetric packing Ricardo Neri
2021-09-11  1:18   ` Ricardo Neri
2021-09-17 15:27   ` Vincent Guittot
2021-09-17 15:27     ` Vincent Guittot
2021-09-21  7:27   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2021-10-05 14:12   ` tip-bot2 for Ricardo Neri
2021-09-11  1:18 ` [PATCH v5 6/6] sched/fair: Consider SMT in ASYM_PACKING load balance Ricardo Neri
2021-09-11  1:18   ` Ricardo Neri
2021-09-15 15:43   ` Vincent Guittot
2021-09-15 15:43     ` Vincent Guittot
2021-09-17  1:00     ` Ricardo Neri
2021-09-17  1:00       ` Ricardo Neri
2021-09-17  7:41       ` Vincent Guittot
2021-09-17  7:41         ` Vincent Guittot
2021-09-17 15:25       ` Vincent Guittot
2021-09-17 15:25         ` Vincent Guittot
2021-09-17 18:46         ` Peter Zijlstra
2021-09-17 18:46           ` Peter Zijlstra
2021-09-18  9:33           ` Vincent Guittot
2021-09-18  9:33             ` Vincent Guittot
2021-09-21  7:27   ` [tip: sched/core] " tip-bot2 for Ricardo Neri
2021-10-01  9:33   ` [PATCH v5 6/6] " Guillaume Tucker
2021-10-01  9:33     ` Guillaume Tucker
2021-10-01  9:40     ` Guillaume Tucker
2021-10-01  9:40       ` Guillaume Tucker
2021-10-01 10:25     ` Vincent Guittot
2021-10-01 10:25       ` Vincent Guittot
2021-10-01 17:43       ` Ricardo Neri
2021-10-01 17:43         ` Ricardo Neri
2021-10-05 14:12   ` [tip: sched/core] " tip-bot2 for Ricardo Neri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230523105935.GN83892@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=joel@joelfernandes.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=vincent.guittot@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.