All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: shuah@kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Muhammad Usama Anjum <usama.anjum@collabora.com>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Nathan Chancellor <nathan@kernel.org>,
	 fenghua.yu@intel.com, reinette.chatre@intel.com
Subject: [PATCH v2 06/10] selftests/resctrl: ksft_exit_skip() does not return
Date: Wed, 24 Apr 2024 10:24:09 -0700	[thread overview]
Message-ID: <20240424-ksft-exit-int-to-void-v2-6-c35f3b8c9ca0@kernel.org> (raw)
In-Reply-To: <20240424-ksft-exit-int-to-void-v2-0-c35f3b8c9ca0@kernel.org>

After commit f7d5bcd35d42 ("selftests: kselftest: Mark functions that
unconditionally call exit() as __noreturn"), ksft_exit_...() functions
are marked as __noreturn, which means the return type should not be
'int' but 'void' because they are not returning anything (and never were
since exit() has always been called).

To facilitate updating the return type of these functions, remove
'return' before the calls to ksft_exit_skip(), as __noreturn prevents
the compiler from warning that a caller of ksft_exit_skip() does not
return a value because the program will terminate upon calling these
functions.

Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
Cc: fenghua.yu@intel.com
Cc: reinette.chatre@intel.com
---
 tools/testing/selftests/resctrl/resctrl_tests.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index 348d17cb2a84..ecbb7605a981 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -247,13 +247,13 @@ int main(int argc, char **argv)
 	 * 2. We execute perf commands
 	 */
 	if (geteuid() != 0)
-		return ksft_exit_skip("Not running as root. Skipping...\n");
+		ksft_exit_skip("Not running as root. Skipping...\n");
 
 	if (!check_resctrlfs_support())
-		return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config option.\n");
+		ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config option.\n");
 
 	if (umount_resctrlfs())
-		return ksft_exit_skip("resctrl FS unmount failed.\n");
+		ksft_exit_skip("resctrl FS unmount failed.\n");
 
 	filter_dmesg();
 

-- 
2.44.0


  parent reply	other threads:[~2024-04-24 17:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 17:24 [PATCH v2 00/10] selftests: Make ksft_exit functions return void instead of int Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 01/10] selftests/clone3: ksft_exit functions do not return Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 02/10] selftests/ipc: " Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 03/10] selftests: membarrier: ksft_exit_pass() does " Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 04/10] selftests/mm: ksft_exit functions do " Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 05/10] selftests: pidfd: " Nathan Chancellor
2024-04-24 17:24 ` Nathan Chancellor [this message]
2024-04-24 17:24 ` [PATCH v2 07/10] selftests: sync: ksft_exit_pass() does " Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 08/10] selftests: timers: ksft_exit functions do " Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 09/10] selftests: x86: ksft_exit_pass() does " Nathan Chancellor
2024-04-24 17:24 ` [PATCH v2 10/10] selftests: kselftest: Make ksft_exit functions return void instead of int Nathan Chancellor
2024-04-25 14:39 ` [PATCH v2 00/10] selftests: " Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240424-ksft-exit-int-to-void-v2-6-c35f3b8c9ca0@kernel.org \
    --to=nathan@kernel.org \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=usama.anjum@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.