From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Janosch Frank <frankja@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit
Date: Wed, 10 Mar 2021 21:49:22 +0100 [thread overview]
Message-ID: <204A69C9-45EF-4613-8BC4-E2CF18E63180@redhat.com> (raw)
In-Reply-To: <5630635a-f605-dd73-4b06-844988f17dc6@redhat.com>
> Am 09.03.2021 um 22:05 schrieb Thomas Huth <thuth@redhat.com>:
>
> On 04/03/2021 09.10, David Hildenbrand wrote:
>>> On 03.03.21 22:36, Richard Henderson wrote:
>>> On 3/3/21 1:22 PM, David Hildenbrand wrote:
>>>>
>>>>> Am 03.03.2021 um 22:19 schrieb Richard Henderson <richard.henderson@linaro.org>:
>>>>>
>>>>> On 3/3/21 1:11 PM, David Hildenbrand wrote:
>>>>>> MMIO on s390x? :)
>>>>>
>>>>> hw/s390x/s390-pci-bus.c, memory_region_init_io*().
>>>>>
>>>>
>>>> ... part of system address space where a CPU could stumble over it?
>>>
>>> Impossible to tell within 3 layers of object wrappers. :-(
>>> I suppose I have no idea how "pci" was hacked onto s390x.
>> You've used the right words to describe "pci" (!) on s390x.
>> IIRC, there is no MMIO: configuration space accesses etc. are performed using special access instructions - which will "emulate" the MMIO access performed on other archs via simple read/write instructions.
>> Ordinary instructions (e.g., mvpg) that operate on the system address space should never stumble over MMIO regions - because that concept does not exist on s390x.
>
> Sorry, guys, you've lost me here ... is there now something left to do for this patch or is it good as it is?
I think that check for invalid TLB should be replaced by a check against host == NULL.
next prev parent reply other threads:[~2021-03-10 20:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 13:28 [PATCH v4] target/s390x: Implement the MVPG condition-code-option bit Thomas Huth
2021-03-03 18:22 ` Richard Henderson
2021-03-03 19:39 ` David Hildenbrand
2021-03-03 21:05 ` Richard Henderson
2021-03-03 21:11 ` David Hildenbrand
2021-03-03 21:19 ` Richard Henderson
2021-03-03 21:22 ` David Hildenbrand
2021-03-03 21:36 ` Richard Henderson
2021-03-04 8:10 ` David Hildenbrand
2021-03-04 8:17 ` Cornelia Huck
2021-03-09 21:05 ` Thomas Huth
2021-03-10 20:49 ` David Hildenbrand [this message]
2021-03-11 10:21 ` Cornelia Huck
2021-03-11 14:03 ` David Hildenbrand
2021-03-11 15:58 ` Richard Henderson
2021-03-11 16:00 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204A69C9-45EF-4613-8BC4-E2CF18E63180@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.