Re: [PATCH v9 00/14] module: core code clean up

From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	Luis Chamberlain <mcgrof@kernel.org>
Cc: Lucas De Marchi <lucas.de.marchi@gmail.com>,
	"pmladek@suse.com" <pmladek@suse.com>,
	"cl@linux.com" <cl@linux.com>, "mbenes@suse.cz" <mbenes@suse.cz>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"jeyu@kernel.org" <jeyu@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
	"void@manifault.com" <void@manifault.com>,
	"atomlin@atomlin.com" <atomlin@atomlin.com>,
	"allen.lkml@gmail.com" <allen.lkml@gmail.com>,
	"joe@perches.com" <joe@perches.com>,
	"msuchanek@suse.de" <msuchanek@suse.de>,
	"oleksandr@natalenko.name" <oleksandr@natalenko.name>,
	"jason.wessel@windriver.com" <jason.wessel@windriver.com>,
	"daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
	Aaron Tomlin <atomlin@redhat.com>
Subject: Re: [PATCH v9 00/14] module: core code clean up
Date: Tue, 1 Mar 2022 17:43:44 +0000	[thread overview]
Message-ID: <20fddc03-4e31-d77a-024b-103d3c166d0f@csgroup.eu> (raw)
In-Reply-To: <20220301171555.tzrqrmhtv2tkxtaj@ldmartin-desk2>

Le 01/03/2022 à 18:15, Lucas De Marchi a écrit :
> On Tue, Mar 01, 2022 at 08:01:23AM -0800, Luis Chamberlain wrote:
>> On Tue, Mar 01, 2022 at 07:44:26AM +0000, Christophe Leroy wrote:
>>>
>>>
>>> Le 01/03/2022 à 01:21, Luis Chamberlain a écrit :
>>> >
>>> > We should run kmod tests as well.
>>> >
>>>
>>> I tried to build kmod tests, but I get a crazy result:
>>>
>>>
>>> $ ./configure --host=ppc-linux --prefix=/usr/local
>>>
>>> $ make
>>>
>>> $ cd testsuite
>>>
>>> $ make
>>>
>>> $ file test-list
>>> test-list: ELF 32-bit MSB executable, PowerPC or cisco 4500, version 1
>>> (SYSV), dynamically linked, interpreter /lib/ld.so.1, for GNU/Linux
>>> 3.2.0, with debug_info, not stripped
>>>
>>> $ file module-playground/mod-loop-a.ko
>>> module-playground/mod-loop-a.ko: ELF 64-bit LSB relocatable, x86-64,
>>> version 1 (SYSV),
>>> BuildID[sha1]=d46956a4fd36d8d3467806c31831c81217a573f5, with debug_info,
>>> not stripped
>>>
>>>
>>>
>>> How do I get it to crossbuild proper PowerPC module ?
> 
> do I understand correctly that you want to crossbuild kmod + kernel
> modules to do your test? why?

Yes, I want to build the tests on my PC and run them on a powerpc board.

> 
> If you really need it, then beware we just chainload the kernel build
> for the out-of-tree modules when compiling the test modules. Something
> like this should work:
> 
>      make V=1 KDIR=$HOME/p/gfx-internal/linux-arm64/ ARCH=arm64 
> CROSS_COMPILE=aarch64-linux-gnu- check
> 
> But running the cross built binaries is probably not what you want?

I want to run them on the board.

> 
> Another thing is that unless you are patching kmod binaries or libkmod,
> the testsuite won't test much. kmod's testsuite don't test anything on
> the kernel side... the kernel part is mocked by the testsuite itself.
> Adding proper integration with the kernel part is possible, but not
> something ready.

Ah, I see.

I made non trivial modification on kernel modules handling (see series 
at 
https://patchwork.kernel.org/project/linux-modules/cover/cover.1645607143.git.christophe.leroy@csgroup.eu/) 
and Luis suggested to run kmod test suite to perform regression testing.

Christophe