All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Vamsi Krishna Attunuru <vattunuru@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] octeontx2: do not put escape sequences in log
Date: Tue, 16 Jul 2019 00:12:51 +0200	[thread overview]
Message-ID: <2158172.d9Q5PLEVjj@xps> (raw)
In-Reply-To: <BYAPR18MB2424F4C46364B88B478FFEBFC8F30@BYAPR18MB2424.namprd18.prod.outlook.com>

11/07/2019 10:16, Jerin Jacob Kollanukkaran:
> From: Stephen Hemminger <stephen@networkplumber.org>
> > Putting color escape sequences in the log look pretty for the developer but
> > fails in real world DPDK usage. A real application will put DPDK log to syslog,
> > and syslog does not handle escape sequences.
> > 
> > Fixes: dd543124cd93 ("common/octeontx2: add runtime log infra")
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Request to change git commit as "common/octeontx2: remove escape sequences in log" on apply.
> 
> With change:
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks



  reply	other threads:[~2019-07-15 22:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11  8:16 [dpdk-dev] [PATCH] octeontx2: do not put escape sequences in log Jerin Jacob Kollanukkaran
2019-07-15 22:12 ` Thomas Monjalon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-07-11  3:11 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2158172.d9Q5PLEVjj@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=stephen@networkplumber.org \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.