Re: [PATCH v1 1/1] cmd: setexpr: add dec operation for converting variable to decimal

From: Wolfgang Denk <wd@denx.de>
To: roland.gaudig-oss@weidmueller.com
Cc: u-boot@lists.denx.de,
	"Roland Gaudig" <roland.gaudig@weidmueller.com>,
	"Marek Behún" <marek.behun@nic.cz>,
	"Simon Glass" <sjg@chromium.org>
Subject: Re: [PATCH v1 1/1] cmd: setexpr: add dec operation for converting variable to decimal
Date: Wed, 23 Jun 2021 08:03:01 +0200	[thread overview]
Message-ID: <223201.1624428181@gemini.denx.de> (raw)
In-Reply-To: <20210622135042.133904-2-roland.gaudig-oss@weidmueller.com>

Dear Roland,

In message <20210622135042.133904-2-roland.gaudig-oss@weidmueller.com> you wrote:
>
> This patch extends the setexpr command with a dec operator to
> convert an input value to decimal.
...
> +	/* hexadecimal to decimal conversion: "setexpr name dec value" */
> +	if (argc == 4 && (strcmp(argv[2], "dec") == 0)) {
> +		w = cmd_get_data_size(argv[3], 4);
> +		a = get_arg(argv[3], w);
> +		return env_set_ulong(argv[1], a);
> +	}

Should there not be a test for 4 arguments and the third _not_ being
"dec" ?  Like "setexpr foo hex 42" ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
A wise man asks himself the reason for his  mistakes,  while  a  fool
will ask others.