From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9371723A9; Sun, 6 Nov 2022 09:12:26 +0000 (UTC) Received: by mail-ej1-f54.google.com with SMTP id y14so23101734ejd.9; Sun, 06 Nov 2022 01:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MwgxMlKkvmgXvqoUQfR3pyVEjoh63QBFd6KeQ5QkK3Q=; b=jIxTKOmWNL7JnXZXgzt06JEdm9koiXW9A5AC5HFYmwRfbcEE1WvFJvRyXahxhiLwvv vvp5pONw1P6EU4XZgH3G7hdIdkYfxA1M4b9oum1nUbJ5/YhoEw8szFFSc7PmfKV38sIO 3VBb/xBr7i8Dw1H6uaWu/fWbdxRXN0dwI32tcYeJpv7im+WLgF9rbJIoyeBsyns2QMC0 rZH+QxkOMB+y6stoTaVNUvw3nQ8K/0051x9Jfqunutr/MgbQymJl6zKQnWbmVU4cMSwW XwOZBTjpXJzgRdyEGpCA2PrrrOlcJ16VA+ab+IXQ+ueWVeNT1RyP57Dv9i4WX1UqlRJk 0S3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MwgxMlKkvmgXvqoUQfR3pyVEjoh63QBFd6KeQ5QkK3Q=; b=IXP5s7LlutFCzMlsUeoGaUQIAbk1ZauL574lgM+lzdzqRJyk0SiZHlG9hl4i4bOQpq MYgW+kQSSWxikFKpprxJ5ydZ/qoGu6SfronwDz1sgvjmE8KDaFn3u0EZH/n/cccW4saz LuGkNCi4enHDwh2damCvcOfiXcfdfmm9CTycgtZSWh8oiYleNuOSrJFgX4VsrQ2BW7pF jY4J3J9au4YN7aTuK7XJuMdre12r+f1UGbP7n50vYNEviqxH3zrc/xZgVFmCI7lswnDk 5fvav/oVC+MbK9qWjZCJy8FLC5yO84xFB47i8AG9rOMhLgYyWFKbaFppO3tHhpie6Pi9 3hRA== X-Gm-Message-State: ACrzQf1u2NLVgSrUwlW//H6qsolfh/gAzHUR4RxbJzvGgDq2vp7uPLft 6ePqLYutrBEbjUT9tcKtIsQ= X-Google-Smtp-Source: AMsMyM61T2Dbg/kh3O2rjB8fG5pZ9TJGhPo0uOztCGusLOrdZtIIiyBwdbtErIpCnkLiigwdwId/Pg== X-Received: by 2002:a17:906:5f8a:b0:7ad:ca14:3ae with SMTP id a10-20020a1709065f8a00b007adca1403aemr36671412eju.509.1667725944828; Sun, 06 Nov 2022 01:12:24 -0800 (PST) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id q3-20020aa7cc03000000b00461aebb2fe2sm2356015edt.54.2022.11.06.01.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 01:12:24 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v8 3/6] staging: media: Add support for the Allwinner A31 ISP Date: Sun, 06 Nov 2022 10:12:22 +0100 Message-ID: <2320492.NG923GbCHz@jernej-laptop> In-Reply-To: <20221103163717.246217-4-paul.kocialkowski@bootlin.com> References: <20221103163717.246217-1-paul.kocialkowski@bootlin.com> <20221103163717.246217-4-paul.kocialkowski@bootlin.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne =C4=8Detrtek, 03. november 2022 ob 17:37:14 CET je Paul Kocialkowski=20 napisal(a): > Some Allwinner platforms come with an Image Signal Processor, which > supports various features in order to enhance and transform data > received by image sensors into good-looking pictures. In most cases, > the data is raw bayer, which gets internally converted to RGB and > finally YUV, which is what the hardware produces. >=20 > This driver supports ISPs that are similar to the A31 ISP, which was > the first standalone ISP found in Allwinner platforms. Simpler ISP > blocks were found in the A10 and A20, where they are tied to a CSI > controller. Newer generations of Allwinner SoCs (starting with the > H6, H616, etc) come with a new camera subsystem and revised ISP. > Even though these previous and next-generation ISPs are somewhat > similar to the A31 ISP, they have enough significant differences to > be out of the scope of this driver. >=20 > While the ISP supports many features, including 3A and many > enhancement blocks, this implementation is limited to the following: > - V3s (V3/S3) platform support; > - Bayer media bus formats as input; > - Semi-planar YUV (NV12/NV21) as output; > - Debayering with per-component gain and offset configuration; > - 2D noise filtering with configurable coefficients. >=20 > Since many features are missing from the associated uAPI, the driver > is aimed to integrate staging until all features are properly > described. >=20 > On the technical side, it uses the v4l2 and media controller APIs, > with a video node for capture, a processor subdev and a video node > for parameters submission. A specific uAPI structure and associated > v4l2 meta format are used to configure parameters of the supported > modules. >=20 > One particular thing about the hardware is that configuration for > module registers needs to be stored in a DMA buffer and gets copied > to actual registers by the hardware at the next vsync, when instructed > by a flag. This is handled by the "state" mechanism in the driver. >=20 > Signed-off-by: Paul Kocialkowski This is pretty complex piece of code, so I trust you that it's tested. Acked-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6053C4332F for ; Sun, 6 Nov 2022 09:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lo80JI5GMDJeoas0c2XgWo8PqfId3XA1ud8Xq/+XCYM=; b=WD60xQFO2Kd9tH b0fAeShRTvsMsXyOcC13fQEsG5AbgMZVPrJWhVnd77bFe84mz9lrd1FKkXqade4oXmvGrn/hAF+f2 xUb5o7ssVtScxYXSa7Fdxwe0ioc1WlfSTjCRziQAwsMsFktch7f4xu4UJCZk6nf5KWWffc3GCzbk+ FOHtAsv+9y4PW62Q6TM2ztc8bEmK8wZ9GokPmFjgDDXofLrnuTVeIQgqm8sRGD/A1/eqZakbp2M1m hAJO6EqB1JMQekQ6W+8+2ymzwk5/GqQKp2GMgegjtDAEzZSKFcuYi0WKR4hac3LyydIPXpWxzWtNa nE/MGluOITxOwzQkMK8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1orbhf-007otF-Hm; Sun, 06 Nov 2022 09:12:31 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1orbhc-007osf-Df for linux-arm-kernel@lists.infradead.org; Sun, 06 Nov 2022 09:12:29 +0000 Received: by mail-ej1-x633.google.com with SMTP id bj12so23032281ejb.13 for ; Sun, 06 Nov 2022 01:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MwgxMlKkvmgXvqoUQfR3pyVEjoh63QBFd6KeQ5QkK3Q=; b=jIxTKOmWNL7JnXZXgzt06JEdm9koiXW9A5AC5HFYmwRfbcEE1WvFJvRyXahxhiLwvv vvp5pONw1P6EU4XZgH3G7hdIdkYfxA1M4b9oum1nUbJ5/YhoEw8szFFSc7PmfKV38sIO 3VBb/xBr7i8Dw1H6uaWu/fWbdxRXN0dwI32tcYeJpv7im+WLgF9rbJIoyeBsyns2QMC0 rZH+QxkOMB+y6stoTaVNUvw3nQ8K/0051x9Jfqunutr/MgbQymJl6zKQnWbmVU4cMSwW XwOZBTjpXJzgRdyEGpCA2PrrrOlcJ16VA+ab+IXQ+ueWVeNT1RyP57Dv9i4WX1UqlRJk 0S3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MwgxMlKkvmgXvqoUQfR3pyVEjoh63QBFd6KeQ5QkK3Q=; b=lWQGerfXK7qktuOyfhpifsCEN9diVZ8G8Cqns6gI0OEkSshn2CilAsnzA5eB/EutDI Gt8RxMwY3wzzTUiiy17PkQz9uNRVdSFV5KCnAcfNf7wKCp8U+cIXsT3pnuCmLOyeZMV6 gMANdaEC2NUknOvNy2t5Zj9XdMmPH8ZxybsfVnqwrzW76nfFhkHHGkpXfnd2OcbDq7wh mQEpokMOo8qIY4CpvQfzqtvgoPH914fF8CbMrAQsjXRN1q3OhBPxcvE9tqoUMG6CHabi /BX3qFxeOA5a9mvAouWIds7y7Ols3SaEMWmcxHxwEtxOH0EpZXfcpovdgPGwX7m5pLX1 jp8g== X-Gm-Message-State: ACrzQf2QLLHKxVXf+KWGGTLjVEhqXw/PBPSTPDZ6INuZbut8cRN3cfBE EAJ8QaUfnTyiQdZkDt4BnDM= X-Google-Smtp-Source: AMsMyM61T2Dbg/kh3O2rjB8fG5pZ9TJGhPo0uOztCGusLOrdZtIIiyBwdbtErIpCnkLiigwdwId/Pg== X-Received: by 2002:a17:906:5f8a:b0:7ad:ca14:3ae with SMTP id a10-20020a1709065f8a00b007adca1403aemr36671412eju.509.1667725944828; Sun, 06 Nov 2022 01:12:24 -0800 (PST) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id q3-20020aa7cc03000000b00461aebb2fe2sm2356015edt.54.2022.11.06.01.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Nov 2022 01:12:24 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Paul Kocialkowski Cc: Paul Kocialkowski , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v8 3/6] staging: media: Add support for the Allwinner A31 ISP Date: Sun, 06 Nov 2022 10:12:22 +0100 Message-ID: <2320492.NG923GbCHz@jernej-laptop> In-Reply-To: <20221103163717.246217-4-paul.kocialkowski@bootlin.com> References: <20221103163717.246217-1-paul.kocialkowski@bootlin.com> <20221103163717.246217-4-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221106_011228_499607_72EB1959 X-CRM114-Status: GOOD ( 21.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIMSNZXRydGVrLCAwMy4gbm92ZW1iZXIgMjAyMiBvYiAxNzozNzoxNCBDRVQgamUgUGF1bCBL b2NpYWxrb3dza2kgCm5hcGlzYWwoYSk6Cj4gU29tZSBBbGx3aW5uZXIgcGxhdGZvcm1zIGNvbWUg d2l0aCBhbiBJbWFnZSBTaWduYWwgUHJvY2Vzc29yLCB3aGljaAo+IHN1cHBvcnRzIHZhcmlvdXMg ZmVhdHVyZXMgaW4gb3JkZXIgdG8gZW5oYW5jZSBhbmQgdHJhbnNmb3JtIGRhdGEKPiByZWNlaXZl ZCBieSBpbWFnZSBzZW5zb3JzIGludG8gZ29vZC1sb29raW5nIHBpY3R1cmVzLiBJbiBtb3N0IGNh c2VzLAo+IHRoZSBkYXRhIGlzIHJhdyBiYXllciwgd2hpY2ggZ2V0cyBpbnRlcm5hbGx5IGNvbnZl cnRlZCB0byBSR0IgYW5kCj4gZmluYWxseSBZVVYsIHdoaWNoIGlzIHdoYXQgdGhlIGhhcmR3YXJl IHByb2R1Y2VzLgo+IAo+IFRoaXMgZHJpdmVyIHN1cHBvcnRzIElTUHMgdGhhdCBhcmUgc2ltaWxh ciB0byB0aGUgQTMxIElTUCwgd2hpY2ggd2FzCj4gdGhlIGZpcnN0IHN0YW5kYWxvbmUgSVNQIGZv dW5kIGluIEFsbHdpbm5lciBwbGF0Zm9ybXMuIFNpbXBsZXIgSVNQCj4gYmxvY2tzIHdlcmUgZm91 bmQgaW4gdGhlIEExMCBhbmQgQTIwLCB3aGVyZSB0aGV5IGFyZSB0aWVkIHRvIGEgQ1NJCj4gY29u dHJvbGxlci4gTmV3ZXIgZ2VuZXJhdGlvbnMgb2YgQWxsd2lubmVyIFNvQ3MgKHN0YXJ0aW5nIHdp dGggdGhlCj4gSDYsIEg2MTYsIGV0YykgY29tZSB3aXRoIGEgbmV3IGNhbWVyYSBzdWJzeXN0ZW0g YW5kIHJldmlzZWQgSVNQLgo+IEV2ZW4gdGhvdWdoIHRoZXNlIHByZXZpb3VzIGFuZCBuZXh0LWdl bmVyYXRpb24gSVNQcyBhcmUgc29tZXdoYXQKPiBzaW1pbGFyIHRvIHRoZSBBMzEgSVNQLCB0aGV5 IGhhdmUgZW5vdWdoIHNpZ25pZmljYW50IGRpZmZlcmVuY2VzIHRvCj4gYmUgb3V0IG9mIHRoZSBz Y29wZSBvZiB0aGlzIGRyaXZlci4KPiAKPiBXaGlsZSB0aGUgSVNQIHN1cHBvcnRzIG1hbnkgZmVh dHVyZXMsIGluY2x1ZGluZyAzQSBhbmQgbWFueQo+IGVuaGFuY2VtZW50IGJsb2NrcywgdGhpcyBp bXBsZW1lbnRhdGlvbiBpcyBsaW1pdGVkIHRvIHRoZSBmb2xsb3dpbmc6Cj4gLSBWM3MgKFYzL1Mz KSBwbGF0Zm9ybSBzdXBwb3J0Owo+IC0gQmF5ZXIgbWVkaWEgYnVzIGZvcm1hdHMgYXMgaW5wdXQ7 Cj4gLSBTZW1pLXBsYW5hciBZVVYgKE5WMTIvTlYyMSkgYXMgb3V0cHV0Owo+IC0gRGViYXllcmlu ZyB3aXRoIHBlci1jb21wb25lbnQgZ2FpbiBhbmQgb2Zmc2V0IGNvbmZpZ3VyYXRpb247Cj4gLSAy RCBub2lzZSBmaWx0ZXJpbmcgd2l0aCBjb25maWd1cmFibGUgY29lZmZpY2llbnRzLgo+IAo+IFNp bmNlIG1hbnkgZmVhdHVyZXMgYXJlIG1pc3NpbmcgZnJvbSB0aGUgYXNzb2NpYXRlZCB1QVBJLCB0 aGUgZHJpdmVyCj4gaXMgYWltZWQgdG8gaW50ZWdyYXRlIHN0YWdpbmcgdW50aWwgYWxsIGZlYXR1 cmVzIGFyZSBwcm9wZXJseQo+IGRlc2NyaWJlZC4KPiAKPiBPbiB0aGUgdGVjaG5pY2FsIHNpZGUs IGl0IHVzZXMgdGhlIHY0bDIgYW5kIG1lZGlhIGNvbnRyb2xsZXIgQVBJcywKPiB3aXRoIGEgdmlk ZW8gbm9kZSBmb3IgY2FwdHVyZSwgYSBwcm9jZXNzb3Igc3ViZGV2IGFuZCBhIHZpZGVvIG5vZGUK PiBmb3IgcGFyYW1ldGVycyBzdWJtaXNzaW9uLiBBIHNwZWNpZmljIHVBUEkgc3RydWN0dXJlIGFu ZCBhc3NvY2lhdGVkCj4gdjRsMiBtZXRhIGZvcm1hdCBhcmUgdXNlZCB0byBjb25maWd1cmUgcGFy YW1ldGVycyBvZiB0aGUgc3VwcG9ydGVkCj4gbW9kdWxlcy4KPiAKPiBPbmUgcGFydGljdWxhciB0 aGluZyBhYm91dCB0aGUgaGFyZHdhcmUgaXMgdGhhdCBjb25maWd1cmF0aW9uIGZvcgo+IG1vZHVs ZSByZWdpc3RlcnMgbmVlZHMgdG8gYmUgc3RvcmVkIGluIGEgRE1BIGJ1ZmZlciBhbmQgZ2V0cyBj b3BpZWQKPiB0byBhY3R1YWwgcmVnaXN0ZXJzIGJ5IHRoZSBoYXJkd2FyZSBhdCB0aGUgbmV4dCB2 c3luYywgd2hlbiBpbnN0cnVjdGVkCj4gYnkgYSBmbGFnLiBUaGlzIGlzIGhhbmRsZWQgYnkgdGhl ICJzdGF0ZSIgbWVjaGFuaXNtIGluIHRoZSBkcml2ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1 bCBLb2NpYWxrb3dza2kgPHBhdWwua29jaWFsa293c2tpQGJvb3RsaW4uY29tPgoKVGhpcyBpcyBw cmV0dHkgY29tcGxleCBwaWVjZSBvZiBjb2RlLCBzbyBJIHRydXN0IHlvdSB0aGF0IGl0J3MgdGVz dGVkLgoKQWNrZWQtYnk6IEplcm5laiBTa3JhYmVjIDxqZXJuZWouc2tyYWJlY0BnbWFpbC5jb20+ CgpCZXN0IHJlZ2FyZHMsCkplcm5lagoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==