RE: [PATCH v2 10/10] MIPS: generic: Add optional support for Android kernel

[Miodrag Dinic <Miodrag.Dinic@imgtec.com>]

Hi Greg,

> Why is this a MIPS config file?  What about the "generic" android
> configs we already have?  Shouldn't they work just as well here?

You are right, this should not be MIPS specific config.
This patch will be omitted in the next version.

Thanks!

Kind regards,
Miodrag

________________________________________
From: Greg Kroah-Hartman [gregkh@linuxfoundation.org]
Sent: Wednesday, June 28, 2017 6:27 PM
To: Aleksandar Markovic
Cc: linux-mips@linux-mips.org; Miodrag Dinic; Goran Ferenc; Aleksandar Markovic; David S. Miller; Douglas Leung; James Hogan; linux-kernel@vger.kernel.org; Martin K. Petersen; Mauro Carvalho Chehab; Paul Burton; Petar Jovanovic; Raghu Gandham; Ralf Baechle
Subject: Re: [PATCH v2 10/10] MIPS: generic: Add optional support for Android kernel

On Wed, Jun 28, 2017 at 05:47:03PM +0200, Aleksandar Markovic wrote:
> From: Miodrag Dinic <miodrag.dinic@imgtec.com>
>
> This commit adds new android.config configuration file including
> the most common prerequisites for running Android operating system.
>
> The selected set of platform independent configuration parameters
> have been taken from the official Android kernel repo:
> https://android.googlesource.com/kernel/common/+
> /android-4.4/android/configs/android-base.cfg
>
> android.config will be merged with the selected generic kernel
> configuration only if explicitly specified through environment
> variable OS=android.
>
> Example:
> make ARCH=mips 64r6el_defconfig BOARDS="list of boards" OS=android
>
> android.config file should be occasionally revisited and updated
> with latest requirements from Google.
>
> Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com>
> Signed-off-by: Goran Ferenc <goran.ferenc@imgtec.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
>  MAINTAINERS                              |   1 +
>  arch/mips/Makefile                       |   8 +-
>  arch/mips/configs/generic/android.config | 173 +++++++++++++++++++++++++++++++

Why is this a MIPS config file?  What about the "generic" android
configs we already have?  Shouldn't they work just as well here?

And finally, does this config file fragment pass the latest tests that
Google has for kernel config requirements?

thanks,

greg k-h