From: zhengyongjun <zhengyongjun3@huawei.com>
To: Joe Perches <joe@perches.com>, "andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "opendmb@gmail.com" <opendmb@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>
Subject: 答复: [PATCH net-next] net: mdio: Fix a typo
Date: Wed, 2 Jun 2021 07:43:19 +0000 [thread overview]
Message-ID: <264010307fb24b0193cfd451152bd71d@huawei.com> (raw)
In-Reply-To: <76fd35fe623867c3be3f93b51d5d3461a2eabed9.camel@perches.com>
Russell King told me to do so... Did I understand it wrong?
But from your opinion, I think "Hz" is more appropriate :)
```
Russell King <linux@armlinux.org.uk>
On Tue, Jun 01, 2021 at 10:18:59PM +0800, Zheng Yongjun wrote:
> informations ==> information
> typicaly ==> typically
> derrive ==> derive
> eventhough ==> even though
If you're doing this, then please also change "hz" to "Hz". The unit of frequency is the latter, not the former. Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
```
-----邮件原件-----
发件人: Joe Perches [mailto:joe@perches.com]
发送时间: 2021年6月2日 15:25
收件人: zhengyongjun <zhengyongjun3@huawei.com>; andrew@lunn.ch; hkallweit1@gmail.com; davem@davemloft.net; kuba@kernel.org; bcm-kernel-feedback-list@broadcom.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: opendmb@gmail.com; f.fainelli@gmail.com; linux@armlinux.org.uk
主题: Re: [PATCH net-next] net: mdio: Fix a typo
On Wed, 2021-06-02 at 14:39 +0800, Zheng Yongjun wrote:
> Hz ==> hz
[]
> diff --git a/drivers/net/mdio/mdio-bcm-unimac.c b/drivers/net/mdio/mdio-bcm-unimac.c
[]
> @@ -203,7 +203,7 @@ static void unimac_mdio_clk_set(struct unimac_mdio_priv *priv)
> return;
> }
>
> - /* The MDIO clock is the reference clock (typically 250MHz) divided by
> + /* The MDIO clock is the reference clock (typically 250Mhz) divided by
No thanks.
MHz is typical, Mhz is not.
$ git grep -w -i -o -h mhz | sort |uniq -c | sort -rn
5042 MHz
571 MHZ
398 Mhz
353 mhz
10 mHz
next prev parent reply other threads:[~2021-06-02 7:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 6:39 [PATCH net-next] net: mdio: Fix a typo Zheng Yongjun
2021-06-02 7:25 ` Joe Perches
2021-06-02 7:43 ` zhengyongjun [this message]
2021-06-02 10:07 ` 答复: " Russell King (Oracle)
2021-06-02 10:09 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=264010307fb24b0193cfd451152bd71d@huawei.com \
--to=zhengyongjun3@huawei.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.