From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C142C433E0 for ; Tue, 23 Jun 2020 09:12:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64DDA20768 for ; Tue, 23 Jun 2020 09:12:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GmOJj0S2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731944AbgFWJML (ORCPT ); Tue, 23 Jun 2020 05:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731887AbgFWJMK (ORCPT ); Tue, 23 Jun 2020 05:12:10 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8325C061573 for ; Tue, 23 Jun 2020 02:12:10 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id h22so1281230pjf.1 for ; Tue, 23 Jun 2020 02:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=Kz9xCuMfQVP8nB4fJb2cy6sQoAcFe32EC7VXfNzfbBo=; b=GmOJj0S22ctiemlOSVI1mu09vrvzTcMTOVbSfvHqpVUqYGi8Rl/n4+HYz4i0KsJ16K Gno6hAprmJPOqGa5FjXe5eY4lx53+o4j6nDnmoZs5PGfl3GaXNwANwmhHaIQwvFWoUxy Kbfs6w5fulPRHzgMoCMa3rpVRGyND9kUIz9+KwW2JmXS65PsJlOHfYCmO0e7KNAIA0ML 5jF+BFZ+gyJIkHA1lQ389pf0MJ3EwbLsC6vzRvAcM+2i6RXF5EvBSmjNbCjKNfmPYqOv xsBBUub/H8YO790+32pIDtp6qCZ4yHGKRsv06XealLSKAnoYkAz+Nm8OgdurLgXDYe+/ Cm1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Kz9xCuMfQVP8nB4fJb2cy6sQoAcFe32EC7VXfNzfbBo=; b=nXLKYv6iM2OZze6aKjSjpwpUOOvwCF5FFvjctoJbOYSx0YfT5aACRohe+FxCoUQS1Z ozM1ALo3sLvfS/SHacoVH2gC0Edm/uzCE0gjCy4V66R9sGiIpH3J1DWvFtDkPm7XoXEq gnK6dAA8uc5qPMEgUWxcGka5vhF0SKak40IGEVSY6tfz+n7n5bhN7zeTItDFE4RpmMPm MVh7l3NWJQ3gs1rRJi1KHMo3jOMWIJ2l/GfcLoivBvmPIXQ6G9yQ+lQn0mKjg1VHylyj W5H8JSIY8kNm0vpeQCD/glm78lRZGd8zjNWq+DrxDY/jjU8PG3h3MZljh5iJeHDFJlE6 6SIQ== X-Gm-Message-State: AOAM533WG+FWeXQnZCfkaybK7voqWVQEpyhrnq1gAq1W2dteZKU7/N38 EQINpqwPtXbd7A+Hcekk/4I= X-Google-Smtp-Source: ABdhPJylBD/b7fqsA2zzHIbwr8UEOxTZkL37GEcCozzLqn0bt20VLNTUvoD3HAft0y+BZdcBzWjXLw== X-Received: by 2002:a17:90a:ea05:: with SMTP id w5mr23374362pjy.37.1592903530289; Tue, 23 Jun 2020 02:12:10 -0700 (PDT) Received: from arch ([2601:600:9500:4390::aa23]) by smtp.gmail.com with ESMTPSA id z9sm1811156pjr.39.2020.06.23.02.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 02:12:09 -0700 (PDT) Message-ID: <2699290fb7ab566987da8f648a9234c6a4fbc24e.camel@gmail.com> Subject: Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device From: Deepak Rawat To: Thomas Zimmermann , Sam Ravnborg Cc: linux-hyperv@vger.kernel.org, Stephen Hemminger , David Airlie , Haiyang Zhang , Wei Liu , dri-devel@lists.freedesktop.org, Michael Kelley , Jork Loeser , Wei Hu , K Y Srinivasan Date: Tue, 23 Jun 2020 02:12:09 -0700 In-Reply-To: References: <20200622110623.113546-1-drawat.floss@gmail.com> <20200622110623.113546-2-drawat.floss@gmail.com> <20200622151913.GA655276@ravnborg.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.3 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote: > Hi Deepak > > I did not receive you pat series, so I can only comment on Sam's > reply. > See below for some points. Hi Thomas, Thanks for the review. I wanted to add you in cc list but messed it up with final git send-email. Sorry about that. I am not sure why you didn't received it via dri-devel. The patch series do show up in dri-devel archive. I wonder if other people also have similar issues. > > > > > > + struct hv_device *hdev; > > > +}; > > > + > > > +#define to_hv(_dev) container_of(_dev, struct hyperv_device, > > > dev) > > Could this be a function? Is there a reason to use a function here? > > > > + > > > +/* ----------------------------------------------------------- > > > ----------- */ > > > +/* Hyper-V Synthetic Video > > > Protocol */ > > The comments look awkward. Unless this style has been used within > DRM, > maybe just use > > /* > * ... > */ > This style is copy-paste from cirrus, and bochs also have same style. Perhaps historical. Anyway I agree to I should get rid of this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73919C433DF for ; Tue, 23 Jun 2020 09:12:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4990320738 for ; Tue, 23 Jun 2020 09:12:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GmOJj0S2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4990320738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7AFDF6E984; Tue, 23 Jun 2020 09:12:11 +0000 (UTC) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by gabe.freedesktop.org (Postfix) with ESMTPS id A9FC96E984 for ; Tue, 23 Jun 2020 09:12:10 +0000 (UTC) Received: by mail-pl1-x644.google.com with SMTP id d10so6965247pls.5 for ; Tue, 23 Jun 2020 02:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=Kz9xCuMfQVP8nB4fJb2cy6sQoAcFe32EC7VXfNzfbBo=; b=GmOJj0S22ctiemlOSVI1mu09vrvzTcMTOVbSfvHqpVUqYGi8Rl/n4+HYz4i0KsJ16K Gno6hAprmJPOqGa5FjXe5eY4lx53+o4j6nDnmoZs5PGfl3GaXNwANwmhHaIQwvFWoUxy Kbfs6w5fulPRHzgMoCMa3rpVRGyND9kUIz9+KwW2JmXS65PsJlOHfYCmO0e7KNAIA0ML 5jF+BFZ+gyJIkHA1lQ389pf0MJ3EwbLsC6vzRvAcM+2i6RXF5EvBSmjNbCjKNfmPYqOv xsBBUub/H8YO790+32pIDtp6qCZ4yHGKRsv06XealLSKAnoYkAz+Nm8OgdurLgXDYe+/ Cm1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Kz9xCuMfQVP8nB4fJb2cy6sQoAcFe32EC7VXfNzfbBo=; b=QV5cIQAyETKFJ5ksy2Pj3uRcTSf98aKWJUsu0Gc9bwUCEqOXiBlZcLex9cf10T/i3x GqVmJoYQu+46Z+Db2qwTUl1CsIgn7tx6QIC8LB0PVMhUi2NKk1+LMfxUFY573gD5CnsO iW2h83jCD+YiSNETCPwDqUO6SHVdawZGWrWVJRRoAL17cuLocihXNkeJ9f/lNI0MqLpf zaMF17keTH8yvi7PKQChBekPgbS8TbSrRxJt/uAKJ3I3r2llmdKS+yQt9/FYrq4ZF/tU ChSrneY9G09MlZ84e7fUpjkmz50EWhWhwM795gu1lX4UwQxUZ5xIARUHgbHazcBvs8Vg NwbA== X-Gm-Message-State: AOAM531d3EZaEeo9HEXaH5uiLMdhDwatBCZIkgFQJmepe0Ztdsz3TeTu L05nLyf3dkq+A8wrKQR6RuE= X-Google-Smtp-Source: ABdhPJylBD/b7fqsA2zzHIbwr8UEOxTZkL37GEcCozzLqn0bt20VLNTUvoD3HAft0y+BZdcBzWjXLw== X-Received: by 2002:a17:90a:ea05:: with SMTP id w5mr23374362pjy.37.1592903530289; Tue, 23 Jun 2020 02:12:10 -0700 (PDT) Received: from arch ([2601:600:9500:4390::aa23]) by smtp.gmail.com with ESMTPSA id z9sm1811156pjr.39.2020.06.23.02.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 02:12:09 -0700 (PDT) Message-ID: <2699290fb7ab566987da8f648a9234c6a4fbc24e.camel@gmail.com> Subject: Re: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device From: Deepak Rawat To: Thomas Zimmermann , Sam Ravnborg Date: Tue, 23 Jun 2020 02:12:09 -0700 In-Reply-To: References: <20200622110623.113546-1-drawat.floss@gmail.com> <20200622110623.113546-2-drawat.floss@gmail.com> <20200622151913.GA655276@ravnborg.org> User-Agent: Evolution 3.36.3 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Stephen Hemminger , David Airlie , Haiyang Zhang , Wei Liu , dri-devel@lists.freedesktop.org, Michael Kelley , Jork Loeser , Wei Hu , K Y Srinivasan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 2020-06-23 at 09:59 +0200, Thomas Zimmermann wrote: > Hi Deepak > > I did not receive you pat series, so I can only comment on Sam's > reply. > See below for some points. Hi Thomas, Thanks for the review. I wanted to add you in cc list but messed it up with final git send-email. Sorry about that. I am not sure why you didn't received it via dri-devel. The patch series do show up in dri-devel archive. I wonder if other people also have similar issues. > > > > > > + struct hv_device *hdev; > > > +}; > > > + > > > +#define to_hv(_dev) container_of(_dev, struct hyperv_device, > > > dev) > > Could this be a function? Is there a reason to use a function here? > > > > + > > > +/* ----------------------------------------------------------- > > > ----------- */ > > > +/* Hyper-V Synthetic Video > > > Protocol */ > > The comments look awkward. Unless this style has been used within > DRM, > maybe just use > > /* > * ... > */ > This style is copy-paste from cirrus, and bochs also have same style. Perhaps historical. Anyway I agree to I should get rid of this. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel