All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bowers, AndrewX <andrewx.bowers@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue v5 PATCH 4/7] net: store	port/representator id in metadata_dst
Date: Mon, 30 Jan 2017 21:36:17 +0000	[thread overview]
Message-ID: <26D9FDECA4FBDD4AADA65D8E2FC68A4A0FA5D4F7@ORSMSX104.amr.corp.intel.com> (raw)
In-Reply-To: <1485392057-3261-5-git-send-email-sridhar.samudrala@intel.com>

> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Sridhar Samudrala
> Sent: Wednesday, January 25, 2017 4:54 PM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
> Subject: [Intel-wired-lan] [next-queue v5 PATCH 4/7] net: store
> port/representator id in metadata_dst
> 
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> 
> Switches and modern SR-IOV enabled NICs may multiplex traffic from Port
> representators and control messages over single set of hardware queues.
> Control messages and muxed traffic may need ordered delivery.
> 
> Those requirements make it hard to comfortably use TC infrastructure today
> unless we have a way of attaching metadata to skbs at the upper device.
> Because single set of queues is used for many netdevs stopping TC/sched
> queues of all of them reliably is impossible and lower device has to retreat to
> returning NETDEV_TX_BUSY and usually has to take extra locks on the
> fastpath.
> 
> This patch attempts to enable port/representative devs to attach metadata
> to skbs which carry port id.  This way representatives can be queueless and
> all queuing can be performed at the lower netdev in the usual way.
> 
> Traffic arriving on the port/representative interfaces will be have metadata
> attached and will subsequently be queued to the lower device for
> transmission.
> The lower device should recognize the metadata and translate it to HW
> specific format which is most likely either a special header inserted before
> the network headers or descriptor/metadata fields.
> 
> Metadata is associated with the lower device by storing the netdev pointer
> along with port id so that if TC decides to redirect or mirror the new netdev
> will not try to interpret it.
> 
> This is mostly for SR-IOV devices since switches don't have lower netdevs
> today.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> ---
>  include/net/dst_metadata.h     | 41
> ++++++++++++++++++++++++++++++++---------
>  net/core/dst.c                 | 15 ++++++++++-----
>  net/core/filter.c              |  1 +
>  net/ipv4/ip_tunnel_core.c      |  6 ++++--
>  net/openvswitch/flow_netlink.c |  4 +++-
>  5 files changed, 50 insertions(+), 17 deletions(-)

Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Does not break i40e/i40evf

  reply	other threads:[~2017-01-30 21:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  0:54 [Intel-wired-lan] [next-queue v5 PATCH 0/7] i40e: Add VF Port Representator support for SR-IOV VFs Sridhar Samudrala
2017-01-26  0:54 ` [Intel-wired-lan] [next-queue v5 PATCH 1/7] i40e: Introduce devlink interface Sridhar Samudrala
2017-01-30 21:33   ` Bowers, AndrewX
2017-01-26  0:54 ` [Intel-wired-lan] [next-queue v5 PATCH 2/7] i40e: Introduce VF Port Representator(VFPR) netdevs Sridhar Samudrala
2017-01-30 21:33   ` Bowers, AndrewX
2017-02-01  1:06   ` Keller, Jacob E
2017-01-26  0:54 ` [Intel-wired-lan] [next-queue v5 PATCH 3/7] i40e: Sync link state between VFs and VFPRs Sridhar Samudrala
2017-01-30 21:34   ` Bowers, AndrewX
2017-01-26  0:54 ` [Intel-wired-lan] [next-queue v5 PATCH 4/7] net: store port/representator id in metadata_dst Sridhar Samudrala
2017-01-30 21:36   ` Bowers, AndrewX [this message]
2017-01-26  0:54 ` [Intel-wired-lan] [next-queue v5 PATCH 5/7] i40e: Add TX and RX support in switchdev mode Sridhar Samudrala
2017-01-30 21:34   ` Bowers, AndrewX
2017-02-15 15:59   ` Alexander Duyck
2017-02-15 17:37     ` Samudrala, Sridhar
2017-02-15 17:51       ` Alexander Duyck
2017-01-26  0:54 ` [Intel-wired-lan] [next-queue v5 PATCH 6/7] i40e: Add support for exposing VF port statistics via VFPR netdev on the host Sridhar Samudrala
2017-01-30 21:35   ` Bowers, AndrewX
2017-02-01  1:05   ` Keller, Jacob E
2017-02-01 18:21   ` Keller, Jacob E
2017-01-26  0:54 ` [Intel-wired-lan] [next-queue v5 PATCH 7/7] i40e: Add support to get switch id and port number for VFPR netdevs Sridhar Samudrala
2017-01-30 21:35   ` Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26D9FDECA4FBDD4AADA65D8E2FC68A4A0FA5D4F7@ORSMSX104.amr.corp.intel.com \
    --to=andrewx.bowers@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.