From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F25A2C004D4 for ; Thu, 19 Jan 2023 10:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbjASKDY (ORCPT ); Thu, 19 Jan 2023 05:03:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230305AbjASKCj (ORCPT ); Thu, 19 Jan 2023 05:02:39 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 897E46E80E for ; Thu, 19 Jan 2023 02:01:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674122495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MlfOpaZo8+JXQHQHhPM627Bpxxgi0KKq6Kx0UKuosSU=; b=JJbDXEZ623XHiXZ6HJpBMiUVhvbj9npN1Yc2odyViROi5HTLx3MmUijIJx8Qm4v6sBZtwB sTOOyOk9FpBZGdpPVY/rLQaOjpwLzSdI4aOcuUEe5AwGZxlmu+WR0m5W2ngv45mDFfGmGD qFHmZ7MHK1E/75LpxGgL0rj4idaMnNY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-t_bvYwokPH-AQe0Qgd0v9A-1; Thu, 19 Jan 2023 05:01:28 -0500 X-MC-Unique: t_bvYwokPH-AQe0Qgd0v9A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 293E1811E9C; Thu, 19 Jan 2023 10:01:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6DD12026D68; Thu, 19 Jan 2023 10:01:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <167391047703.2311931.8115712773222260073.stgit@warthog.procyon.org.uk> <167391048988.2311931.1567396746365286847.stgit@warthog.procyon.org.uk> To: Al Viro Cc: dhowells@redhat.com, Christoph Hellwig , Jens Axboe , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , Logan Gunthorpe , linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 01/34] vfs: Unconditionally set IOCB_WRITE in call_write_iter() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2724946.1674122486.1@warthog.procyon.org.uk> Date: Thu, 19 Jan 2023 10:01:26 +0000 Message-ID: <2724947.1674122486@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Al Viro wrote: > Which does nothing for places that do not use call_write_iter()... > __kernel_write_iter() is one such; for less obvious specimen see > drivers/nvme/target/io-cmd-file.c:nvmet_file_submit_bvec() Should these be calling call_read/write_iter()? If not, should call_read/write_iter() be dropped? David