All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: remove MIXED_BACKREF sysfs file
Date: Fri, 24 Jun 2022 19:46:12 +0800	[thread overview]
Message-ID: <27f72ec4-a365-20ba-03f1-8d603a66e011@gmx.com> (raw)
In-Reply-To: <3e01475c-8296-4cf1-14cd-5774d780b6e2@suse.com>



On 2022/6/24 19:32, Nikolay Borisov wrote:
>
>
> On 24.06.22 г. 11:13 ч., Qu Wenruo wrote:
>>
>> I don't think that's the correct way to go.
>>
>> In fact, I think sysfs should have everything, no matter how long
>> supported it is.
>
>
> I disagree, for things which are considered stand alone features - yes.
> Like free space tree 2, but for something like backrefs, heck I think
> we've even removed code which predates mixed backrefs so I'm not
> entirely use the filesystem can function with that feature turned off,
> actually it's not possible to create a non-mixedbackref file system
> since this behavior is hard-coded in btrfs-progs. Also the commit for
> the backrefs states:
>
>
> This commit introduces a new kind of back reference for btrfs metadata.
> Once a filesystem has been mounted with this commit, IT WILL NO LONGER
> BE MOUNTABLE BY OLDER KERNELS.
>

That means we're hiding incompat features from the user.

Even if it's not tunable and should always be enabled, we still need to
add that.

History can not be forgotten.

Thanks,
Qu

  reply	other threads:[~2022-06-24 11:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-24  8:01 [PATCH 0/2] Cleanup 2 sysfs flags Nikolay Borisov
2022-06-24  8:01 ` [PATCH 1/2] btrfs: remove MIXED_BACKREF sysfs file Nikolay Borisov
2022-06-24  8:13   ` Qu Wenruo
2022-06-24 11:32     ` Nikolay Borisov
2022-06-24 11:46       ` Qu Wenruo [this message]
2022-06-24 13:47         ` David Sterba
2022-06-24 14:02           ` Qu Wenruo
2022-06-24 15:44             ` David Sterba
2022-06-25  5:53               ` Qu Wenruo
2022-07-11 15:23                 ` David Sterba
2022-07-12  1:06                   ` Qu Wenruo
2022-06-24  8:01 ` [PATCH 2/2] btrfs: remove BIG_METADATA syfs file Nikolay Borisov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27f72ec4-a365-20ba-03f1-8d603a66e011@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.