All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Kucharski <william.kucharski@oracle.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	Linux-MM <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Oscar Salvador <OSalvador@suse.com>,
	Pavel Tatashin <pasha.tatashin@oracle.com>,
	David Hildenbrand <david@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page
Date: Tue, 20 Nov 2018 21:51:39 -0700	[thread overview]
Message-ID: <29F15A96-D6EB-450E-B54B-A4CB460ED9B3@oracle.com> (raw)
In-Reply-To: <20181120141207.GK22247@dhcp22.suse.cz>



> On Nov 20, 2018, at 7:12 AM, Michal Hocko <mhocko@kernel.org> wrote:
> 
> +		/*
> +		 * Check the locked pages before taking a reference to not
> +		 * go in the way of migration.
> +		 */

Could you make this a tiny bit more explanative, something like:

+		/*
+		 * Check for a locked page first, as a speculative
+		 * reference may adversely influence page migration.
+		 */

Reviewed-by: William Kucharski <william.kucharski@oracle.com>

  parent reply	other threads:[~2018-11-21  4:51 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-20 13:43 [RFC PATCH 0/3] few memory offlining enhancements Michal Hocko
2018-11-20 13:43 ` Michal Hocko
2018-11-20 13:43 ` [RFC PATCH 1/3] mm, memory_hotplug: try to migrate full section worth of pages Michal Hocko
2018-11-20 13:43   ` Michal Hocko
2018-11-20 14:18   ` David Hildenbrand
2018-11-20 14:25     ` Michal Hocko
2018-11-20 14:27       ` David Hildenbrand
2018-11-20 14:33   ` Pavel Tatashin
2018-11-20 14:51   ` osalvador
2018-11-20 15:00     ` Michal Hocko
2018-11-20 13:43 ` [RFC PATCH 2/3] mm, memory_hotplug: deobfuscate migration part of offlining Michal Hocko
2018-11-20 13:43   ` Michal Hocko
2018-11-20 14:26   ` David Hildenbrand
2018-11-20 14:34     ` Michal Hocko
2018-11-20 14:34       ` David Hildenbrand
2018-11-20 15:13   ` osalvador
2018-11-20 15:18     ` Michal Hocko
2018-11-20 13:43 ` [RFC PATCH 3/3] mm, fault_around: do not take a reference to a locked page Michal Hocko
2018-11-20 13:43   ` Michal Hocko
2018-11-20 14:07   ` Kirill A. Shutemov
2018-11-20 14:12     ` Michal Hocko
2018-11-20 14:17       ` Kirill A. Shutemov
2018-11-20 14:25         ` Michal Hocko
2018-11-21  4:51       ` William Kucharski [this message]
2018-11-21  7:07         ` Michal Hocko
2018-11-20 14:33   ` David Hildenbrand
2018-11-21  1:47   ` Hugh Dickins
2018-11-21  7:11     ` Michal Hocko
2018-11-22  2:27       ` Hugh Dickins
2018-11-22  9:05         ` Michal Hocko
2018-11-23 20:22           ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29F15A96-D6EB-450E-B54B-A4CB460ED9B3@oracle.com \
    --to=william.kucharski@oracle.com \
    --cc=OSalvador@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=pasha.tatashin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.