From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FCBC433DB for ; Sat, 26 Dec 2020 12:19:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 689D3221E2 for ; Sat, 26 Dec 2020 12:19:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 689D3221E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Subject:To:From:Date:MIME-Version: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=TF+OTC2fQB3sTIHoa2+w+bjqfvvEc8FX7QZBd5zzfQo=; b=yMqsaj6es1nT1mWuUw2N7miL1w oYup42U6iDSTiY0npFUb/ZI4gxPdGOipWBghc+75PEzrFWODeWPmSdq951/TluYZFj3mm3JwFEgRd RjPFwyflHYlzDfD51bAqhN3Z0v7xmqyM0NMQJ2VYNKAaW04vv4BfN9rgO1pvAgJbtor0zwguTIXOK A+nHmRpaTrnS6gPmBapFU0gG1bMuQ+6VnubWm0iEYDgsFiSb5mykrw67gj5Bs/c9D9NrC8t3xlkBS 6/ESXm2ID7/F5N0Rh9i32niB8Vt7N0pXVox2Kz52j5I4VVgypq8eAEnS97n4p5DNrdqqjKuRVOId9 ZU10W9wQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kt8Wb-0005GH-Hv; Sat, 26 Dec 2020 12:18:21 +0000 Received: from ssl.serverraum.org ([2a01:4f8:151:8464::1:2]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kt8WZ-0005ER-6w for linux-arm-kernel@lists.infradead.org; Sat, 26 Dec 2020 12:18:20 +0000 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 664AA22172; Sat, 26 Dec 2020 13:18:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1608985085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0jix7Sc97PeOl2rSq+rpJtQlSpWpT6y+8L3imhPM3Xs=; b=TkQ594VHVWZQyWXCyx3JvuW+sXuFS58lKYFjCoaVnMUthRyqwxnF4OC02EvN7JVwQi1Oic AjQu/L518U+gipX51TfutVzrRrayrUsD9sU7wTrKEtPMw3wKLJQCpSBaE8o3+34EKZGmJq 5D1AL0eokUyNoHCBPydx0qkrW+VobLw= MIME-Version: 1.0 Date: Sat, 26 Dec 2020 13:18:01 +0100 From: Michael Walle To: Russell King Subject: Broken ethernet on SolidRun cubox-i User-Agent: Roundcube Webmail/1.4.9 Message-ID: <2ae000163aa34b963dd387c824bdc3c9@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201226_071819_382975_F1291EF2 X-CRM114-Status: GOOD ( 11.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matus Ujhelyi , acmattheis@gmx.net, Christoph Mattheis , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, Ethernet is broken on 5.8+ kernel for "some" cubox-i boards. Some users reached out to me because they suspected my commit 0465d8f830dc ("net: phy: at803x: fix PHY ID masks") for the breakage. But it turned out not to be the case. Instead on faulty boards the PHY was always on PHY address 4: [ 4.008024] libphy: fec_enet_mii_bus: probed [ 4.008151] mdio_bus 2188000.ethernet-1: MDIO device at address 0 is missing. [ 4.010155] fec 2188000.ethernet eth0: registered PHC device 0 [..] [ 19.172510] fec 2188000.ethernet eth0: Unable to connect to phy # cat /sys/devices/soc0/soc/2100000.bus/2188000.ethernet/mdio_bus/2188000.ethernet-1/2188000.ethernet-1:04/phy_id 0x004dd072 Thus I suspect your commit 86b08bd5b994 ("ARM: dts: imx6-sr-som: add ethernet PHY configuration") to be the culprit ;) This will pin the PHY to address 0. I don't know how it was done before; like was there autoprobing if there is no "phy-handle" or did the bootloader fix that inplace. I don't have any cubox-i. Anyway, I'm not sure what boards have the PHY at address 4. If it is just per model and affects only the quad-core iMX.6 one or if it is worse and the exact same model has it on 0 or 4. [1] might imply the latter. If that is the case, SolidRun has added/removed a pull-down on LED_ACT sometime during the board revisions. I've looked at the vendor bootloader and it seems they scan the bus for the PHY [2]. [1] https://forum.armbian.com/topic/15418-upgrading-cubox-i-buster-from-kernel-57y-to-58y-breaks-ethernet/?do=findComment&comment=116114 [2] https://github.com/SolidRun/u-boot/blob/v2018.01-solidrun-a38x/board/solidrun/mx6cuboxi/mx6cuboxi.c#L160 -michael _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel