All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Bosch <stefan_b@posteo.net>
To: u-boot@lists.denx.de
Subject: [PATCH 01/13] arm: nanopi2: Remove unused code
Date: Mon, 8 Feb 2021 18:25:07 +0100	[thread overview]
Message-ID: <2bcaa0b9-2b28-c948-6fac-675123c8ea8f@posteo.net> (raw)
In-Reply-To: <20210204022415.20589-1-trini@konsulko.com>

Hi,

thanks for the info, I'll have a look at this.

Regards
Stefan

On 04.02.21 03:24, Tom Rini wrote:
> This platform did not ever enable CONFIG_REVISION_TAG, so the code to
> set the board_rev environment variable was never enabled.  This
> particular symbol is also only for use with the REVISION ATAG and this
> platform is new enough to have never supported an ATAG-based Linux
> Kernel.
> 
> Cc: Stefan Bosch <stefan_b@posteo.net>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> I'd be happy to see this patch replaced by one that enables what I think
> you meant to be doing and by default.  Thanks!
> ---
>   board/friendlyarm/nanopi2/board.c | 13 -------------
>   1 file changed, 13 deletions(-)
> 
> diff --git a/board/friendlyarm/nanopi2/board.c b/board/friendlyarm/nanopi2/board.c
> index 68980536abe9..6e546853b863 100644
> --- a/board/friendlyarm/nanopi2/board.c
> +++ b/board/friendlyarm/nanopi2/board.c
> @@ -294,16 +294,6 @@ static void set_ether_addr(void)
>   	env_set("ethaddr", ethaddr);
>   }
>   
> -#ifdef CONFIG_REVISION_TAG
> -static void set_board_rev(void)
> -{
> -	char info[64] = {0, };
> -
> -	snprintf(info, ARRAY_SIZE(info), "%02x", get_board_rev());
> -	env_set("board_rev", info);
> -}
> -#endif
> -
>   static void set_dtb_name(void)
>   {
>   	char info[64] = {0, };
> @@ -435,9 +425,6 @@ int board_late_init(void)
>   {
>   	bd_update_env();
>   
> -#ifdef CONFIG_REVISION_TAG
> -	set_board_rev();
> -#endif
>   	set_dtb_name();
>   
>   	set_ether_addr();
> 

  parent reply	other threads:[~2021-02-08 17:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  2:24 [PATCH 01/13] arm: nanopi2: Remove unused code Tom Rini
2021-02-04  2:24 ` [PATCH 02/13] arm: imx: Remove unused CONFIG_xxx_TAG support Tom Rini
2021-02-04  3:02   ` Fabio Estevam
2021-02-04  3:49     ` Tom Rini
2021-02-04  9:56       ` Fabio Estevam
2021-02-04 13:26         ` Tom Rini
2021-02-04 16:08           ` Tom Rini
2021-02-04 16:44             ` Tom Rini
2021-02-04 19:20               ` Fabio Estevam
2021-02-04 16:10           ` Fabio Estevam
2021-02-04 16:33             ` Tom Rini
2021-02-04  2:24 ` [PATCH 03/13] arm: layerscape: Disable ATAG support on some platforms Tom Rini
2021-02-04  2:24 ` [PATCH 04/13] bcmstb: Disable ATAGs support Tom Rini
2021-02-04  2:24 ` [PATCH 05/13] arm: puma_rk3399: " Tom Rini
2021-02-04  2:24 ` [PATCH 06/13] arm: goni: Disable CONFIG_REVISION_TAG Tom Rini
2021-02-14 22:33   ` Jaehoon Chung
2021-02-04  2:24 ` [PATCH 07/13] arm: aspeed: Disable ATAGs support Tom Rini
2021-02-09  6:55   ` ChiaWei Wang
2021-02-04  2:24 ` [PATCH 08/13] arm: mediatek: " Tom Rini
2021-02-04  2:24 ` [PATCH 09/13] arm: mvebu: Disable ATAGs support on some platforms Tom Rini
2021-02-04  8:44   ` Stefan Roese
2021-02-04  2:24 ` [PATCH 10/13] arm: rcar2/3: Disable ATAGs support Tom Rini
2021-02-04  2:24 ` [PATCH 11/13] arm: s32v234: " Tom Rini
2021-02-04  2:24 ` [PATCH 12/13] arm: socfpga: arria5_secu1: " Tom Rini
2021-02-04  7:56   ` Holger Brunck
2021-02-04  2:24 ` [PATCH 13/13] arm: stm32: " Tom Rini
2021-02-08 16:34   ` Patrick DELAUNAY
2021-02-10 17:51     ` Tom Rini
2021-02-08 17:25 ` Stefan Bosch [this message]
2021-04-10 17:14 ` [PATCH 01/13] arm: nanopi2: Remove unused code Stefan Bosch
2021-04-10 17:15   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bcaa0b9-2b28-c948-6fac-675123c8ea8f@posteo.net \
    --to=stefan_b@posteo.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.