RE: [PATCH v11 0/3] Add DRM FIMD DT support for Exynos4 DT Machines

[Kukjin Kim <kgene.kim@samsung.com>]

Vikas Sajjan wrote:
> 
> This patch series adds support for DRM FIMD DT for Exynos4 DT Machines,
> specifically for Exynos4412 SoC.
> 
> changes since v10:
> 	- addressed comments from Sylwester Nawrocki
> <sylvester.nawrocki@gmail.com>
> 
> changes since v9:
> 	- dropped the patch "ARM: dts: Add lcd pinctrl node entries for
> EXYNOS4412 SoC"
> 	as the gpios in the newly added nodes "lcd_en" and "lcd_sync" in
> this patch
> 	were already PULLed high by existing "lcd_clk" node.
> 	- addressed comments from Sylwester Nawrocki
> <sylvester.nawrocki@gmail.com>
> 	and Thomas Abraham <thomas.abraham@linaro.org>
> 
> changes since v8:
> 	- addressed comments to add missing documentation for clock and
> clock-names
> 	properties as pointed out by Sachin Kamat <sachin.kamat@linaro.org>
> 
> changes since v7:
> 	- rebased to kgene's "for-next"
> 	- Migrated to Common Clock Framework
> 	- removed the patch "ARM: dts: Add FIMD AUXDATA node entry for
> exynos4 DT",
> 	as migration to Common Clock Framework will NOT need this.
> 	- addressed the comments raised by Sachin Kamat
> <sachin.kamat@linaro.org>
> 
> changes since v6:
> 	- addressed comments and added interrupt-names = "fifo", "vsync",
> "lcd_sys"
> 	in exynos4.dtsi and re-ordered the interrupt numbering to match the
> order in
> 	interrupt combiner IP as suggested by Sylwester Nawrocki
> <sylvester.nawrocki@gmail.com>.
> 
> changes since v5:
> 	- renamed the fimd binding documentation file name as "samsung-
> fimd.txt",
> 	since it not only talks about exynos display controller but also
> about
> 	previous samsung display controllers.
> 	- rephrased an abmigious statement about the interrupt combiner in
> the
> 	fimd binding documentation as pointed out by
> 	Sachin Kamat <sachin.kamat@linaro.org>
> 
> changes since v4:
> 	- moved the fimd binding documentation to
> Documentation/devicetree/bindings/video/
> 	as suggested by Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> 
> 	- added more fimd compatiblity strings in fimd documentation as
> 	discussed at  https://patchwork.kernel.org/patch/2144861/ with
> 	Sylwester Nawrocki <sylvester.nawrocki@gmail.com> and
> 	Tomasz Figa <tomasz.figa@gmail.com>
> 
> 	- modified compatible string for exynos4 fimd as "exynos4210-fimd"
> 	exynos5 fimd as "exynos5250-fimd" to stick to the rule that
> compatible
> 	value should be named after first specific SoC model in which this
> 	particular IP version was included as discussed at
> 	https://patchwork.kernel.org/patch/2144861/
> 
> 	- documented more about the interrupt combiner and their order as
> 	suggested by Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
> 
> changes since v3:
> 	- rebased on
> 	http://git.kernel.org/?p=linux/kernel/git/kgene/linux-
> samsung.git;a=shortlog;h=refs/heads/for-next-next
> 
> changes since v2:
> 	- added alias to 'fimd@11c00000' node
> 		(reported by: Rahul Sharma <r.sh.open@gmail.com>)
> 	- removed 'lcd0_data' node as there was already a similar node
> lcd_data24
> 		(reported by: Jingoo Han <jg1.han@samsung.com>
> 	- replaced spaces with tabs in display-timing node
> 
> changes since v1:
> 	- added new patch to add FIMD DT binding Documentation
> 	- removed patch enabling SAMSUNG_DEV_BACKLIGHT and SAMSUNG_DEV_PMW
> 	for mach-exynos4 DT
> 	- added 'status' property to fimd DT node
> 
> Is based on branch kgene's "for-next"
> https://git.kernel.org/cgit/linux/kernel/git/kgene/linux-
> samsung.git/log/?h=for-next
> 
> Vikas Sajjan (3):
>   ARM: dts: Add FIMD node to exynos4
>   ARM: dts: Add FIMD node and display timing node to
>     exynos4412-origen.dts
>   ARM: dts: Add FIMD DT binding Documentation
> 
>  .../devicetree/bindings/video/samsung-fimd.txt     |   65
> ++++++++++++++++++++
>  arch/arm/boot/dts/exynos4.dtsi                     |   12 ++++
>  arch/arm/boot/dts/exynos4412-origen.dts            |   21 +++++++
>  3 files changed, 98 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/video/samsung-
> fimd.txt
> 
> --
> 1.7.9.5

Looks good to me, applied.

Thanks.

- Kukjin