From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B729AC63777 for ; Tue, 24 Nov 2020 08:45:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 541B62076E for ; Tue, 24 Nov 2020 08:45:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="j1emCflw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730829AbgKXIpE (ORCPT ); Tue, 24 Nov 2020 03:45:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:57320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730743AbgKXIpD (ORCPT ); Tue, 24 Nov 2020 03:45:03 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41E362073C; Tue, 24 Nov 2020 08:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606207502; bh=xCFPFws3rl+rLs/hXsg30ZbSaEzwkNeXgxTpyEHJHGQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j1emCflw6I0voluiwaNY3BYc4EZplrGs1OCSYe2Yqa0SJJtsdXs0hai6AgbirClTe qG89f8UrVqAbfxF11nmuYpnxOTumpsxfG9wd/q1u/ycmgucSruD9YK4nlqp+cu0dGw y9/MzlWVYFZePeBDuT6oqJLyp0qBCJrXKeZgDPSs= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1khTwZ-00DBsM-Tw; Tue, 24 Nov 2020 08:45:00 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 24 Nov 2020 08:44:59 +0000 From: Marc Zyngier To: Shenming Lu Cc: James Morse , Julien Thierry , Suzuki K Poulose , Eric Auger , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Christoffer Dall , Alex Williamson , Kirti Wankhede , Cornelia Huck , Neo Jia , wanghaibin.wang@huawei.com, yuzenghui@huawei.com Subject: Re: [RFC PATCH v1 3/4] KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side In-Reply-To: References: <20201123065410.1915-1-lushenming@huawei.com> <20201123065410.1915-4-lushenming@huawei.com> <5c724bb83730cdd5dcf7add9a812fa92@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <2d2bcae4f871d239a1af50362f5c11a4@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@arm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, cohuck@redhat.com, cjia@nvidia.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-11-24 08:10, Shenming Lu wrote: > On 2020/11/23 17:27, Marc Zyngier wrote: >> On 2020-11-23 06:54, Shenming Lu wrote: >>> From: Zenghui Yu >>> >>> When setting the forwarding path of a VLPI, it is more consistent to >> >> I'm not sure it is more consistent. It is a *new* behaviour, because >> it only >> matters for migration, which has been so far unsupported. > > Alright, consistent may not be accurate... > But I have doubt that whether there is really no need to transfer the > pending states > from kvm'vgic to VPT in set_forwarding regardless of migration, and the > similar > for unset_forwarding. If you have to transfer that state outside of the a save/restore, it means that you have missed the programming of the PCI endpoint. This is an established restriction that the MSI programming must occur *after* the translation has been established using MAPI/MAPTI (see the large comment at the beginning of vgic-v4.c). If you want to revisit this, fair enough. But you will need a lot more than just opportunistically transfer the pending state. > >> >>> also transfer the pending state from irq->pending_latch to VPT >>> (especially >>> in migration, the pending states of VLPIs are restored into kvm’s >>> vgic >>> first). And we currently send "INT+VSYNC" to trigger a VLPI to >>> pending. >>> >>> Signed-off-by: Zenghui Yu >>> Signed-off-by: Shenming Lu >>> --- >>>  arch/arm64/kvm/vgic/vgic-v4.c | 12 ++++++++++++ >>>  1 file changed, 12 insertions(+) >>> >>> diff --git a/arch/arm64/kvm/vgic/vgic-v4.c >>> b/arch/arm64/kvm/vgic/vgic-v4.c >>> index b5fa73c9fd35..cc3ab9cea182 100644 >>> --- a/arch/arm64/kvm/vgic/vgic-v4.c >>> +++ b/arch/arm64/kvm/vgic/vgic-v4.c >>> @@ -418,6 +418,18 @@ int kvm_vgic_v4_set_forwarding(struct kvm *kvm, >>> int virq, >>>      irq->host_irq    = virq; >>>      atomic_inc(&map.vpe->vlpi_count); >>> >>> +    /* Transfer pending state */ >>> +    ret = irq_set_irqchip_state(irq->host_irq, >>> +                    IRQCHIP_STATE_PENDING, >>> +                    irq->pending_latch); >>> +    WARN_RATELIMIT(ret, "IRQ %d", irq->host_irq); >>> + >>> +    /* >>> +     * Let it be pruned from ap_list later and don't bother >>> +     * the List Register. >>> +     */ >>> +    irq->pending_latch = false; >> >> It occurs to me that calling into irq_set_irqchip_state() for a large >> number of interrupts can take a significant amount of time. It is also >> odd that you dump the VPT with the VPE unmapped, but rely on the VPE >> being mapped for the opposite operation. >> >> Shouldn't these be symmetric, all performed while the VPE is unmapped? >> It would also save a lot of ITS traffic. >> > > My thought was to use the existing interface directly without > unmapping... > > If you want to unmap the vPE and poke the VPT here, as I said in the > cover > letter, set/unset_forwarding might also be called when all devices are > running > at normal run time, in which case the unmapping of the vPE is not > allowed... No, I'm suggesting that you don't do anything here, but instead as a by-product of restoring the ITS tables. What goes wrong if you use the KVM_DEV_ARM_ITS_RESTORE_TABLE backend instead? > Another possible solution is to add a new dedicated interface to QEMU > to transfer > these pending states to HW in GIC VM state change handler corresponding > to > save_pending_tables? Userspace has no way to know we use GICv4, and I intend to keep it completely out of the loop. The API is already pretty tortuous, and I really don't want to add any extra complexity to it. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99AFBC56201 for ; Tue, 24 Nov 2020 08:45:08 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id D0A5D2075A for ; Tue, 24 Nov 2020 08:45:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="j1emCflw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0A5D2075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4F8E24BCE8; Tue, 24 Nov 2020 03:45:07 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jAom1g7H7IgR; Tue, 24 Nov 2020 03:45:06 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0F52A4BD4A; Tue, 24 Nov 2020 03:45:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id CA6654BD1D for ; Tue, 24 Nov 2020 03:45:04 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UtlpZ0ZBvCBQ for ; Tue, 24 Nov 2020 03:45:03 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 915B14BCE8 for ; Tue, 24 Nov 2020 03:45:03 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41E362073C; Tue, 24 Nov 2020 08:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606207502; bh=xCFPFws3rl+rLs/hXsg30ZbSaEzwkNeXgxTpyEHJHGQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j1emCflw6I0voluiwaNY3BYc4EZplrGs1OCSYe2Yqa0SJJtsdXs0hai6AgbirClTe qG89f8UrVqAbfxF11nmuYpnxOTumpsxfG9wd/q1u/ycmgucSruD9YK4nlqp+cu0dGw y9/MzlWVYFZePeBDuT6oqJLyp0qBCJrXKeZgDPSs= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1khTwZ-00DBsM-Tw; Tue, 24 Nov 2020 08:45:00 +0000 MIME-Version: 1.0 Date: Tue, 24 Nov 2020 08:44:59 +0000 From: Marc Zyngier To: Shenming Lu Subject: Re: [RFC PATCH v1 3/4] KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side In-Reply-To: References: <20201123065410.1915-1-lushenming@huawei.com> <20201123065410.1915-4-lushenming@huawei.com> <5c724bb83730cdd5dcf7add9a812fa92@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <2d2bcae4f871d239a1af50362f5c11a4@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@arm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, cohuck@redhat.com, cjia@nvidia.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Neo Jia , kvm@vger.kernel.org, Cornelia Huck , linux-kernel@vger.kernel.org, Kirti Wankhede , Alex Williamson , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu T24gMjAyMC0xMS0yNCAwODoxMCwgU2hlbm1pbmcgTHUgd3JvdGU6Cj4gT24gMjAyMC8xMS8yMyAx NzoyNywgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBPbiAyMDIwLTExLTIzIDA2OjU0LCBTaGVubWlu ZyBMdSB3cm90ZToKPj4+IEZyb206IFplbmdodWkgWXUgPHl1emVuZ2h1aUBodWF3ZWkuY29tPgo+ Pj4gCj4+PiBXaGVuIHNldHRpbmcgdGhlIGZvcndhcmRpbmcgcGF0aCBvZiBhIFZMUEksIGl0IGlz IG1vcmUgY29uc2lzdGVudCB0bwo+PiAKPj4gSSdtIG5vdCBzdXJlIGl0IGlzIG1vcmUgY29uc2lz dGVudC4gSXQgaXMgYSAqbmV3KiBiZWhhdmlvdXIsIGJlY2F1c2UgCj4+IGl0IG9ubHkKPj4gbWF0 dGVycyBmb3IgbWlncmF0aW9uLCB3aGljaCBoYXMgYmVlbiBzbyBmYXIgdW5zdXBwb3J0ZWQuCj4g Cj4gQWxyaWdodCwgY29uc2lzdGVudCBtYXkgbm90IGJlIGFjY3VyYXRlLi4uCj4gQnV0IEkgaGF2 ZSBkb3VidCB0aGF0IHdoZXRoZXIgdGhlcmUgaXMgcmVhbGx5IG5vIG5lZWQgdG8gdHJhbnNmZXIg dGhlCj4gcGVuZGluZyBzdGF0ZXMKPiBmcm9tIGt2bSd2Z2ljIHRvIFZQVCBpbiBzZXRfZm9yd2Fy ZGluZyByZWdhcmRsZXNzIG9mIG1pZ3JhdGlvbiwgYW5kIHRoZSAKPiBzaW1pbGFyCj4gZm9yIHVu c2V0X2ZvcndhcmRpbmcuCgpJZiB5b3UgaGF2ZSB0byB0cmFuc2ZlciB0aGF0IHN0YXRlIG91dHNp ZGUgb2YgdGhlIGEgc2F2ZS9yZXN0b3JlLCBpdCAKbWVhbnMgdGhhdAp5b3UgaGF2ZSBtaXNzZWQg dGhlIHByb2dyYW1taW5nIG9mIHRoZSBQQ0kgZW5kcG9pbnQuIFRoaXMgaXMgYW4gCmVzdGFibGlz aGVkCnJlc3RyaWN0aW9uIHRoYXQgdGhlIE1TSSBwcm9ncmFtbWluZyBtdXN0IG9jY3VyICphZnRl ciogdGhlIHRyYW5zbGF0aW9uIApoYXMKYmVlbiBlc3RhYmxpc2hlZCB1c2luZyBNQVBJL01BUFRJ IChzZWUgdGhlIGxhcmdlIGNvbW1lbnQgYXQgdGhlIApiZWdpbm5pbmcgb2YKdmdpYy12NC5jKS4K CklmIHlvdSB3YW50IHRvIHJldmlzaXQgdGhpcywgZmFpciBlbm91Z2guIEJ1dCB5b3Ugd2lsbCBu ZWVkIGEgbG90IG1vcmUgCnRoYW4KanVzdCBvcHBvcnR1bmlzdGljYWxseSB0cmFuc2ZlciB0aGUg cGVuZGluZyBzdGF0ZS4KCj4gCj4+IAo+Pj4gYWxzbyB0cmFuc2ZlciB0aGUgcGVuZGluZyBzdGF0 ZSBmcm9tIGlycS0+cGVuZGluZ19sYXRjaCB0byBWUFQgCj4+PiAoZXNwZWNpYWxseQo+Pj4gaW4g bWlncmF0aW9uLCB0aGUgcGVuZGluZyBzdGF0ZXMgb2YgVkxQSXMgYXJlIHJlc3RvcmVkIGludG8g a3Zt4oCZcyAKPj4+IHZnaWMKPj4+IGZpcnN0KS4gQW5kIHdlIGN1cnJlbnRseSBzZW5kICJJTlQr VlNZTkMiIHRvIHRyaWdnZXIgYSBWTFBJIHRvIAo+Pj4gcGVuZGluZy4KPj4+IAo+Pj4gU2lnbmVk LW9mZi1ieTogWmVuZ2h1aSBZdSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+Cj4+PiBTaWduZWQtb2Zm LWJ5OiBTaGVubWluZyBMdSA8bHVzaGVubWluZ0BodWF3ZWkuY29tPgo+Pj4gLS0tCj4+PiDCoGFy Y2gvYXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jIHwgMTIgKysrKysrKysrKysrCj4+PiDCoDEgZmls ZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspCj4+PiAKPj4+IGRpZmYgLS1naXQgYS9hcmNoL2Fy bTY0L2t2bS92Z2ljL3ZnaWMtdjQuYyAKPj4+IGIvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLXY0 LmMKPj4+IGluZGV4IGI1ZmE3M2M5ZmQzNS4uY2MzYWI5Y2VhMTgyIDEwMDY0NAo+Pj4gLS0tIGEv YXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLXY0LmMKPj4+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL3Zn aWMvdmdpYy12NC5jCj4+PiBAQCAtNDE4LDYgKzQxOCwxOCBAQCBpbnQga3ZtX3ZnaWNfdjRfc2V0 X2ZvcndhcmRpbmcoc3RydWN0IGt2bSAqa3ZtLCAKPj4+IGludCB2aXJxLAo+Pj4gwqDCoMKgwqAg aXJxLT5ob3N0X2lyccKgwqDCoCA9IHZpcnE7Cj4+PiDCoMKgwqDCoCBhdG9taWNfaW5jKCZtYXAu dnBlLT52bHBpX2NvdW50KTsKPj4+IAo+Pj4gK8KgwqDCoCAvKiBUcmFuc2ZlciBwZW5kaW5nIHN0 YXRlICovCj4+PiArwqDCoMKgIHJldCA9IGlycV9zZXRfaXJxY2hpcF9zdGF0ZShpcnEtPmhvc3Rf aXJxLAo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIElSUUNISVBf U1RBVEVfUEVORElORywKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBpcnEtPnBlbmRpbmdfbGF0Y2gpOwo+Pj4gK8KgwqDCoCBXQVJOX1JBVEVMSU1JVChyZXQsICJJ UlEgJWQiLCBpcnEtPmhvc3RfaXJxKTsKPj4+ICsKPj4+ICvCoMKgwqAgLyoKPj4+ICvCoMKgwqDC oCAqIExldCBpdCBiZSBwcnVuZWQgZnJvbSBhcF9saXN0IGxhdGVyIGFuZCBkb24ndCBib3RoZXIK Pj4+ICvCoMKgwqDCoCAqIHRoZSBMaXN0IFJlZ2lzdGVyLgo+Pj4gK8KgwqDCoMKgICovCj4+PiAr wqDCoMKgIGlycS0+cGVuZGluZ19sYXRjaCA9IGZhbHNlOwo+PiAKPj4gSXQgb2NjdXJzIHRvIG1l IHRoYXQgY2FsbGluZyBpbnRvIGlycV9zZXRfaXJxY2hpcF9zdGF0ZSgpIGZvciBhIGxhcmdlCj4+ IG51bWJlciBvZiBpbnRlcnJ1cHRzIGNhbiB0YWtlIGEgc2lnbmlmaWNhbnQgYW1vdW50IG9mIHRp bWUuIEl0IGlzIGFsc28KPj4gb2RkIHRoYXQgeW91IGR1bXAgdGhlIFZQVCB3aXRoIHRoZSBWUEUg dW5tYXBwZWQsIGJ1dCByZWx5IG9uIHRoZSBWUEUKPj4gYmVpbmcgbWFwcGVkIGZvciB0aGUgb3Bw b3NpdGUgb3BlcmF0aW9uLgo+PiAKPj4gU2hvdWxkbid0IHRoZXNlIGJlIHN5bW1ldHJpYywgYWxs IHBlcmZvcm1lZCB3aGlsZSB0aGUgVlBFIGlzIHVubWFwcGVkPwo+PiBJdCB3b3VsZCBhbHNvIHNh dmUgYSBsb3Qgb2YgSVRTIHRyYWZmaWMuCj4+IAo+IAo+IE15IHRob3VnaHQgd2FzIHRvIHVzZSB0 aGUgZXhpc3RpbmcgaW50ZXJmYWNlIGRpcmVjdGx5IHdpdGhvdXQgCj4gdW5tYXBwaW5nLi4uCj4g Cj4gSWYgeW91IHdhbnQgdG8gdW5tYXAgdGhlIHZQRSBhbmQgcG9rZSB0aGUgVlBUIGhlcmUsIGFz IEkgc2FpZCBpbiB0aGUgCj4gY292ZXIKPiBsZXR0ZXIsIHNldC91bnNldF9mb3J3YXJkaW5nIG1p Z2h0IGFsc28gYmUgY2FsbGVkIHdoZW4gYWxsIGRldmljZXMgYXJlIAo+IHJ1bm5pbmcKPiBhdCBu b3JtYWwgcnVuIHRpbWUsIGluIHdoaWNoIGNhc2UgdGhlIHVubWFwcGluZyBvZiB0aGUgdlBFIGlz IG5vdCAKPiBhbGxvd2VkLi4uCgpObywgSSdtIHN1Z2dlc3RpbmcgdGhhdCB5b3UgZG9uJ3QgZG8g YW55dGhpbmcgaGVyZSwgYnV0IGluc3RlYWQgYXMgYSAKYnktcHJvZHVjdApvZiByZXN0b3Jpbmcg dGhlIElUUyB0YWJsZXMuIFdoYXQgZ29lcyB3cm9uZyBpZiB5b3UgdXNlIHRoZQpLVk1fREVWX0FS TV9JVFNfUkVTVE9SRV9UQUJMRSBiYWNrZW5kIGluc3RlYWQ/Cgo+IEFub3RoZXIgcG9zc2libGUg c29sdXRpb24gaXMgdG8gYWRkIGEgbmV3IGRlZGljYXRlZCBpbnRlcmZhY2UgdG8gUUVNVQo+IHRv IHRyYW5zZmVyCj4gdGhlc2UgcGVuZGluZyBzdGF0ZXMgdG8gSFcgaW4gR0lDIFZNIHN0YXRlIGNo YW5nZSBoYW5kbGVyIGNvcnJlc3BvbmRpbmcgCj4gdG8KPiBzYXZlX3BlbmRpbmdfdGFibGVzPwoK VXNlcnNwYWNlIGhhcyBubyB3YXkgdG8ga25vdyB3ZSB1c2UgR0lDdjQsIGFuZCBJIGludGVuZCB0 byBrZWVwIGl0CmNvbXBsZXRlbHkgb3V0IG9mIHRoZSBsb29wLiBUaGUgQVBJIGlzIGFscmVhZHkg cHJldHR5IHRvcnR1b3VzLCBhbmQKSSByZWFsbHkgZG9uJ3Qgd2FudCB0byBhZGQgYW55IGV4dHJh IGNvbXBsZXhpdHkgdG8gaXQuCgpUaGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3Qg ZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1AbGlzdHMuY3Mu Y29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxtYW4vbGlzdGlu Zm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5157AC2D0E4 for ; Tue, 24 Nov 2020 08:45:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE7262073C for ; Tue, 24 Nov 2020 08:45:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JUbixTfQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="j1emCflw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE7262073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jz+pIDeh8oiQzJdu7TE48b0hbAwpYlQUc9Bf4Tnce7Q=; b=JUbixTfQDr6Rl7WX64IYPQ9i7 nZZX+KUygohyBk5sqHys+InXdL6lbUnV/kyWB79hCcbIwPI84kI/Zxqk/MZafgcA4PuUHGmaV3EyM WhRIub9bpLIYnp5NPxVNikbFH+F3ooqnX2DmcP3ylCahhsmgeJzsq0haiie4CEMwMHHKEBu99/sRh LwkSQrCPxHSn4KKQD6P1X9K0lfJv9d4MeDXT5ysv2gyKF7EdijDsO9Ix09O1SQW8m19majtCNH7bw V3Dncz6UDhTX0EHNOm88hN3QdHzkC/BTwR5yfSJT7ANuZ9/lh2ooN9ZtugWSnFugPVEWRETk++QfR PkrT3C20A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khTwg-0005uK-V8; Tue, 24 Nov 2020 08:45:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khTwd-0005tK-Ch for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 08:45:04 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41E362073C; Tue, 24 Nov 2020 08:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606207502; bh=xCFPFws3rl+rLs/hXsg30ZbSaEzwkNeXgxTpyEHJHGQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j1emCflw6I0voluiwaNY3BYc4EZplrGs1OCSYe2Yqa0SJJtsdXs0hai6AgbirClTe qG89f8UrVqAbfxF11nmuYpnxOTumpsxfG9wd/q1u/ycmgucSruD9YK4nlqp+cu0dGw y9/MzlWVYFZePeBDuT6oqJLyp0qBCJrXKeZgDPSs= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1khTwZ-00DBsM-Tw; Tue, 24 Nov 2020 08:45:00 +0000 MIME-Version: 1.0 Date: Tue, 24 Nov 2020 08:44:59 +0000 From: Marc Zyngier To: Shenming Lu Subject: Re: [RFC PATCH v1 3/4] KVM: arm64: GICv4.1: Restore VLPI's pending state to physical side In-Reply-To: References: <20201123065410.1915-1-lushenming@huawei.com> <20201123065410.1915-4-lushenming@huawei.com> <5c724bb83730cdd5dcf7add9a812fa92@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <2d2bcae4f871d239a1af50362f5c11a4@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: lushenming@huawei.com, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@arm.com, alex.williamson@redhat.com, kwankhede@nvidia.com, cohuck@redhat.com, cjia@nvidia.com, wanghaibin.wang@huawei.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_034503_666178_7EDF7C0A X-CRM114-Status: GOOD ( 24.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neo Jia , kvm@vger.kernel.org, Suzuki K Poulose , Cornelia Huck , linux-kernel@vger.kernel.org, Kirti Wankhede , Christoffer Dall , Eric Auger , Alex Williamson , James Morse , Julien Thierry , yuzenghui@huawei.com, wanghaibin.wang@huawei.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMC0xMS0yNCAwODoxMCwgU2hlbm1pbmcgTHUgd3JvdGU6Cj4gT24gMjAyMC8xMS8yMyAx NzoyNywgTWFyYyBaeW5naWVyIHdyb3RlOgo+PiBPbiAyMDIwLTExLTIzIDA2OjU0LCBTaGVubWlu ZyBMdSB3cm90ZToKPj4+IEZyb206IFplbmdodWkgWXUgPHl1emVuZ2h1aUBodWF3ZWkuY29tPgo+ Pj4gCj4+PiBXaGVuIHNldHRpbmcgdGhlIGZvcndhcmRpbmcgcGF0aCBvZiBhIFZMUEksIGl0IGlz IG1vcmUgY29uc2lzdGVudCB0bwo+PiAKPj4gSSdtIG5vdCBzdXJlIGl0IGlzIG1vcmUgY29uc2lz dGVudC4gSXQgaXMgYSAqbmV3KiBiZWhhdmlvdXIsIGJlY2F1c2UgCj4+IGl0IG9ubHkKPj4gbWF0 dGVycyBmb3IgbWlncmF0aW9uLCB3aGljaCBoYXMgYmVlbiBzbyBmYXIgdW5zdXBwb3J0ZWQuCj4g Cj4gQWxyaWdodCwgY29uc2lzdGVudCBtYXkgbm90IGJlIGFjY3VyYXRlLi4uCj4gQnV0IEkgaGF2 ZSBkb3VidCB0aGF0IHdoZXRoZXIgdGhlcmUgaXMgcmVhbGx5IG5vIG5lZWQgdG8gdHJhbnNmZXIg dGhlCj4gcGVuZGluZyBzdGF0ZXMKPiBmcm9tIGt2bSd2Z2ljIHRvIFZQVCBpbiBzZXRfZm9yd2Fy ZGluZyByZWdhcmRsZXNzIG9mIG1pZ3JhdGlvbiwgYW5kIHRoZSAKPiBzaW1pbGFyCj4gZm9yIHVu c2V0X2ZvcndhcmRpbmcuCgpJZiB5b3UgaGF2ZSB0byB0cmFuc2ZlciB0aGF0IHN0YXRlIG91dHNp ZGUgb2YgdGhlIGEgc2F2ZS9yZXN0b3JlLCBpdCAKbWVhbnMgdGhhdAp5b3UgaGF2ZSBtaXNzZWQg dGhlIHByb2dyYW1taW5nIG9mIHRoZSBQQ0kgZW5kcG9pbnQuIFRoaXMgaXMgYW4gCmVzdGFibGlz aGVkCnJlc3RyaWN0aW9uIHRoYXQgdGhlIE1TSSBwcm9ncmFtbWluZyBtdXN0IG9jY3VyICphZnRl ciogdGhlIHRyYW5zbGF0aW9uIApoYXMKYmVlbiBlc3RhYmxpc2hlZCB1c2luZyBNQVBJL01BUFRJ IChzZWUgdGhlIGxhcmdlIGNvbW1lbnQgYXQgdGhlIApiZWdpbm5pbmcgb2YKdmdpYy12NC5jKS4K CklmIHlvdSB3YW50IHRvIHJldmlzaXQgdGhpcywgZmFpciBlbm91Z2guIEJ1dCB5b3Ugd2lsbCBu ZWVkIGEgbG90IG1vcmUgCnRoYW4KanVzdCBvcHBvcnR1bmlzdGljYWxseSB0cmFuc2ZlciB0aGUg cGVuZGluZyBzdGF0ZS4KCj4gCj4+IAo+Pj4gYWxzbyB0cmFuc2ZlciB0aGUgcGVuZGluZyBzdGF0 ZSBmcm9tIGlycS0+cGVuZGluZ19sYXRjaCB0byBWUFQgCj4+PiAoZXNwZWNpYWxseQo+Pj4gaW4g bWlncmF0aW9uLCB0aGUgcGVuZGluZyBzdGF0ZXMgb2YgVkxQSXMgYXJlIHJlc3RvcmVkIGludG8g a3Zt4oCZcyAKPj4+IHZnaWMKPj4+IGZpcnN0KS4gQW5kIHdlIGN1cnJlbnRseSBzZW5kICJJTlQr VlNZTkMiIHRvIHRyaWdnZXIgYSBWTFBJIHRvIAo+Pj4gcGVuZGluZy4KPj4+IAo+Pj4gU2lnbmVk LW9mZi1ieTogWmVuZ2h1aSBZdSA8eXV6ZW5naHVpQGh1YXdlaS5jb20+Cj4+PiBTaWduZWQtb2Zm LWJ5OiBTaGVubWluZyBMdSA8bHVzaGVubWluZ0BodWF3ZWkuY29tPgo+Pj4gLS0tCj4+PiDCoGFy Y2gvYXJtNjQva3ZtL3ZnaWMvdmdpYy12NC5jIHwgMTIgKysrKysrKysrKysrCj4+PiDCoDEgZmls ZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspCj4+PiAKPj4+IGRpZmYgLS1naXQgYS9hcmNoL2Fy bTY0L2t2bS92Z2ljL3ZnaWMtdjQuYyAKPj4+IGIvYXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLXY0 LmMKPj4+IGluZGV4IGI1ZmE3M2M5ZmQzNS4uY2MzYWI5Y2VhMTgyIDEwMDY0NAo+Pj4gLS0tIGEv YXJjaC9hcm02NC9rdm0vdmdpYy92Z2ljLXY0LmMKPj4+ICsrKyBiL2FyY2gvYXJtNjQva3ZtL3Zn aWMvdmdpYy12NC5jCj4+PiBAQCAtNDE4LDYgKzQxOCwxOCBAQCBpbnQga3ZtX3ZnaWNfdjRfc2V0 X2ZvcndhcmRpbmcoc3RydWN0IGt2bSAqa3ZtLCAKPj4+IGludCB2aXJxLAo+Pj4gwqDCoMKgwqAg aXJxLT5ob3N0X2lyccKgwqDCoCA9IHZpcnE7Cj4+PiDCoMKgwqDCoCBhdG9taWNfaW5jKCZtYXAu dnBlLT52bHBpX2NvdW50KTsKPj4+IAo+Pj4gK8KgwqDCoCAvKiBUcmFuc2ZlciBwZW5kaW5nIHN0 YXRlICovCj4+PiArwqDCoMKgIHJldCA9IGlycV9zZXRfaXJxY2hpcF9zdGF0ZShpcnEtPmhvc3Rf aXJxLAo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIElSUUNISVBf U1RBVEVfUEVORElORywKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBpcnEtPnBlbmRpbmdfbGF0Y2gpOwo+Pj4gK8KgwqDCoCBXQVJOX1JBVEVMSU1JVChyZXQsICJJ UlEgJWQiLCBpcnEtPmhvc3RfaXJxKTsKPj4+ICsKPj4+ICvCoMKgwqAgLyoKPj4+ICvCoMKgwqDC oCAqIExldCBpdCBiZSBwcnVuZWQgZnJvbSBhcF9saXN0IGxhdGVyIGFuZCBkb24ndCBib3RoZXIK Pj4+ICvCoMKgwqDCoCAqIHRoZSBMaXN0IFJlZ2lzdGVyLgo+Pj4gK8KgwqDCoMKgICovCj4+PiAr wqDCoMKgIGlycS0+cGVuZGluZ19sYXRjaCA9IGZhbHNlOwo+PiAKPj4gSXQgb2NjdXJzIHRvIG1l IHRoYXQgY2FsbGluZyBpbnRvIGlycV9zZXRfaXJxY2hpcF9zdGF0ZSgpIGZvciBhIGxhcmdlCj4+ IG51bWJlciBvZiBpbnRlcnJ1cHRzIGNhbiB0YWtlIGEgc2lnbmlmaWNhbnQgYW1vdW50IG9mIHRp bWUuIEl0IGlzIGFsc28KPj4gb2RkIHRoYXQgeW91IGR1bXAgdGhlIFZQVCB3aXRoIHRoZSBWUEUg dW5tYXBwZWQsIGJ1dCByZWx5IG9uIHRoZSBWUEUKPj4gYmVpbmcgbWFwcGVkIGZvciB0aGUgb3Bw b3NpdGUgb3BlcmF0aW9uLgo+PiAKPj4gU2hvdWxkbid0IHRoZXNlIGJlIHN5bW1ldHJpYywgYWxs IHBlcmZvcm1lZCB3aGlsZSB0aGUgVlBFIGlzIHVubWFwcGVkPwo+PiBJdCB3b3VsZCBhbHNvIHNh dmUgYSBsb3Qgb2YgSVRTIHRyYWZmaWMuCj4+IAo+IAo+IE15IHRob3VnaHQgd2FzIHRvIHVzZSB0 aGUgZXhpc3RpbmcgaW50ZXJmYWNlIGRpcmVjdGx5IHdpdGhvdXQgCj4gdW5tYXBwaW5nLi4uCj4g Cj4gSWYgeW91IHdhbnQgdG8gdW5tYXAgdGhlIHZQRSBhbmQgcG9rZSB0aGUgVlBUIGhlcmUsIGFz IEkgc2FpZCBpbiB0aGUgCj4gY292ZXIKPiBsZXR0ZXIsIHNldC91bnNldF9mb3J3YXJkaW5nIG1p Z2h0IGFsc28gYmUgY2FsbGVkIHdoZW4gYWxsIGRldmljZXMgYXJlIAo+IHJ1bm5pbmcKPiBhdCBu b3JtYWwgcnVuIHRpbWUsIGluIHdoaWNoIGNhc2UgdGhlIHVubWFwcGluZyBvZiB0aGUgdlBFIGlz IG5vdCAKPiBhbGxvd2VkLi4uCgpObywgSSdtIHN1Z2dlc3RpbmcgdGhhdCB5b3UgZG9uJ3QgZG8g YW55dGhpbmcgaGVyZSwgYnV0IGluc3RlYWQgYXMgYSAKYnktcHJvZHVjdApvZiByZXN0b3Jpbmcg dGhlIElUUyB0YWJsZXMuIFdoYXQgZ29lcyB3cm9uZyBpZiB5b3UgdXNlIHRoZQpLVk1fREVWX0FS TV9JVFNfUkVTVE9SRV9UQUJMRSBiYWNrZW5kIGluc3RlYWQ/Cgo+IEFub3RoZXIgcG9zc2libGUg c29sdXRpb24gaXMgdG8gYWRkIGEgbmV3IGRlZGljYXRlZCBpbnRlcmZhY2UgdG8gUUVNVQo+IHRv IHRyYW5zZmVyCj4gdGhlc2UgcGVuZGluZyBzdGF0ZXMgdG8gSFcgaW4gR0lDIFZNIHN0YXRlIGNo YW5nZSBoYW5kbGVyIGNvcnJlc3BvbmRpbmcgCj4gdG8KPiBzYXZlX3BlbmRpbmdfdGFibGVzPwoK VXNlcnNwYWNlIGhhcyBubyB3YXkgdG8ga25vdyB3ZSB1c2UgR0lDdjQsIGFuZCBJIGludGVuZCB0 byBrZWVwIGl0CmNvbXBsZXRlbHkgb3V0IG9mIHRoZSBsb29wLiBUaGUgQVBJIGlzIGFscmVhZHkg cHJldHR5IHRvcnR1b3VzLCBhbmQKSSByZWFsbHkgZG9uJ3Qgd2FudCB0byBhZGQgYW55IGV4dHJh IGNvbXBsZXhpdHkgdG8gaXQuCgpUaGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3Qg ZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK