From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A7DCCA47B for ; Mon, 13 Jun 2022 08:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239645AbiFMINJ (ORCPT ); Mon, 13 Jun 2022 04:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239861AbiFMIMV (ORCPT ); Mon, 13 Jun 2022 04:12:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9233E1EC6A for ; Mon, 13 Jun 2022 01:12:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655107933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zylh1uwH3+G7KCcoxsL8sX4hSmvWfJyfd8skUX3SqY0=; b=axQK7uuju7sP5HSR22bEUsIqoPHvFMW4uPxKTyKDaDwLXo8/7kKmqDTxKCuOe8uxvjvi7u ono7Y2nsgEPnGyIdgdDEx4Uo3suCfWYdrNyqv58JTaKhth2HESvjOkQTXMhbDCgAFs0KJa NKNK5ryneGb/PJkum1jxfJBpfKiW+3w= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-96-OJe-sgY3MqalywSEQ2_dwA-1; Mon, 13 Jun 2022 04:12:12 -0400 X-MC-Unique: OJe-sgY3MqalywSEQ2_dwA-1 Received: by mail-qv1-f71.google.com with SMTP id kc24-20020a056214411800b0046d93b71e48so3414193qvb.3 for ; Mon, 13 Jun 2022 01:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zylh1uwH3+G7KCcoxsL8sX4hSmvWfJyfd8skUX3SqY0=; b=4Rpt0qSKODWadXReKI3XBgHBEmsYxYHAmXyxijNoRsA2yZhwR9UFhwoUD/uWgq6W50 5OhdeyL/bRztvsLN6nzBbf/5/rnSAmj/gtmNhjU8xqtWbE+Ays1vOcR91XHSf4qLDnF+ UH3EKyAAwmA4MRqo1aFS+A8nxebmvQDoC7sauGNLXrP547bJSzVZ0ODndXuCV1dBx1fC 4/DVdZbuEXhdP/O613sL1mBKvPiQXQItHu8ekrh20ICuTBROvzmRpfkNpFUy0CbpMThG tp45EF2xQYPDi2dWXomW0h3iRFJo/CSmAxLkq3iOzhPDS5zDJpr1202bMCrdRQQmEn8d Vyhg== X-Gm-Message-State: AOAM533X+34n/3TWpO6kv9Z9n2GQiC1Q76xA0ACkENqU5L7JyYjwyj0x hxqUYzmq0RoAzrEzlPwGXB5K1ZhYfjl69mJ9ner9H1QC288e7lfa/Sf5VExQqYdnuG7RfisGZ2o OgSsMUF2IE9AWu9u8E4zyKeqa X-Received: by 2002:a05:622a:1829:b0:304:ef78:8385 with SMTP id t41-20020a05622a182900b00304ef788385mr29662307qtc.251.1655107931898; Mon, 13 Jun 2022 01:12:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjLbgha+Atbwd2/672pHZ9TBWRG8nE6aGEjsg4713GAJdcGUXYTIFRS5oET6rQnKiNs5SleA== X-Received: by 2002:a05:622a:1829:b0:304:ef78:8385 with SMTP id t41-20020a05622a182900b00304ef788385mr29662298qtc.251.1655107931645; Mon, 13 Jun 2022 01:12:11 -0700 (PDT) Received: from [192.168.0.3] (ip-109-42-115-130.web.vodafone.de. [109.42.115.130]) by smtp.gmail.com with ESMTPSA id j1-20020a05620a410100b006a65c58db99sm6390714qko.64.2022.06.13.01.12.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jun 2022 01:12:11 -0700 (PDT) Message-ID: <2d8bcbb1-ee9d-8e88-b01d-88b80da86f13@redhat.com> Date: Mon, 13 Jun 2022 10:12:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v2 000/144] KVM: selftests: Overhaul APIs, purge VCPU_ID Content-Language: en-US To: Sean Christopherson , Anup Patel Cc: Paolo Bonzini , KVM General , Vitaly Kuznetsov , Andrew Jones , David Matlack , Ben Gardon , Oliver Upton , "linux-kernel@vger.kernel.org List" , Sean Christopherson , Marc Zyngier , Cornelia Huck References: <20220603004331.1523888-1-seanjc@google.com> <21570ac1-e684-7983-be00-ba8b3f43a9ee@redhat.com> From: Thomas Huth In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2022 02.57, Sean Christopherson wrote: > +s390 folks... > > On Fri, Jun 10, 2022, Sean Christopherson wrote: >> On Thu, Jun 09, 2022, Sean Christopherson wrote: >>> On Thu, Jun 09, 2022, Anup Patel wrote: >>>> On Wed, Jun 8, 2022 at 9:26 PM Anup Patel wrote: >>>>> >>>>> On Tue, Jun 7, 2022 at 8:57 PM Paolo Bonzini wrote: >>>>>> >>>>>> Marc, Christian, Anup, can you please give this a go? >>>>> >>>>> Sure, I will try this series. >>>> >>>> I tried to apply this series on top of kvm/next and kvm/queue but >>>> I always get conflicts. It seems this series is dependent on other >>>> in-flight patches. >>> >>> Hrm, that's odd, it's based directly on kvm/queue, commit 55371f1d0c01 ("KVM: ...). >> >> Duh, Paolo updated kvm/queue. Where's Captain Obvious when you need him... >> >>>> Is there a branch somewhere in a public repo ? >>> >>> https://github.com/sean-jc/linux/tree/x86/selftests_overhaul >> >> I pushed a new version that's based on the current kvm/queue, commit 5e9402ac128b. >> arm and x86 look good (though I've yet to test on AMD). >> >> Thomas, >> If you get a chance, could you rerun the s390 tests? The recent refactorings to >> use TAP generated some fun conflicts. Still works fine! Tested-by: Thomas Huth >> Speaking of TAP, I added a patch to convert __TEST_REQUIRE to use ksft_exit_skip() >> instead of KVM's custom print_skip(). The s390 tests are being converted to use >> TAP output, I couldn't see any advantage of KVM's arbitrary "skipping test" over >> TAP-friendly output, and converting everything is far easier than special casing s390. Sounds like a good idea to me. I already considered starting to convert some x86 tests, too (https://lore.kernel.org/linux-kselftest/20220429071149.488114-1-thuth@redhat.com ), but didn't get much feedback there yet, but anyway, we'll be better prepared with your change for that now. Thomas