From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC398C433E0 for ; Mon, 13 Jul 2020 16:08:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2C00206F0 for ; Mon, 13 Jul 2020 16:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729644AbgGMQId (ORCPT ); Mon, 13 Jul 2020 12:08:33 -0400 Received: from fieber.vanmierlo.com ([84.243.197.177]:40987 "EHLO kerio9.vanmierlo.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729027AbgGMQId (ORCPT ); Mon, 13 Jul 2020 12:08:33 -0400 X-Footer: dmFubWllcmxvLmNvbQ== Received: from roundcube.vanmierlo.com ([192.168.37.37]) (authenticated user m.brock@vanmierlo.com) by kerio9.vanmierlo.com (Kerio Connect 9.2.12 patch 1) with ESMTPA; Mon, 13 Jul 2020 18:08:08 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 13 Jul 2020 18:08:08 +0200 From: Maarten Brock To: Helmut Grohne Cc: Michal Simek , Greg Kroah-Hartman , Jiri Slaby , Shubhrajyoti Datta , Jan Kiszka , linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial-owner@vger.kernel.org Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment In-Reply-To: <20200713121019.GA6920@laureti-dev> References: <20200709074849.GA28968@laureti-dev> <20200713071123.GA1994@laureti-dev> <20200713121019.GA6920@laureti-dev> Message-ID: <2db78149ae9ffb205f02ca4919b50d88@vanmierlo.com> X-Sender: m.brock@vanmierlo.com User-Agent: Roundcube Webmail/1.3.3 Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 2020-07-13 14:10, Helmut Grohne wrote: > Hi Michal, > > On Mon, Jul 13, 2020 at 01:49:38PM +0200, Michal Simek wrote: >> On 13. 07. 20 9:11, Helmut Grohne wrote: >> > Let me try to enumerate those I know: >> > >> > uart0 | uart1 | console | remark >> > ---------+----------+---------+---------- >> > serial0 | serial1 | ttyPS0 | regular case >> > serial0 | serial1 | ttyPS1 | normal assignment, second console >> > serial1 | serial0 | ttyPS0 | -> Jan Kiszka, broken since revert >> > disabled | serial0 | ttyPS0 | use only uart1 as serial0 >> > serial0 | disabled | ttyPS0 | regular case with uart1 disabled >> > >> > Out of these, I'm actively using configurations 3 and 4. >> > >> > Which of these scenarios do you test already? >> >> For above we are missing also others >> serial1 | serial0 | ttyPS1 >> disabled| serial1 | ttyPS1 > > Is it actually possible to have ttyPS1, but no ttyPS0? I think I tried > doing that earlier and it resulted in there being ttyPS0, but no > ttyPS1. What if you also have a 16550 (in the PL) and give it the serial0 alias? Or a UARTlite? The serialN alias is inappropriate to set the number for ttyPSn. How are you supposed to create all of ttyPS0, ttyS0 and ttyUL0 using a single serial0 alias? >> serial1 | disables | ttyPS0 > > I'm not sure what this is supposed to mean. When there is no serial0 > alias, I'd expect ttyPS0 to be missing. However as indicated above that > is not what happens in practice. So either of these two configurations > seems invalid to me. > >> All of these above are just not setting any console= on bootargs. > > We usually set the console= assignment on bootargs. > >> It means mix of these combinations is tested regularly but not all of >> them. Do you see any other combination which is not supported? > > I'm not aware of further relevant combinations. > > Can we maybe trim down the matrix somehow? In my context, the need for > swapping the serial aliases arises from a limitation in u-boot-xlnx and > the desire to use one dtb for both linux and u-boot. It requires that > the serial0 alias is the console. Are there other reasons to swap them? > If not, maybe fixing u-boot would be an option? > > Helmut I think that it would be better if u-boot used a "console" alias. Maarten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F72C433E2 for ; Mon, 13 Jul 2020 16:09:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 959C62076D for ; Mon, 13 Jul 2020 16:09:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TPqCsSMb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 959C62076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vanmierlo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N1ckwNal12dwlP8dNVmEoTaJjVl2ivYUt7L2YqHx/7A=; b=TPqCsSMbygTM8mWs2m191+Mip 55F7rJtqqCb38byBl6eYlteq5Y/kKE2KEQYJUa/oqGF/GHGpkgsxBy5WJZQ/c10RQl1hAhLVPst4j Ndk7iu1gQ9XpylN3VZhDLmAqv+4+tbtH4MDAC5UTXCIRYKdEwbM2Qpg66F5wZbjL4vMH+/tYl8qzG LlErJ4ccqAicv7fPRyvZlax7TfijxkbrPwh/DxG+1damRRTirup/QHNtlOUKR0TomQ+DQU7XSVR1y EsxDXRCivY+DtMHpkaWzu1YtIdh70PQMK5E8GKe3pMsWhKb9TUjpYuBzx66ny9d7PHIan00j5RoR0 J6+XDfn3w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv10J-0005VM-8B; Mon, 13 Jul 2020 16:08:31 +0000 Received: from fieber.vanmierlo.com ([84.243.197.177] helo=kerio9.vanmierlo.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jv10F-0005Sy-Nx for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2020 16:08:28 +0000 X-Footer: dmFubWllcmxvLmNvbQ== Received: from roundcube.vanmierlo.com ([192.168.37.37]) (authenticated user m.brock@vanmierlo.com) by kerio9.vanmierlo.com (Kerio Connect 9.2.12 patch 1) with ESMTPA; Mon, 13 Jul 2020 18:08:08 +0200 MIME-Version: 1.0 Date: Mon, 13 Jul 2020 18:08:08 +0200 From: Maarten Brock To: Helmut Grohne Subject: Re: [PATCH] tty: xilinx_uartps: Really fix id assignment In-Reply-To: <20200713121019.GA6920@laureti-dev> References: <20200709074849.GA28968@laureti-dev> <20200713071123.GA1994@laureti-dev> <20200713121019.GA6920@laureti-dev> Message-ID: <2db78149ae9ffb205f02ca4919b50d88@vanmierlo.com> X-Sender: m.brock@vanmierlo.com User-Agent: Roundcube Webmail/1.3.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200713_120827_917791_0D076EFA X-CRM114-Status: GOOD ( 18.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-serial-owner@vger.kernel.org, Greg Kroah-Hartman , Shubhrajyoti Datta , Michal Simek , Jan Kiszka , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-07-13 14:10, Helmut Grohne wrote: > Hi Michal, > > On Mon, Jul 13, 2020 at 01:49:38PM +0200, Michal Simek wrote: >> On 13. 07. 20 9:11, Helmut Grohne wrote: >> > Let me try to enumerate those I know: >> > >> > uart0 | uart1 | console | remark >> > ---------+----------+---------+---------- >> > serial0 | serial1 | ttyPS0 | regular case >> > serial0 | serial1 | ttyPS1 | normal assignment, second console >> > serial1 | serial0 | ttyPS0 | -> Jan Kiszka, broken since revert >> > disabled | serial0 | ttyPS0 | use only uart1 as serial0 >> > serial0 | disabled | ttyPS0 | regular case with uart1 disabled >> > >> > Out of these, I'm actively using configurations 3 and 4. >> > >> > Which of these scenarios do you test already? >> >> For above we are missing also others >> serial1 | serial0 | ttyPS1 >> disabled| serial1 | ttyPS1 > > Is it actually possible to have ttyPS1, but no ttyPS0? I think I tried > doing that earlier and it resulted in there being ttyPS0, but no > ttyPS1. What if you also have a 16550 (in the PL) and give it the serial0 alias? Or a UARTlite? The serialN alias is inappropriate to set the number for ttyPSn. How are you supposed to create all of ttyPS0, ttyS0 and ttyUL0 using a single serial0 alias? >> serial1 | disables | ttyPS0 > > I'm not sure what this is supposed to mean. When there is no serial0 > alias, I'd expect ttyPS0 to be missing. However as indicated above that > is not what happens in practice. So either of these two configurations > seems invalid to me. > >> All of these above are just not setting any console= on bootargs. > > We usually set the console= assignment on bootargs. > >> It means mix of these combinations is tested regularly but not all of >> them. Do you see any other combination which is not supported? > > I'm not aware of further relevant combinations. > > Can we maybe trim down the matrix somehow? In my context, the need for > swapping the serial aliases arises from a limitation in u-boot-xlnx and > the desire to use one dtb for both linux and u-boot. It requires that > the serial0 alias is the console. Are there other reasons to swap them? > If not, maybe fixing u-boot would be an option? > > Helmut I think that it would be better if u-boot used a "console" alias. Maarten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel