All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rasesh Mody <rmody@marvell.com>, dev@dpdk.org
Cc: jerinj@marvell.com, GR-Everest-DPDK-Dev@marvell.com
Subject: Re: [dpdk-dev] [PATCH v2 0/4] net/bnx2x: update to latest FW
Date: Mon, 23 Sep 2019 17:33:22 +0100	[thread overview]
Message-ID: <2e5610a0-0654-83c0-4d22-cb926fc3f4f7@intel.com> (raw)
In-Reply-To: <20190919211157.1668-1-rmody@marvell.com>

On 9/19/2019 10:11 PM, Rasesh Mody wrote:
> Hi,
> 
> Currently, BNX2X PMD uses a very old firmware 7.2.51.
> This patch series updated the base driver to use to latest
> firmware 7.13.11. The latest firmware comprises of enhancements
> and fixes.
> 
> v2:
>  - Squashed pmd version patch into "net/bnx2x: update to latest FW 7.13.11"
>  - Addressed most of checkpatch issues
> 
> Thanks!
> -Rasesh
> 
> Rasesh Mody (4):
>   net/bnx2x: update and reorganize HW registers
>   net/bnx2x: update HSI code
>   net/bnx2x: update to latest FW 7.13.11
>   doc: cleanup SPDX license id usage in bnx2x guide
> 

I am getting build errors with this patchset [1], since it is merged into
next-net-mrvl, I only pulled the doc patch, 4/4, but not others, can you please
check the patchset?




[1]
In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
.../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for
‘uint64_t’
   25 | #define __le64  uint64_t
      |                 ^~~~~~~~
In file included from /usr/include/stdint.h:37,
                 from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:17,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
/usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’
was here
   27 | typedef __uint64_t uint64_t;
      |                    ^~~~~~~~
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function
‘rte_eth_linkstatus_set’:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error:
passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
  176 |  orig.val64 = rte_atomic64_exchange(dev_link,
      |                                     ^~~~~~~~
      |                                     |
      |                                     volatile uint64_t * {aka volatile
long long unsigned int *}
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_rxtx.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note:
expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument
is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’}
   48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
      |                       ~~~~~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors




In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
.../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for
‘uint64_t’
   25 | #define __le64  uint64_t
      |                 ^~~~~~~~
In file included from /usr/include/stdint.h:37,
                 from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:17,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
/usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’
was here
   27 | typedef __uint64_t uint64_t;
      |                    ^~~~~~~~
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function
‘rte_eth_linkstatus_set’:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error:
passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
  176 |  orig.val64 = rte_atomic64_exchange(dev_link,
      |                                     ^~~~~~~~
      |                                     |
      |                                     volatile uint64_t * {aka volatile
long long unsigned int *}
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_vfpf.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note:
expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument
is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’}
   48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
      |                       ~~~~~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors


make[7]: *** [.../dpdk/mk/internal/rte.compile-pre.mk:116: ecore_sp.o] Error 1
In file included from .../dpdk/drivers/net/bnx2x/bnx2x.h:22,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
.../dpdk/drivers/net/bnx2x/bnx2x_osal.h:25:17: error: conflicting types for
‘uint64_t’
   25 | #define __le64  uint64_t
      |                 ^~~~~~~~
In file included from /usr/include/stdint.h:37,
                 from /usr/lib/gcc/x86_64-redhat-linux/9/include/stdint.h:9,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_byteorder.h:12,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:17,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
/usr/include/bits/stdint-uintn.h:27:20: note: previous declaration of ‘uint64_t’
was here
   27 | typedef __uint64_t uint64_t;
      |                    ^~~~~~~~
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:33,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h: In function
‘rte_eth_linkstatus_set’:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_ethdev_driver.h:176:37: error:
passing argument 1 of ‘rte_atomic64_exchange’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
  176 |  orig.val64 = rte_atomic64_exchange(dev_link,
      |                                     ^~~~~~~~
      |                                     |
      |                                     volatile uint64_t * {aka volatile
long long unsigned int *}
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic.h:263,
                 from
.../dpdk/x86_64-native-linuxapp-gcc/include/generic/rte_cycles.h:18,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_cycles.h:13,
                 from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_spinlock.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:18,
                 from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.c:8:
.../dpdk/x86_64-native-linuxapp-gcc/include/rte_atomic_64.h:48:42: note:
expected ‘volatile uint64_t *’ {aka ‘volatile long unsigned int *’} but argument
is of type ‘volatile uint64_t *’ {aka ‘volatile long long unsigned int *’}
   48 | rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)
      |                       ~~~~~~~~~~~~~~~~~~~^~~
cc1: all warnings being treated as errors


In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:40,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.c:16:
.../dpdk/drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_dma_alloc’:
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:21:3: error: format ‘%lx’ expects
argument of type ‘long unsigned int’, but argument 9 has type ‘rte_iova_t’ {aka
‘long long unsigned int’} [-Werror=format=]
   21 |   "[%s:%d(%s)] " fmt, __func__, __LINE__, \
      |   ^~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:25:2: note: in expansion of macro
‘PMD_DRV_LOG_RAW’
   25 |  PMD_DRV_LOG_RAW(level, sc, fmt "\n", ## args)
      |  ^~~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x.c:190:2: note: in expansion of macro ‘PMD_DRV_LOG’
  190 |  PMD_DRV_LOG(DEBUG, sc,
      |  ^~~~~~~~~~~
In file included from .../dpdk/x86_64-native-linuxapp-gcc/include/rte_bus_pci.h:25,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:19,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.c:16:
/usr/include/inttypes.h:121:34: note: format string is defined here
  121 | # define PRIx64  __PRI64_PREFIX "x"
In file included from .../dpdk/drivers/net/bnx2x/bnx2x_ethdev.h:40,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.h:23,
                 from .../dpdk/drivers/net/bnx2x/bnx2x.c:16:
.../dpdk/drivers/net/bnx2x/bnx2x.c: In function ‘bnx2x_load_firmware’:
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:21:3: error: format ‘%lu’ expects
argument of type ‘long unsigned int’, but argument 7 has type ‘uint64_t’ {aka
‘long long unsigned int’} [-Werror=format=]
   21 |   "[%s:%d(%s)] " fmt, __func__, __LINE__, \
      |   ^~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x_logs.h:25:2: note: in expansion of macro
‘PMD_DRV_LOG_RAW’
   25 |  PMD_DRV_LOG_RAW(level, sc, fmt "\n", ## args)
      |  ^~~~~~~~~~~~~~~
.../dpdk/drivers/net/bnx2x/bnx2x.c:9672:3: note: in expansion of macro ‘PMD_DRV_LOG’
 9672 |   PMD_DRV_LOG(NOTICE, sc,
      |   ^~~~~~~~~~~





  reply	other threads:[~2019-09-23 16:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06  7:25 [dpdk-dev] [PATCH 0/5] net/bnx2x: update to latest FW Rasesh Mody
2019-09-06  7:25 ` [dpdk-dev] [PATCH 1/5] net/bnx2x: update and reorganize HW registers Rasesh Mody
2019-09-12 12:17   ` Jerin Jacob
2019-09-19 21:28     ` [dpdk-dev] [EXT] " Rasesh Mody
2019-09-23 10:47   ` [dpdk-dev] " Jerin Jacob
2019-09-06  7:25 ` [dpdk-dev] [PATCH 2/5] net/bnx2x: update HSI code Rasesh Mody
2019-09-06  7:25 ` [dpdk-dev] [PATCH 3/5] net/bnx2x: update to latest FW 7.13.11 Rasesh Mody
2019-09-12 12:25   ` Jerin Jacob
2019-09-06  7:25 ` [dpdk-dev] [PATCH 4/5] doc: cleanup SPDX license id usage in bnx2x guide Rasesh Mody
2019-09-06  7:25 ` [dpdk-dev] [PATCH 5/5] net/bnx2x: change PMD version to 1.1.0.1 Rasesh Mody
2019-09-12 12:11 ` [dpdk-dev] [PATCH 0/5] net/bnx2x: update to latest FW Jerin Jacob
2019-09-12 22:00   ` [dpdk-dev] [EXT] " Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 0/4] " Rasesh Mody
2019-09-23 16:33   ` Ferruh Yigit [this message]
2019-09-24 15:39     ` Jerin Jacob
2019-09-24 15:57       ` Ferruh Yigit
2019-09-24 16:30         ` Jerin Jacob
2019-09-24 16:51           ` Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 1/4] net/bnx2x: update and reorganize HW registers Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 2/4] net/bnx2x: update HSI code Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 3/4] net/bnx2x: update to latest FW 7.13.11 Rasesh Mody
2019-09-19 21:11 ` [dpdk-dev] [PATCH v2 4/4] doc: cleanup SPDX license id usage in bnx2x guide Rasesh Mody
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 0/3] net/bnx2x: update to latest FW Rasesh Mody
2019-10-03  5:57   ` Jerin Jacob
2019-10-03  6:48     ` Rasesh Mody
2019-10-04  9:32       ` Jerin Jacob
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 1/3] net/bnx2x: update and reorganize HW registers Rasesh Mody
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 2/3] net/bnx2x: update HSI code Rasesh Mody
2019-10-02 19:14 ` [dpdk-dev] [PATCH v3 3/3] net/bnx2x: update to latest FW 7.13.11 Rasesh Mody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e5610a0-0654-83c0-4d22-cb926fc3f4f7@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=GR-Everest-DPDK-Dev@marvell.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=rmody@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.