From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by mail.openembedded.org (Postfix) with ESMTP id A550071C54 for ; Tue, 9 Oct 2018 01:47:52 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id w991lXIe010086 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL) for ; Mon, 8 Oct 2018 18:47:44 -0700 Received: from [128.224.162.218] (128.224.162.218) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 8 Oct 2018 18:47:23 -0700 To: Hongxu Jia , References: <1535967326-32322-1-git-send-email-hongxu.jia@windriver.com> From: ChenQi Message-ID: <2ef6aa73-a3bd-d14a-11ef-66b8c02aecc1@windriver.com> Date: Tue, 9 Oct 2018 09:53:07 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1535967326-32322-1-git-send-email-hongxu.jia@windriver.com> X-Originating-IP: [128.224.162.218] Subject: Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Oct 2018 01:47:53 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit ping I think webkitgtk does require the 'opengl' distro feature. We have in mesa.inc: PACKAGECONFIG ??= ".... \ ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'opengl egl gles gbm dri', '', d)} \ ..." PROVIDES = " \ ${@bb.utils.contains('PACKAGECONFIG', 'opengl', 'virtual/libgl', '', d)} \ ${@bb.utils.contains('PACKAGECONFIG', 'gles', 'virtual/libgles1 virtual/libgles2', '', d)} \ ..." And webkitgtk's source codes are like: #if USE(LIBEPOXY) // libepoxy headers have to be included before in order to avoid // picking up khrplatform.h inclusion that's done in ANGLE. #include #endif #include #include #if PLATFORM(IOS) #import #elif PLATFORM(MAC) #include #elif PLATFORM(WIN) #include "OpenGLESShims.h" #elif USE(LIBEPOXY) // already included above. #elif USE(OPENGL_ES_2) #include #else #include "OpenGLShims.h" #endif And libepoxy is wrapper around libgl. So I think we can conclude 'opengl' is required distro feature for webkitgkt? At least this is the current situation in OE. Best Regards, Chen Qi On 09/03/2018 05:35 PM, Hongxu Jia wrote: > They can't be built without opengl in DISTRO_FEATURES. > [snip] > |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10: > fatal error: GL/gl.h: No such file or directory > [snip] > > Signed-off-by: Hongxu Jia > --- > meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb > index a528c5d..93d74bb 100644 > --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb > +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb > @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48 > > inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc > > -# depends on libxt > -REQUIRED_DISTRO_FEATURES = "x11" > +REQUIRED_DISTRO_FEATURES = "x11 opengl" > > DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \ > gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \