From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C713FC4338F for ; Mon, 9 Aug 2021 14:40:27 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 4424561004 for ; Mon, 9 Aug 2021 14:40:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4424561004 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54D364068A; Mon, 9 Aug 2021 16:40:26 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 536734003C for ; Mon, 9 Aug 2021 16:40:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="236700883" X-IronPort-AV: E=Sophos;i="5.84,307,1620716400"; d="scan'208";a="236700883" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 07:40:24 -0700 X-IronPort-AV: E=Sophos;i="5.84,307,1620716400"; d="scan'208";a="638482009" Received: from amandee1-mobl.gar.corp.intel.com (HELO [10.213.124.87]) ([10.213.124.87]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 07:40:21 -0700 To: Andrew Rybchenko , Xueming Li Cc: dev@dpdk.org, Viacheslav Ovsiienko , Thomas Monjalon , Ferruh Yigit References: <20210727034134.20556-1-xuemingl@nvidia.com> <24309185-57e8-9a21-6b3a-939c4d74f1e7@oktetlabs.ru> From: "Singh, Aman Deep" Message-ID: <3032fdb1-58a5-5470-9903-09b992c059d4@intel.com> Date: Mon, 9 Aug 2021 20:09:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <24309185-57e8-9a21-6b3a-939c4d74f1e7@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [RFC] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Xueming, On 7/28/2021 1:10 PM, Andrew Rybchenko wrote: > On 7/27/21 6:41 AM, Xueming Li wrote: >> To align with other eth device queue configuration callbacks, change RX >> and TX queue release callback API parameter from queue object to device >> and queue index. >> >> Signed-off-by: Xueming Li > > In fact, there is no strong reasons to do it, but I think it is a nice > cleanup to use (dev + queue index) on control path. > > Hopefully it will not result in any regressions. Combined there are 100+ API's for Rx/Tx queue_release that need to be modified for it. I believe all regression possibilities here will be caught, in compilation phase itself.