All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Hedde <damien.hedde@greensocs.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Helge Deller <deller@gmx.de>,
	Sven Schnelle <svens@stackframe.org>
Subject: Re: [PATCH 1/3] hw/input/lasips2: Fix typos in function names
Date: Wed, 29 Sep 2021 16:24:52 +0200	[thread overview]
Message-ID: <307ae3c0-de82-da34-6443-c087c4c6cc71@greensocs.com> (raw)
In-Reply-To: <20210920064048.2729397-2-f4bug@amsat.org>



On 9/20/21 08:40, Philippe Mathieu-Daudé wrote:
> Artist is another device, this one is the Lasi PS/2.
> Rename the functions accordingly.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
> ---
>   hw/input/lasips2.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/input/lasips2.c b/hw/input/lasips2.c
> index e7faf24058b..68d741d3421 100644
> --- a/hw/input/lasips2.c
> +++ b/hw/input/lasips2.c
> @@ -96,7 +96,7 @@ typedef enum {
>       LASIPS2_STATUS_CLKSHD = 0x80,
>   } lasips2_status_reg_t;
>   
> -static const char *artist_read_reg_name(uint64_t addr)
> +static const char *lasips2_read_reg_name(uint64_t addr)
>   {
>       switch (addr & 0xc) {
>       case REG_PS2_ID:
> @@ -116,7 +116,7 @@ static const char *artist_read_reg_name(uint64_t addr)
>       }
>   }
>   
> -static const char *artist_write_reg_name(uint64_t addr)
> +static const char *lasips2_write_reg_name(uint64_t addr)
>   {
>       switch (addr & 0x0c) {
>       case REG_PS2_RESET:
> @@ -145,7 +145,7 @@ static void lasips2_reg_write(void *opaque, hwaddr addr, uint64_t val,
>       LASIPS2Port *port = opaque;
>   
>       trace_lasips2_reg_write(size, port->id, addr,
> -                            artist_write_reg_name(addr), val);
> +                            lasips2_write_reg_name(addr), val);
>   
>       switch (addr & 0xc) {
>       case REG_PS2_CONTROL:
> @@ -239,7 +239,7 @@ static uint64_t lasips2_reg_read(void *opaque, hwaddr addr, unsigned size)
>           break;
>       }
>       trace_lasips2_reg_read(size, port->id, addr,
> -                           artist_read_reg_name(addr), ret);
> +                           lasips2_read_reg_name(addr), ret);
>   
>       return ret;
>   }
> 


  reply	other threads:[~2021-09-29 14:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20  6:40 [PATCH 0/3] hw/input/lasips2: QOM'ify the Lasi PS/2 Philippe Mathieu-Daudé
2021-09-20  6:40 ` [PATCH 1/3] hw/input/lasips2: Fix typos in function names Philippe Mathieu-Daudé
2021-09-29 14:24   ` Damien Hedde [this message]
2021-09-20  6:40 ` [PATCH 2/3] hw/input/lasips2: Move LASIPS2State declaration to 'hw/input/lasips2.h' Philippe Mathieu-Daudé
2021-09-29 14:27   ` Damien Hedde
2021-09-20  6:40 ` [PATCH 3/3] hw/input/lasips2: QOM'ify the Lasi PS/2 Philippe Mathieu-Daudé
2021-09-29 14:33   ` Damien Hedde
2021-09-29 14:06 ` [PATCH 0/3] " Philippe Mathieu-Daudé
2021-10-27  5:11 ` Philippe Mathieu-Daudé
2021-10-27  8:46   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=307ae3c0-de82-da34-6443-c087c4c6cc71@greensocs.com \
    --to=damien.hedde@greensocs.com \
    --cc=deller@gmx.de \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=svens@stackframe.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.