From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEE52C2D0FA for ; Wed, 13 May 2020 13:17:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B21A82064E for ; Wed, 13 May 2020 13:17:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="G6XxcD+D" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387608AbgEMNRz (ORCPT ); Wed, 13 May 2020 09:17:55 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:39513 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387520AbgEMNRz (ORCPT ); Wed, 13 May 2020 09:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589375874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uvCkRI/K32PIBqaQ7LcOfghe4diMRxEm5e5JsVQlwss=; b=G6XxcD+DnVzbRBzroKEJYY/6ep+zurnrvHBQE/oit7bPj5Hcs3KiMHQVABrUrCMTXm9Qmt et43YntAv2FAuB6+lYjFvEdlDp8b+oi/Vb7d26H5JI7jlF2IlS31YdBLLx6jCieWahoCwq +BzgMpiPErcgpiE/glAOGvoXYKjgz0s= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-9T7X1SL4M7u16KqBfljjIQ-1; Wed, 13 May 2020 09:17:52 -0400 X-MC-Unique: 9T7X1SL4M7u16KqBfljjIQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53C148014C0; Wed, 13 May 2020 13:17:49 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-59.rdu2.redhat.com [10.10.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8A53610F2; Wed, 13 May 2020 13:17:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200513062649.2100053-22-hch@lst.de> References: <20200513062649.2100053-22-hch@lst.de> <20200513062649.2100053-1-hch@lst.de> To: Christoph Hellwig Cc: dhowells@redhat.com, "David S. Miller" , Jakub Kicinski , Marcelo Ricardo Leitner , Eric Dumazet , linux-nvme@lists.infradead.org, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , linux-kernel@vger.kernel.org, Jon Maloy , Ying Xue , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3123897.1589375861.1@warthog.procyon.org.uk> Date: Wed, 13 May 2020 14:17:41 +0100 Message-ID: <3123898.1589375861@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David Howells [rxrpc bits] From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Wed, 13 May 2020 13:17:41 +0000 Subject: Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover Message-Id: <3123898.1589375861@warthog.procyon.org.uk> List-Id: References: <20200513062649.2100053-22-hch@lst.de> <20200513062649.2100053-1-hch@lst.de> In-Reply-To: <20200513062649.2100053-22-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Marcelo Ricardo Leitner , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, Jakub Kicinski , drbd-dev@tron.linbit.com, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , Eric Dumazet , Jon Maloy , Ying Xue , "David S. Miller" , ocfs2-devel@oss.oracle.com Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David Howells [rxrpc bits] From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover Date: Wed, 13 May 2020 14:17:41 +0100 Message-ID: <3123898.1589375861@warthog.procyon.org.uk> References: <20200513062649.2100053-22-hch@lst.de> <20200513062649.2100053-1-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: In-Reply-To: <20200513062649.2100053-22-hch@lst.de> Content-ID: <3123897.1589375861.1@warthog.procyon.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cluster-devel-bounces@redhat.com Errors-To: cluster-devel-bounces@redhat.com To: Christoph Hellwig Cc: Marcelo Ricardo Leitner , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, Jakub Kicinski , drbd-dev@tron.linbit.com, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , Eric Dumazet , Jon Maloy , Ying Xue , "David S. Miller" , ocfs2-devel@oss.oracle.com List-Id: ceph-devel.vger.kernel.org Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David Howells [rxrpc bits] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FE6CA90AF for ; Wed, 13 May 2020 13:18:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 832742063B for ; Wed, 13 May 2020 13:18:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="acAhTx0Q"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QSsayEV4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 832742063B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:Content-ID:MIME-Version :Subject:To:References:In-Reply-To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MJhDT27jY7fBi5H7wAUFQM5A3WdPJjgkza4Ip0r5nF4=; b=acAhTx0QIeJlfn l7sWJLL0S3iCJGkAuSBICj1aDFMHSIF1EFlbk2Irw7tIxKAVUeuIPZ96w63//WbzKy+YNOUlhRjbo RGuFhtX3YkNno91jAI/fcvGtNke7tzv5+CQEisNGyD+Wk5S9SlqgVmjllDK2Bo8T5TXESD1Lu9HBi Pe8NlKnv87cWPctSLhzGrQWhtSePmAKqsd1a9JCJksZBhDJpRVA48GEmgRJ0DkPtTnrOIH2pcq4/R TZ+fqRN8ygssw0UQdWh9tDME0vEjrn87VAIkpM7rZQo5mhXBCcE/xkh0zR8rVssXUSIBr/jMyUMUa s1tmQVz7VIbkHoQHiSHg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYrH8-0005jP-Al; Wed, 13 May 2020 13:18:18 +0000 Received: from us-smtp-1.mimecast.com ([207.211.31.81] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYrGo-0005Qy-I4 for linux-nvme@lists.infradead.org; Wed, 13 May 2020 13:18:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589375877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uvCkRI/K32PIBqaQ7LcOfghe4diMRxEm5e5JsVQlwss=; b=QSsayEV4hsn+RkiKYSWzBlNSmpl0HhPjcwU69qH2To92aOaEnfKqOmAbQfFPtz0362nk0f c/tr3Z43oCSA9Aw42wwMEZKE3y4UyF2IWuNzvqU/8LKcgmGZh19Q6LeSBFj4ctdttE3gXf JCRArBt5F0gIfjglFgS+mYiuRSfJauM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-9T7X1SL4M7u16KqBfljjIQ-1; Wed, 13 May 2020 09:17:52 -0400 X-MC-Unique: 9T7X1SL4M7u16KqBfljjIQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 53C148014C0; Wed, 13 May 2020 13:17:49 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-59.rdu2.redhat.com [10.10.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8A53610F2; Wed, 13 May 2020 13:17:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200513062649.2100053-22-hch@lst.de> References: <20200513062649.2100053-22-hch@lst.de> <20200513062649.2100053-1-hch@lst.de> To: Christoph Hellwig Subject: Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover MIME-Version: 1.0 Content-ID: <3123897.1589375861.1@warthog.procyon.org.uk> Date: Wed, 13 May 2020 14:17:41 +0100 Message-ID: <3123898.1589375861@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200513_061758_689343_CA452485 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcelo Ricardo Leitner , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, drbd-dev@lists.linbit.com, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, Jakub Kicinski , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , Eric Dumazet , Jon Maloy , Ying Xue , "David S. Miller" , ocfs2-devel@oss.oracle.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David Howells [rxrpc bits] _______________________________________________ linux-nvme mailing list linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Wed, 13 May 2020 14:17:41 +0100 Subject: [Ocfs2-devel] [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover In-Reply-To: <20200513062649.2100053-22-hch@lst.de> References: <20200513062649.2100053-22-hch@lst.de> <20200513062649.2100053-1-hch@lst.de> Message-ID: <3123898.1589375861@warthog.procyon.org.uk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Marcelo Ricardo Leitner , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-sctp@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, cluster-devel@redhat.com, Alexey Kuznetsov , linux-block@vger.kernel.org, Jakub Kicinski , drbd-dev@tron.linbit.com, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, Neil Horman , Hideaki YOSHIFUJI , netdev@vger.kernel.org, Vlad Yasevich , Eric Dumazet , Jon Maloy , Ying Xue , "David S. Miller" , ocfs2-devel@oss.oracle.com Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David Howells [rxrpc bits] From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Date: Wed, 13 May 2020 14:17:41 +0100 Subject: [Cluster-devel] [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover In-Reply-To: <20200513062649.2100053-22-hch@lst.de> References: <20200513062649.2100053-22-hch@lst.de> <20200513062649.2100053-1-hch@lst.de> Message-ID: <3123898.1589375861@warthog.procyon.org.uk> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David Howells [rxrpc bits]