From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16151C5517A for ; Mon, 26 Oct 2020 08:44:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1B0B223FD for ; Mon, 26 Oct 2020 08:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603701855; bh=yl4Jr0apm2y5t/1h4vG0U+9RG0/DEtSNGs1mZ7dsnrw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=jbgQefGNIiskLAdQVEpcIVr9bHMRV/++BHMbWNpY8WQgxtO0QGhpbifEhveEqdos9 iNfR5jmGUjMPUBgMBT42jLzf05o3e9CXAK44UEAEWvBqtrbkoqcS6eVRoliY+d4BYM tKLF3WmLT8K0mhxh9Fxz/E8dUbsaK+ylbsZRn6u8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1771176AbgJZIoO (ORCPT ); Mon, 26 Oct 2020 04:44:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:51180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1771047AbgJZIoO (ORCPT ); Mon, 26 Oct 2020 04:44:14 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 322C9223B0; Mon, 26 Oct 2020 08:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603701853; bh=yl4Jr0apm2y5t/1h4vG0U+9RG0/DEtSNGs1mZ7dsnrw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ykfuwBzfYzwDxngBERNMABnYWx9PZ0Wt3f61944YqpUGcWrDtnSnHqzuhfbRIhU/o dIB56qXPfukNKFctZTx4Z9U7iJm7xIrZXMxkgeFQZDAM4qLYCoaWPj59gikFDMyRlg JDw750Ok1Udzgac7NXkmkHJOcm1TI2nU60E85yvg= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kWy6s-004Gna-UZ; Mon, 26 Oct 2020 08:44:11 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 26 Oct 2020 08:44:10 +0000 From: Marc Zyngier To: Biwen Li Cc: shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, zhiqiang.hou@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com, linux-arm-kernel@lists.infradead.org, Biwen Li Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt In-Reply-To: <20201026080127.40499-1-biwen.li@oss.nxp.com> References: <20201026080127.40499-1-biwen.li@oss.nxp.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <31d8971374c261003aee9f4807c8ac8c@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: biwen.li@oss.nxp.com, shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, zhiqiang.hou@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com, linux-arm-kernel@lists.infradead.org, biwen.li@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-10-26 08:01, Biwen Li wrote: > From: Hou Zhiqiang > > Add an new IRQ chip declaration for LS1043A and LS1088A > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA Three things: - This commit message doesn't describe the bit_reverse change - Please add a cover letter - Sending the same series again after 4 days is not OK, specially when the initial one was during the merge window. Thanks, M. > > Signed-off-by: Hou Zhiqiang > Signed-off-by: Biwen Li > --- > drivers/irqchip/irq-ls-extirq.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/irqchip/irq-ls-extirq.c > b/drivers/irqchip/irq-ls-extirq.c > index 4d1179fed77c..564e6de0bd8e 100644 > --- a/drivers/irqchip/irq-ls-extirq.c > +++ b/drivers/irqchip/irq-ls-extirq.c > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > +// Copyright 2019-2020 NXP > > #define pr_fmt(fmt) "irq-ls-extirq: " fmt > > @@ -183,6 +184,9 @@ ls_extirq_of_init(struct device_node *node, struct > device_node *parent) > priv->bit_reverse = (revcr != 0); > } > > + if (of_device_is_compatible(node, "fsl,ls1043a-extirq")) > + priv->bit_reverse = true; > + > domain = irq_domain_add_hierarchy(parent_domain, 0, priv->nirq, node, > &extirq_domain_ops, priv); > if (!domain) > @@ -195,3 +199,5 @@ ls_extirq_of_init(struct device_node *node, struct > device_node *parent) > } > > IRQCHIP_DECLARE(ls1021a_extirq, "fsl,ls1021a-extirq", > ls_extirq_of_init); > +IRQCHIP_DECLARE(ls1043a_extirq, "fsl,ls1043a-extirq", > ls_extirq_of_init); > +IRQCHIP_DECLARE(ls1088a_extirq, "fsl,ls1088a-extirq", > ls_extirq_of_init); -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C460C2D0A3 for ; Mon, 26 Oct 2020 08:45:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15826223B0 for ; Mon, 26 Oct 2020 08:45:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nZSJ73Ul"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ykfuwBzf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15826223B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=urXIajjOfHW2pOuYIjwA+uvs+GOFRSOS7jmW5WLaNGI=; b=nZSJ73UlE0rXox0B+Ztcjq427 Va3tRoC/gj8+JqWT28AGpUrqCydX4AmKGO2I7YTvOjWJWFSy8gdux7Aw5jM6nSJISz2DvVr3mVXxG vVp3egNIXDPX2TwPqKHcCkiJa2IJ/WKrrOCZ+ChHq30EYsqbnh5fia68PF7u+LNKJRQm4WwSBg7oE OKaCEkeaum7jEK5sq1WhDg40rJ3HRAeErH407UYr3n9RY3cQM8UtZXM1j6cATbWi4a07o27CjzEZi DLXUQwlUwz/xblEyWMzosBWDMMqpJdjlA3YkjsxzEUiUWP1UBEYibS8W0kbJ7Hp23N2SS+KGzNGlC Dm1BDrcBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWy70-0003ad-9c; Mon, 26 Oct 2020 08:44:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWy6w-0003ZN-9Y for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2020 08:44:15 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 322C9223B0; Mon, 26 Oct 2020 08:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603701853; bh=yl4Jr0apm2y5t/1h4vG0U+9RG0/DEtSNGs1mZ7dsnrw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ykfuwBzfYzwDxngBERNMABnYWx9PZ0Wt3f61944YqpUGcWrDtnSnHqzuhfbRIhU/o dIB56qXPfukNKFctZTx4Z9U7iJm7xIrZXMxkgeFQZDAM4qLYCoaWPj59gikFDMyRlg JDw750Ok1Udzgac7NXkmkHJOcm1TI2nU60E85yvg= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kWy6s-004Gna-UZ; Mon, 26 Oct 2020 08:44:11 +0000 MIME-Version: 1.0 Date: Mon, 26 Oct 2020 08:44:10 +0000 From: Marc Zyngier To: Biwen Li Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt In-Reply-To: <20201026080127.40499-1-biwen.li@oss.nxp.com> References: <20201026080127.40499-1-biwen.li@oss.nxp.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <31d8971374c261003aee9f4807c8ac8c@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: biwen.li@oss.nxp.com, shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, zhiqiang.hou@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com, linux-arm-kernel@lists.infradead.org, biwen.li@nxp.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_044414_509140_88439228 X-CRM114-Status: GOOD ( 17.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jason@lakedaemon.net, Biwen Li , zhiqiang.hou@nxp.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, shawnguo@kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-10-26 08:01, Biwen Li wrote: > From: Hou Zhiqiang > > Add an new IRQ chip declaration for LS1043A and LS1088A > - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A > - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA Three things: - This commit message doesn't describe the bit_reverse change - Please add a cover letter - Sending the same series again after 4 days is not OK, specially when the initial one was during the merge window. Thanks, M. > > Signed-off-by: Hou Zhiqiang > Signed-off-by: Biwen Li > --- > drivers/irqchip/irq-ls-extirq.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/irqchip/irq-ls-extirq.c > b/drivers/irqchip/irq-ls-extirq.c > index 4d1179fed77c..564e6de0bd8e 100644 > --- a/drivers/irqchip/irq-ls-extirq.c > +++ b/drivers/irqchip/irq-ls-extirq.c > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > +// Copyright 2019-2020 NXP > > #define pr_fmt(fmt) "irq-ls-extirq: " fmt > > @@ -183,6 +184,9 @@ ls_extirq_of_init(struct device_node *node, struct > device_node *parent) > priv->bit_reverse = (revcr != 0); > } > > + if (of_device_is_compatible(node, "fsl,ls1043a-extirq")) > + priv->bit_reverse = true; > + > domain = irq_domain_add_hierarchy(parent_domain, 0, priv->nirq, node, > &extirq_domain_ops, priv); > if (!domain) > @@ -195,3 +199,5 @@ ls_extirq_of_init(struct device_node *node, struct > device_node *parent) > } > > IRQCHIP_DECLARE(ls1021a_extirq, "fsl,ls1021a-extirq", > ls_extirq_of_init); > +IRQCHIP_DECLARE(ls1043a_extirq, "fsl,ls1043a-extirq", > ls_extirq_of_init); > +IRQCHIP_DECLARE(ls1088a_extirq, "fsl,ls1088a-extirq", > ls_extirq_of_init); -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel