Re: [PATCH] compat: remove compat_printk

From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compat: remove compat_printk
Date: Wed, 22 Jun 2016 12:15:17 +0200	[thread overview]
Message-ID: <32739965.DkybxvdJlf@wuerfel> (raw)
In-Reply-To: <20160621163857.cf59ebebf39c38d67d71eb80@linux-foundation.org>

On Tuesday, June 21, 2016 4:38:57 PM CEST Andrew Morton wrote:
> > @@ -1077,15 +1076,6 @@ static struct ctl_table kern_table[] = {
> >               .extra1         = &neg_one,
> >       },
> >  #endif
> > -#ifdef CONFIG_COMPAT
> > -     {
> > -             .procname       = "compat-log",
> > -             .data           = &compat_log,
> > -             .maxlen         = sizeof (int),
> > -             .mode           = 0644,
> > -             .proc_handler   = proc_dointvec,
> > -     },
> > -#endif
> 
> How do we know we can simply remove /proc/sys/kernel/compat-log without
> breaking any userspace?
> 

Good point. I guess we can leave this in place just in case (with a comment)
and just remove the compat_printk function. We could probably have a Kconfig
symbol for obsolete sysctl files, but if this is the only one controlled
by it, it's probably not worth the effort.

	Arnd