From: Tony Krowiak <akrowiak@linux.ibm.com>
To: Halil Pasic <pasic@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, borntraeger@de.ibm.com,
alex.williamson@redhat.com, kwankhede@nvidia.com,
david@redhat.com
Subject: Re: [PATCH] s390/vfio-ap: Clean up vfio_ap resources when KVM pointer invalidated
Date: Thu, 3 Dec 2020 14:14:52 -0500 [thread overview]
Message-ID: <3299bd03-f0b8-39ac-4f0e-04bd198633fa@linux.ibm.com> (raw)
In-Reply-To: <20201203180141.19425931.pasic@linux.ibm.com>
On 12/3/20 12:01 PM, Halil Pasic wrote:
> On Thu, 3 Dec 2020 11:19:07 +0100
> Cornelia Huck <cohuck@redhat.com> wrote:
>
>>> @@ -1095,7 +1106,7 @@ static int vfio_ap_mdev_group_notifier(struct notifier_block *nb,
>>> matrix_mdev = container_of(nb, struct ap_matrix_mdev, group_notifier);
>>>
>>> if (!data) {
>>> - matrix_mdev->kvm = NULL;
>>> + vfio_ap_mdev_put_kvm(matrix_mdev);
>> Hm. I'm wondering whether you need to hold the maxtrix_dev lock here as
>> well?
> In v12 we eventually did come along and patch "s390/vfio-ap: allow hot
> plug/unplug of AP resources using mdev device" made this a part of a
> critical section protected by the matrix_dev->lock.
>
> IMHO the cleanup should definitely happen with the matrix_dev->lock held.
Agreed!
>
> Regards,
> Halil
next prev parent reply other threads:[~2020-12-03 19:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 23:41 [PATCH] s390/vfio-ap: Clean up vfio_ap resources when KVM pointer invalidated Tony Krowiak
2020-12-03 10:19 ` Cornelia Huck
2020-12-03 17:01 ` Halil Pasic
2020-12-03 19:14 ` Tony Krowiak [this message]
2020-12-03 17:55 ` Halil Pasic
2020-12-04 14:43 ` Tony Krowiak
2020-12-04 19:05 ` Halil Pasic
2020-12-04 19:46 ` Tony Krowiak
2020-12-04 21:54 ` Halil Pasic
2020-12-07 18:50 ` Tony Krowiak
2020-12-08 0:01 ` Halil Pasic
[not found] ` <e196b743-74d8-398b-4b3e-4a64002d9bfc@linux.ibm.com>
2020-12-13 22:57 ` Halil Pasic
2020-12-04 16:48 ` Tony Krowiak
2020-12-04 16:57 ` Cornelia Huck
2020-12-04 19:47 ` Tony Krowiak
2020-12-07 15:24 ` Halil Pasic
2020-12-07 15:42 ` Christian Borntraeger
2020-12-07 19:05 ` Tony Krowiak
2020-12-08 0:40 ` Halil Pasic
2020-12-11 21:08 ` Tony Krowiak
2020-12-13 23:13 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3299bd03-f0b8-39ac-4f0e-04bd198633fa@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.