From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 8 Aug 2018 22:23:33 +0200 Subject: [U-Boot] [PULL] u-boot-usb/master In-Reply-To: <20180727113928.GC7590@bill-the-cat> References: <5dfe7846-f4f2-d29e-a90b-e2e9fa558410@gmail.com> <20180726151451.GC11755@bill-the-cat> <9b6be5e8-dea1-cf6f-89b2-fcc325e62379@gmail.com> <20180726230811.734f6a62@jawa> <435ce2e6-7c5f-2ea0-3b18-a4678de90faf@gmail.com> <20180727115932.28a41261@jawa> <20180727113928.GC7590@bill-the-cat> Message-ID: <33f7f041-21d9-8a88-79db-53d3c1c469d7@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 07/27/2018 01:39 PM, Tom Rini wrote: > On Fri, Jul 27, 2018 at 11:59:32AM +0200, Lukasz Majewski wrote: >> On Thu, 26 Jul 2018 23:14:01 +0200 >> Marek Vasut wrote: >> >>> On 07/26/2018 11:08 PM, Lukasz Majewski wrote: >>>> On Thu, 26 Jul 2018 21:25:02 +0200 >>>> Marek Vasut wrote: >>>> >>>>> On 07/26/2018 05:14 PM, Tom Rini wrote: >>>>>> On Thu, Jul 26, 2018 at 09:35:54AM +0200, Marek Vasut wrote: >>>>>> >>>>>>> The following changes since commit >>>>>>> 323a73adc9a1bf2de43fe03bdd9c3038ce7c2784: >>>>>>> >>>>>>> mtd: nand: add new enum for storing ECC algorithm (2018-07-23 >>>>>>> 14:33:21 -0400) >>>>>>> >>>>>>> are available in the Git repository at: >>>>>>> >>>>>>> git://git.denx.de/u-boot-usb.git master >>>>>>> >>>>>>> for you to fetch changes up to >>>>>>> 67f1c59f40fde73cb2cbb51ebf0a05156ec403b7: >>>>>>> >>>>>>> usb: dwc3: convert to livetree (2018-07-25 00:13:44 +0200) >>>>>>> >>>>>> >>>>>> NAK. This breaks at least: am335x_hs_evm am335x_hs_evm_uart >>>>>> brppt1_spi brppt1_mmc am335x_evm brppt1_nand and stih410-b2260 >>>>> >>>>> CCing the authors, I expect a patch. >>>>> >>>> >>>> Could you share how and where it breaks? >>>> >>>> I did standard Travis-CI build test on DFU PR. >>> >>> I agree it'd be helpful if Tom shared more information than just >>> "NAK", yes. Then again, did you try building one of those targets ? >>> >> >> I did the Travis-CI run during the night of Marek's u-boot-usb branch. > > When I pull -usb right now I see: > Testing /tmp/am335x_hs_evm_uart > Fri Jul 27 07:38:02 EDT 2018 > WARNING: no status info for 'pico-pi-imx7d' > WARNING: no maintainers for 'pico-pi-imx7d' > Building current source for 1 boards (1 thread, 16 jobs per thread) > arm: + am335x_hs_evm_uart > +(am335x_hs_evm_uart) drivers/usb/musb-new/ti-musb.c: In function 'ti_musb_wrapper_bind': > +(am335x_hs_evm_uart) drivers/usb/musb-new/ti-musb.c:221:29: error: incompatible type for argument 1 of 'usb_get_dr_mode' > +(am335x_hs_evm_uart) dr_mode = usb_get_dr_mode(node); > +(am335x_hs_evm_uart) ^~~~ > +(am335x_hs_evm_uart) In file included from drivers/usb/musb-new/ti-musb.c:12:0: > +(am335x_hs_evm_uart) include/linux/usb/otg.h:28:18: note: expected 'ofnode {aka union ofnode_union}' but argument is of type 'int' > +(am335x_hs_evm_uart) enum usb_dr_mode usb_get_dr_mode(ofnode node); > +(am335x_hs_evm_uart) ^~~~~~~~~~~~~~~ > +(am335x_hs_evm_uart) make[2]: *** [drivers/usb/musb-new/ti-musb.o] Error 1 > +(am335x_hs_evm_uart) make[1]: *** [drivers/usb/musb-new] Error 2 > +(am335x_hs_evm_uart) make: *** [sub-make] Error 2 > 0 0 1 /1 am335x_hs_evm_uart > Seems this is broken because of the patch from Vipul , and while we all scramble to get this fixed, there is zero activity from Xilinx. So I'll just drop that patch and resubmit the PR. It's a real disappointment... -- Best regards, Marek Vasut