From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1689C2D0A3 for ; Mon, 26 Oct 2020 09:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CB7722242 for ; Mon, 26 Oct 2020 09:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="MZcJ0J/f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1772577AbgJZJHF (ORCPT ); Mon, 26 Oct 2020 05:07:05 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:54357 "EHLO mail-wm1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1747015AbgJZJG7 (ORCPT ); Mon, 26 Oct 2020 05:06:59 -0400 Received: by mail-wm1-f46.google.com with SMTP id w23so9714992wmi.4 for ; Mon, 26 Oct 2020 02:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2H9Y4JmiHcK3j+qZ0aFUfBDG3AKu1KtGzluos1f8AIA=; b=MZcJ0J/fr058lVbFMWmXM92OuD9yOOuBGnXm3mH9s+Q+qvXuLJ1AMk++0cJYjL8/8O O3IJehgooJ4RrhhzQO+E0kIuBzm4OwHBdxA8UbvcYVkZ7U2D4ZBSnEu9yGWalJ0k4cnx UvsrfG5qIj0S9cjO324WDWRqyW/EdovKxkL9o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2H9Y4JmiHcK3j+qZ0aFUfBDG3AKu1KtGzluos1f8AIA=; b=ZJPgMrUE5PN3Pl5rBD3sD1FFV8FJVeh3rEh4bnTxABKpiRm9RjazBICxahURDJqphQ psG4hOsAnc3yMbDB9yAZpOzL+6IXSJJWdCLvOtmGiD51VA4rgWWADSMA6W3Obi8Rv+Z1 6bY1Z6lfioYmaHGvrbbkzRz5spe9bds9mAW/XdsAKNKfK+i6DpDn/MivqXD2ZD7756Eo rcofQDrQUVmJzdiU3yYyz+GGgmOvUna7MDiZYO32bcnNwAe6oMwxNcNJlRnFCUO/cTol rrU9IkZK4OBc6vVZybCXkZYROL3vVo7m6XAwR1X5lgludZxofJEYOHOQX18Q0f4kKlga VMtA== X-Gm-Message-State: AOAM531FSvyaipKPyV2nRaQq/AeR/3WjmnGjAOu/GYEe/aPfINaXLP1O au2oRWGv2FH/NqEhDxgPu+M7Cg== X-Google-Smtp-Source: ABdhPJz/dSh4WYOhOiSM/B+RWa4o7p1CXRC3GSQeuPYc6Si2kr9wemYErENZN/vvuGa/ZdX08vCt1g== X-Received: by 2002:a1c:417:: with SMTP id 23mr14851965wme.1.1603703216102; Mon, 26 Oct 2020 02:06:56 -0700 (PDT) Received: from [172.16.11.132] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id f5sm19077441wmh.16.2020.10.26.02.06.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 02:06:55 -0700 (PDT) Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt To: Marc Zyngier , Biwen Li Cc: shawnguo@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, zhiqiang.hou@nxp.com, tglx@linutronix.de, jason@lakedaemon.net, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com, linux-arm-kernel@lists.infradead.org, Biwen Li References: <20201026080127.40499-1-biwen.li@oss.nxp.com> <31d8971374c261003aee9f4807c8ac8c@kernel.org> From: Rasmus Villemoes Message-ID: <3448c822-31b1-7f9d-fedf-49912418fc3f@rasmusvillemoes.dk> Date: Mon, 26 Oct 2020 10:06:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <31d8971374c261003aee9f4807c8ac8c@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/10/2020 09.44, Marc Zyngier wrote: > On 2020-10-26 08:01, Biwen Li wrote: >> From: Hou Zhiqiang >> >> Add an new IRQ chip declaration for LS1043A and LS1088A >> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A >> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA > > Three things: > - This commit message doesn't describe the bit_reverse change Yeah, please elaborate on that, as the RM for 1043 or 1046 doesn't mention anything about bit reversal for the scfg registers - they don't seem to have the utter nonsense that is SCFG_SCFGREVCR, but perhaps, instead of removing it, that has just become a hard-coded part of the IP. Also, IANAL etc., but >> +// Copyright 2019-2020 NXP really? Seems to be a bit of a stretch. At the very least, cc'ing the original author and only person to ever touch that file would have been appreciated. Rasmus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0714C2D0A3 for ; Mon, 26 Oct 2020 09:08:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 675C7223AB for ; Mon, 26 Oct 2020 09:08:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UulUu/+R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=rasmusvillemoes.dk header.i=@rasmusvillemoes.dk header.b="MZcJ0J/f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 675C7223AB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rasmusvillemoes.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qRihXfwOPywiF5e2FAeJyJHgDL4zPCrxQp5oNbZRbdU=; b=UulUu/+R5NuJ8nqayqJwSaWvV 5aENK5iKGTQRipxmvAtt07qRq7YgfUSQbN4deGHHz5Ep8lji4m1lODhMkGABdd34Fz1WKayigT5Ho CKHyo1GUNGH1zUOfEFwamHn7vy9yI8kj2GBC3baEny86fnTYatXEnK8NG4oN60H7D5l4V6u8TT99H 6b5nnwxitRApFnF1BNHk24iuZ+Kgfh23dVg52yql9uV+feVEb1pydRFTt9JPneVmNo5YiyNxjyNaa QAxNt2fAMq2VuzYZVJs47Ma4nf0QP0hYef4Ld1LDo2fDjHLPvDZ/8SNZNu/oEDL+6QJXir6G1O0BZ lmzq6ZkYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWyT0-0006s2-1G; Mon, 26 Oct 2020 09:07:02 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kWySx-0006qy-Ac for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2020 09:07:00 +0000 Received: by mail-wm1-x334.google.com with SMTP id c16so11627304wmd.2 for ; Mon, 26 Oct 2020 02:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2H9Y4JmiHcK3j+qZ0aFUfBDG3AKu1KtGzluos1f8AIA=; b=MZcJ0J/fr058lVbFMWmXM92OuD9yOOuBGnXm3mH9s+Q+qvXuLJ1AMk++0cJYjL8/8O O3IJehgooJ4RrhhzQO+E0kIuBzm4OwHBdxA8UbvcYVkZ7U2D4ZBSnEu9yGWalJ0k4cnx UvsrfG5qIj0S9cjO324WDWRqyW/EdovKxkL9o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2H9Y4JmiHcK3j+qZ0aFUfBDG3AKu1KtGzluos1f8AIA=; b=UK01haG3X/bNVGUo4wVfOp6Yl1Q0jJ2P5fGJwcrKdLzjV1Gy39+z86/Kb7vX0XJEdS PgO+7PGL5/u3fagWHXvp5fCoZ7TdWNf5xIR2eYAHo5t1y9i/Ziye8UT7CWpif6oyu5yd o5/nTnQP9JUe4PopbzCcS9GV1WrJH2DuwqbL7lPm1lpFyTtQEyS/2QpH1fRQXIYUrjgf dkyuutTnYGAzNPplLb+U9zzaMk3wtHLucQZtNSlL1PEhenJZudSxbeQ8FLwHexoFbCFC 7uBz6sBFSRZtdNyHU3SwWksrD06Y9U2jxJaq7Mj4keIus8BJClDf3s/guxDP1pKFfw/c bV6A== X-Gm-Message-State: AOAM5334DNcWmCRZgJU5w9pqQB7W+5hxeWpv1VVZ7lih8zaEOhDCTYYA i8jYutuKA/pdPkEcPSh4nZNW1A== X-Google-Smtp-Source: ABdhPJz/dSh4WYOhOiSM/B+RWa4o7p1CXRC3GSQeuPYc6Si2kr9wemYErENZN/vvuGa/ZdX08vCt1g== X-Received: by 2002:a1c:417:: with SMTP id 23mr14851965wme.1.1603703216102; Mon, 26 Oct 2020 02:06:56 -0700 (PDT) Received: from [172.16.11.132] ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id f5sm19077441wmh.16.2020.10.26.02.06.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 02:06:55 -0700 (PDT) Subject: Re: [RESEND 01/11] irqchip: ls-extirq: Add LS1043A, LS1088A external interrupt To: Marc Zyngier , Biwen Li References: <20201026080127.40499-1-biwen.li@oss.nxp.com> <31d8971374c261003aee9f4807c8ac8c@kernel.org> From: Rasmus Villemoes Message-ID: <3448c822-31b1-7f9d-fedf-49912418fc3f@rasmusvillemoes.dk> Date: Mon, 26 Oct 2020 10:06:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <31d8971374c261003aee9f4807c8ac8c@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201026_050659_527627_36A1514C X-CRM114-Status: GOOD ( 12.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jason@lakedaemon.net, Biwen Li , zhiqiang.hou@nxp.com, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, shawnguo@kernel.org, jiafei.pan@nxp.com, xiaobo.xie@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/10/2020 09.44, Marc Zyngier wrote: > On 2020-10-26 08:01, Biwen Li wrote: >> From: Hou Zhiqiang >> >> Add an new IRQ chip declaration for LS1043A and LS1088A >> - compatible "fsl,ls1043a-extirq" for LS1043A, LS1046A >> - compatible "fsl,ls1088a-extirq" for LS1088A, LS208xA, LX216xA > > Three things: > - This commit message doesn't describe the bit_reverse change Yeah, please elaborate on that, as the RM for 1043 or 1046 doesn't mention anything about bit reversal for the scfg registers - they don't seem to have the utter nonsense that is SCFG_SCFGREVCR, but perhaps, instead of removing it, that has just become a hard-coded part of the IP. Also, IANAL etc., but >> +// Copyright 2019-2020 NXP really? Seems to be a bit of a stretch. At the very least, cc'ing the original author and only person to ever touch that file would have been appreciated. Rasmus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel