From: "Kumar, Abhay" <abhay.kumar@intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
"Syrjala, Ville" <ville.syrjala@intel.com>
Subject: Re: [PATCH v3] drm/i915: set minimum CD clock to twice the BCLK.
Date: Tue, 17 Apr 2018 12:17:48 -0700 [thread overview]
Message-ID: <347beb22-90a3-911c-bd41-d99fc7ed4c6d@intel.com> (raw)
In-Reply-To: <1523991974-15597-1-git-send-email-abhay.kumar@intel.com>
On 4/17/2018 12:06 PM, Abhay Kumar wrote:
> In glk when device boots with only 1366x768 panel, HDA codec doesn't comeup.
> This result in no audio forever as cdclk is < 96Mhz.
> This change will ensure CD clock to be twice of BCLK.
>
> v2:
> - Address comment (Jani)
> - New design approach
> v3: - Typo fix on top of v1
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102937
> Signed-off-by: Abhay Kumar <abhay.kumar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_cdclk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_cdclk.c b/drivers/gpu/drm/i915/intel_cdclk.c
> index dc7db8a2caf8..6e93af4a46ea 100644
> --- a/drivers/gpu/drm/i915/intel_cdclk.c
> +++ b/drivers/gpu/drm/i915/intel_cdclk.c
> @@ -2143,7 +2143,7 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)
> /* According to BSpec, "The CD clock frequency must be at least twice
> * the frequency of the Azalia BCLK." and BCLK is 96 MHz by default.
> */
> - if (crtc_state->has_audio && INTEL_GEN(dev_priv) >= 9)
> + if (INTEL_GEN(dev_priv) >= 9)
> min_cdclk = max(2 * 96000, min_cdclk);
>
> /*
Hi Ville, Jani,
Since right version of this patch is taking time(doing modeset and
cdclk bump) as we need to poke sound driver. Can we please get this
v3(same as v1 with typo fix in comment) version of patch merged.
This works all the time and will unblock Audio and lot of folks. without
this patch audio card is not getting detected at all and blocking basic
audio feature.
Regards,
Abhay
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-04-17 19:17 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 22:02 [PATCH] drm/i915: set minimum CD clock to twice the BCLK abhay.kumar
2017-10-25 22:26 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-10-26 4:03 ` [PATCH] " Dhinakaran Pandiyan
2017-10-26 8:45 ` Jani Nikula
2017-10-26 19:10 ` Kumar, Abhay
2017-10-29 3:04 ` Kumar, Abhay
2017-10-31 0:21 ` Pandiyan, Dhinakaran
2017-10-31 23:43 ` Kumar, Abhay
2017-11-01 9:40 ` Jani Nikula
2017-11-03 3:54 ` Prusty, Subhransu S
2017-11-03 4:13 ` Prusty, Subhransu S
2018-02-14 17:59 ` Jani Nikula
[not found] ` <A49308764D41694491D5AFB53AB2F16D70A5CBD8@ORSMSX114.amr.corp.intel.com>
2018-03-23 19:33 ` FW: " Kumar, Abhay
2018-04-05 18:40 ` [PATCH v2] " Abhay Kumar
2018-04-06 7:21 ` kbuild test robot
2018-04-05 19:02 ` ✗ Fi.CI.BAT: failure for drm/i915: set minimum CD clock to twice the BCLK. (rev2) Patchwork
2018-04-05 20:37 ` [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK Abhay Kumar
2018-04-06 13:47 ` Jani Nikula
2018-04-09 10:33 ` Ville Syrjälä
2018-04-09 22:11 ` Kumar, Abhay
2018-04-10 8:01 ` Jani Nikula
2018-04-10 8:49 ` Jani Nikula
2018-04-11 3:00 ` Kumar, Abhay
2018-04-17 19:06 ` [PATCH v3] " Abhay Kumar
2018-04-17 19:17 ` Kumar, Abhay [this message]
2018-04-17 19:28 ` Du,Wenkai
2018-04-18 10:49 ` Jani Nikula
2018-04-18 15:41 ` Ville Syrjälä
2018-04-19 1:19 ` Kumar, Abhay
2018-04-05 21:55 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: set minimum CD clock to twice the BCLK. (rev3) Patchwork
2018-04-05 22:10 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-06 0:38 ` ✗ Fi.CI.IGT: failure " Patchwork
2018-04-17 19:22 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: set minimum CD clock to twice the BCLK. (rev4) Patchwork
2018-04-17 19:22 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-04-17 19:31 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-17 19:48 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-18 10:24 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2018-04-18 10:24 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-04-18 10:40 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-18 11:07 ` ✗ Fi.CI.CHECKPATCH: warning " Patchwork
2018-04-18 11:07 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-04-18 11:23 ` ✓ Fi.CI.BAT: success " Patchwork
2018-04-18 12:25 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-18 13:01 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=347beb22-90a3-911c-bd41-d99fc7ed4c6d@intel.com \
--to=abhay.kumar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.