From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 01/12] Ext4: Fix extended timestamp encoding and decoding Date: Tue, 24 Nov 2015 21:10:53 +0100 Message-ID: <3495329.crWmoA5ACn@wuerfel> References: <20151120145422.18930.72662.stgit@warthog.procyon.org.uk> <20151120145434.18930.89755.stgit@warthog.procyon.org.uk> <20151124193646.GA3482@thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: David Howells , linux-afs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Theodore Ts'o Return-path: In-Reply-To: <20151124193646.GA3482-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: On Tuesday 24 November 2015 14:36:46 Theodore Ts'o wrote: > This is the patch I would prefer to use (and in fact which I have > added to the ext4 tree): > > There are issues with 32-bit vs 64-bit encoding of times before > January 1, 1970, which are handled with this patch which is not > handled with what you have in your patch series. So I'd prefer if you > drop this patch, and I'll get this sent to Linus as a bug fix for 4.4. I'm happy with either one. Apparently both Davids have arrived with almost the same algorithm and implementation, with the exception of the pre-1970 handling you mention there. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932066AbbKXULK (ORCPT ); Tue, 24 Nov 2015 15:11:10 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:58462 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842AbbKXULE (ORCPT ); Tue, 24 Nov 2015 15:11:04 -0500 From: Arnd Bergmann To: "Theodore Ts'o" Cc: David Howells , linux-afs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 01/12] Ext4: Fix extended timestamp encoding and decoding Date: Tue, 24 Nov 2015 21:10:53 +0100 Message-ID: <3495329.crWmoA5ACn@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151124193646.GA3482@thunk.org> References: <20151120145422.18930.72662.stgit@warthog.procyon.org.uk> <20151120145434.18930.89755.stgit@warthog.procyon.org.uk> <20151124193646.GA3482@thunk.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:MZIkcIFpvURivKtmHwF+PZDyA4hWhe2SQYZU4fhDObPz937682q lAS2w6aRQ2UTD0aPOZWFqlszuU2Eu21wTSVGDLmX5tOwKj3ndrj5W51l/0poas400dXsVvq MvnyVyZY9HrJpOo5duWpXnkG3dmDYv4vdfrcoU0I0tfoqOaDqKO8tqA9j8Na9X2JZHGMqaH e9xKUBiWS6FlKfu+gHcOw== X-UI-Out-Filterresults: notjunk:1;V01:K0:7qqFN58SdYk=:nDBc0HsFvfDNVsSskXeMK/ Zgw771Ebbb6kcJz4kPS52qTr4kldWxwc1QwzJQLJeo9PC168bWhFBj56/c9TOMbnJYy31Fg6+ fsXxtEnCrDGGE6JMwU8pHm3QUB+zePphTMkItXsPckv31twbp9v2tp9NMmkXDCaRpIM80AYaz ooEAzwP9gFs7aZSTuwxk/v9kRLReSeXlM3mr9rXsAYREYd7plvvPs7xeFPJO8DTV5xJ0bvW0n EnFkfJ0Ysz8N55JnHHN+BIhZ2cGXY2Ju48igGTQrr4wOaDkSBGiHlrJ/nZQwlVKZDEJ2JfK07 vhUVS/uYFtvEtCk2n1oe/RO5kvQmEKGOx0xZLKC4fTNhoKgqeRLyO/SEhSpkDhV/tTHKPfWK0 rFJlqi6Bo9c5EwDmflPtqS/SzolHTc7EM0VFHE1MibDjg2ZpwI05PUdxxlbiRl3ruEt8aa0sx IeqPWt1Kq9UnyqCTXQYONaZMw0OfiVLiqLVuOCX/gE5VEwVgvIhQvJyzKot5fLh3sJnALdoJM rKh3yntVdB9S9BRvgRdnOJYldzssQLyhR5nGsVqySp3vb+Hf7dYRslJOwlIWadbvil3cvz3P9 LfXrbypQdJf71iptPHYA/21q954UFi7cYeFd93Oi3B3tsoC9qvOuQ1EN290DLM+0apOVjkuAV 1ZaA9xBdhCEuyWtcuEEex62ZGO0zVVZIIG3HX7DuNUzl927K2+HI1tpU1WnbFQVDT6MZydJP0 21MwiT+w4mwAaQ5V Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 24 November 2015 14:36:46 Theodore Ts'o wrote: > This is the patch I would prefer to use (and in fact which I have > added to the ext4 tree): > > There are issues with 32-bit vs 64-bit encoding of times before > January 1, 1970, which are handled with this patch which is not > handled with what you have in your patch series. So I'd prefer if you > drop this patch, and I'll get this sent to Linus as a bug fix for 4.4. I'm happy with either one. Apparently both Davids have arrived with almost the same algorithm and implementation, with the exception of the pre-1970 handling you mention there. Arnd