From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751941AbdHANgL (ORCPT ); Tue, 1 Aug 2017 09:36:11 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:29432 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbdHANgI (ORCPT ); Tue, 1 Aug 2017 09:36:08 -0400 X-AuditID: b6c32a39-f794a6d0000049f6-50-598083c439c7 From: Bartlomiej Zolnierkiewicz To: Greg KH Cc: Michal Januszewski , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage Date: Tue, 01 Aug 2017 15:36:01 +0200 Message-id: <3613878.J9SAsAfrTp@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170719125119.GB17776@kroah.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsWy7bCmru6R5oZIg87bVhbNi9ezWZzo+8Bq cXnXHDaLKR+PMzuweFz+/obZY//cNewenzfJBTBHcdmkpOZklqUW6dslcGV8Wl5XcJOt4u/9 6UwNjIdZuxg5OCQETCSuHJfuYuQEMsUkLtxbz9bFyMUhJLCDUWLDiW/sEM5nRonG2RPZIaqA GqZ+Q6h6+O86K4TzlVFi+ZFvTCBVbAJWEhPbVzGC2CICGhIvj95iAbGZBdIkOtd/B1stLGAv sf2gDEiYRUBVYtP6pWwgNq+ApsSB+aeZQWxRAS+JLfvawUZyCuhL/PvQB1UjKPFj8j2okfIS +/ZPZYWwdSTOHlvHCHKPhMB/NonXf/awQLwpK7HpADPEAy4SzVO3QD0jLPHqOIwtJdH48iET hD2dUWL7bwmIOZsZJVbtngBVZC1x+PhFqGV8Eu++9kCDkVeio00IwvSQuPNPEqLaUeLbjgmM kOBpYpT4u6CTZQKj/CwkL8xC8sIsJC8sYGRexSiWWlCcm55abFhgqlecmFtcmpeul5yfu4kR nBy0LHcwHjvnc4hRgINRiYe3w7Q+Uog1say4MvcQowQHs5IIb1VZQ6QQb0piZVVqUX58UWlO avEhRmkOFiVxXtH11yKEBNITS1KzU1MLUotgskwcnFINjN32cyc/XSi8gfXrhNmf/y7Z2Nr/ 9eS3juoHnU+009xs85O1z0c3TLL+Nl9c9N7N7m+BFo339GZp86tE1FU9Pvr6d5pV6uXSHXcP PUz+M/VbrdOpCylis9iMYn0eTatVn5Z353Sc1orbe4Rzl7v+X5JX8K+BfbPoLjtfFanTp5+k 3Rbb5/Rv7RolluKMREMt5qLiRABxaJEbCgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJIsWRmVeSWpSXmKPExsVy+t9jAd3DzQ2RBteadCyaF69nszjR94HV 4vKuOWwWUz4eZ3Zg8bj8/Q2zx/65a9g9Pm+SC2COcrPJSE1MSS1SSM1Lzk/JzEu3VQoNcdO1 UFLIS8xNtVWK0PUNCVJSKEvMKQXyjAzQgINzgHuwkr5dglvGp+V1BTfZKv7en87UwHiYtYuR k0NCwETiytRvbBC2mMSFe+uBbC4OIYFtjBLnPj9ihnC+Mkqs+XqNCaSKTcBKYmL7KkYQW0RA Q+Ll0VssIDazQJrErHlHgaZycAgL2EtsPygDEmYRUJXYtH4p2AJeAU2JA/NPM4PYogJeElv2 tYON5BTQl/j3oQ9qcQujxLV9OxkhGgQlfky+BzVfXmLf/qmsELaWxPqdx5kmMArMQlI2C0nZ LCRlCxiZVzGKpRYU56bnFhsVGOoVJ+YWl+al6yXn525iBEbLtsNa/jsYf5yNPsQowMGoxMPb IdYQKcSaWFZcmXuIUYKDWUmEt6oMKMSbklhZlVqUH19UmpNafIjRFOi/icxSosn5wEjOK4k3 NLE0MjEwMzM0MjA2UxLnnRD4JUJIID2xJDU7NbUgtQimj4mDU6qBcd9fH424PW0CUbbZ/P9n ZG7coiO58fzD9f+32zH9u/0z/k9l0EH+jbJ3vI54/H0fMG/hs6felsabfme9m56jXJx+VCFw ac/NNfKvZ7pnmFx5zX3v5tV9nzzKvws98fpsumxD+I296hOvnhOpXrkzQPbyfP3qmNMpTSEl N/mN7mlyf2bcV5TCwqHEUpyRaKjFXFScCADN81cfrAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170801133603epcas1p452c3818a35e903f8247979aaff6ac34b X-Msg-Generator: CA X-Sender-IP: 182.195.42.79 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170719125131epcas5p4fed9dd550f3b19744e793831a9a2b1db X-RootMTR: 20170719125131epcas5p4fed9dd550f3b19744e793831a9a2b1db References: <20170719125119.GB17776@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, July 19, 2017 02:51:19 PM Greg KH wrote: > From: Greg Kroah-Hartman > > It's better to be explicit and use the DRIVER_ATTR_RW() macro when > defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl > warning. > > This is part of a series to drop DRIVER_ATTR() from the tree entirely. > > Cc: Michal Januszewski > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by: Greg Kroah-Hartman Acked-by: Bartlomiej Zolnierkiewicz I assume that this will go through your tree with other DRIVER_ATTR() removal patches (please ping me if you want me to merge this patch through fbdev tree). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Tue, 01 Aug 2017 13:36:01 +0000 Subject: Re: [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage Message-Id: <3613878.J9SAsAfrTp@amdc3058> List-Id: References: <20170719125119.GB17776@kroah.com> In-Reply-To: <20170719125119.GB17776@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Greg KH Cc: Michal Januszewski , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Wednesday, July 19, 2017 02:51:19 PM Greg KH wrote: > From: Greg Kroah-Hartman > > It's better to be explicit and use the DRIVER_ATTR_RW() macro when > defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl > warning. > > This is part of a series to drop DRIVER_ATTR() from the tree entirely. > > Cc: Michal Januszewski > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by: Greg Kroah-Hartman Acked-by: Bartlomiej Zolnierkiewicz I assume that this will go through your tree with other DRIVER_ATTR() removal patches (please ping me if you want me to merge this patch through fbdev tree). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics