All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Bin Meng" <bmeng.cn@gmail.com>
Cc: Bin Meng <bin.meng@windriver.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Qemu-block <qemu-block@nongnu.org>
Subject: Re: [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument
Date: Wed, 23 Jun 2021 10:57:26 +0200	[thread overview]
Message-ID: <3648c80c-f5b2-f2d4-cab6-4983a8a6db69@kaod.org> (raw)
In-Reply-To: <efa3958c-8a08-76f3-a963-8424c660e4e5@amsat.org>

On 6/23/21 10:52 AM, Philippe Mathieu-Daudé wrote:
> On 6/23/21 10:39 AM, Bin Meng wrote:
>> On Wed, Jun 23, 2021 at 4:30 PM Cédric Le Goater <clg@kaod.org> wrote:
>>>
>>> The number of blocks is defined in the lower bits [15:0]
>>
>> I checked the physical spec v8.00 and it says bits [31:0] for CMD23 argument.
> 
> Watch out, we only support 1-3:
> 
> enum SDPhySpecificationVersion {
>     SD_PHY_SPECv1_10_VERS     = 1,
>     SD_PHY_SPECv2_00_VERS     = 2,
>     SD_PHY_SPECv3_01_VERS     = 3,
> };
> 

Yes. block count was increased to 32-bit in v4 if I am correct. 

Any how, it is a bit more complex than the patch I sent which is fixing 
an issue I saw with eMMC.

Thanks,

C. 


  reply	other threads:[~2021-06-23  8:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23  8:30 [PATCH] sd: mmc: Fix SET_BLOCK_COUNT command argument Cédric Le Goater
2021-06-23  8:39 ` Bin Meng
2021-06-23  8:52   ` Philippe Mathieu-Daudé
2021-06-23  8:57     ` Cédric Le Goater [this message]
2021-06-23  9:11     ` Bin Meng
2021-06-23 11:01       ` Philippe Mathieu-Daudé
2021-06-23  8:55   ` Cédric Le Goater
2021-06-23  9:12     ` Bin Meng
2021-06-23  9:16       ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3648c80c-f5b2-f2d4-cab6-4983a8a6db69@kaod.org \
    --to=clg@kaod.org \
    --cc=bin.meng@windriver.com \
    --cc=bmeng.cn@gmail.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.