All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harish Chegondi <harish.chegondi@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: clinton.a.taylor@intel.com, jyoti.r.yadav@intel.com
Subject: [igt-dev] [RFC i-g-t 1/1] i915/pm_backlight: turn on dpms before backlight fade out and fade in
Date: Wed, 13 Mar 2019 23:41:48 -0700	[thread overview]
Message-ID: <36a00595c5083adb40d496ff30ebc820ae770474.1552545177.git.harish.chegondi@intel.com> (raw)

backlight fade with suspend test turns off dpms which turns off
the edp backlight and panel. Then it does a runtime suspend,
system suspend and resume. After resume, it does a fade out and
fade in of the backlight brightness. From the dmesg logs of the
ci tests it appears that the test is setting the brightness
even before the edp panel and backlight are turned on resuilting
in the brightness values written and read to be different.
Turn on the dpms which turns on the edp panel and backlight
before backlight fade out and fade in. With this change the
fade_with_suspend test passes.

Cc: Jyoti Yadav <jyoti.r.yadav@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Clinton Taylor <clinton.a.taylor@intel.com>
Signed-off-by: Harish Chegondi <harish.chegondi@intel.com>
References: https://bugs.freedesktop.org/show_bug.cgi?id=107820
---
 tests/i915/i915_pm_backlight.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/i915/i915_pm_backlight.c b/tests/i915/i915_pm_backlight.c
index 054300f6..ca640eca 100644
--- a/tests/i915/i915_pm_backlight.c
+++ b/tests/i915/i915_pm_backlight.c
@@ -184,6 +184,9 @@ test_fade_with_suspend(struct context *context, igt_output_t *output)
 
 	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
 
+	kmstest_set_connector_dpms(output->display->drm_fd,
+				   output->config.connector,
+				   DRM_MODE_DPMS_ON);
 	test_fade(context);
 }
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2019-03-14  6:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14  6:41 Harish Chegondi [this message]
2019-03-14  7:25 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [RFC,i-g-t,1/1] i915/pm_backlight: turn on dpms before backlight fade out and fade in Patchwork
2019-03-14  7:46 ` [igt-dev] [RFC i-g-t 1/1] " Chris Wilson
2019-04-03  0:47   ` Chegondi, Harish
2019-04-03  7:44     ` Chris Wilson
2019-04-03 14:34       ` Daniel Vetter
2019-04-03 16:10         ` Daniel Vetter
2019-04-03 17:44           ` Chegondi, Harish
2019-03-14 15:23 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [RFC,i-g-t,1/1] " Patchwork
2019-04-04  1:26 ` [igt-dev] [PATCH v2 1/1] i915/pm_backlight: Do not turn off DPMS before system suspend Harish Chegondi
2019-04-04  8:12   ` Daniel Vetter
2019-04-05  0:35     ` Chegondi, Harish
2019-04-04 22:40   ` Souza, Jose
2019-04-04  3:06 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/1] i915/pm_backlight: Do not turn off DPMS before system suspend (rev2) Patchwork
2019-04-04 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36a00595c5083adb40d496ff30ebc820ae770474.1552545177.git.harish.chegondi@intel.com \
    --to=harish.chegondi@intel.com \
    --cc=clinton.a.taylor@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jyoti.r.yadav@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.