From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 070D7C433FE for ; Thu, 16 Sep 2021 15:08:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADD2B61108 for ; Thu, 16 Sep 2021 15:08:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ADD2B61108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQt02-0004zT-Rd for qemu-devel@archiver.kernel.org; Thu, 16 Sep 2021 11:08:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQswt-0002Bn-Cm for qemu-devel@nongnu.org; Thu, 16 Sep 2021 11:05:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:21889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQswr-00066h-2S for qemu-devel@nongnu.org; Thu, 16 Sep 2021 11:05:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631804711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0M8Sgca0e37jqgJMJ8AkaM6yKeG7axVQ+CQ9bcURP4=; b=BQGwwT2Ze79WxFnOGkjd2pSIi6evYkCe12pXniP7OGlJg6PgoMdFoDAPqXyjSmjg2AozPl giyqftZzDvFxwEPDGggTu5lq4eepeQQe4DTltCJNP4Ow0EX4lPQnOAyz2ZHMMyJevE2PWY n4+qdzXYfoYx5txcQB7eXCHew0L7PFs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-u4vqBJJuOb6yHFApt_FaEg-1; Thu, 16 Sep 2021 11:05:10 -0400 X-MC-Unique: u4vqBJJuOb6yHFApt_FaEg-1 Received: by mail-wm1-f70.google.com with SMTP id z26-20020a1c4c1a000000b00300ec9d8d77so1313563wmf.5 for ; Thu, 16 Sep 2021 08:05:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=T0M8Sgca0e37jqgJMJ8AkaM6yKeG7axVQ+CQ9bcURP4=; b=t7TFj5J7+Yqc8yW69LrdcLgxd8gREcarVPCQ1gCIdS/tzEYs8MN75F4Xa9RWMSjGSs ICbh6Xxckt8eEkn78gnaRLAHZuYqb4pIR9Bq25+i592aVxdJAUHAONWulveFE0QueuS2 iZAkNz5PqZBxMw/igNk522nXD48oPgT6rmZ8rqYNx+zJzPNQHAJIgCWrauF/agjym6Ko 9uBKrhBCN4iVxrjqeUC8IodJVQ9QLzg5ANMJymEIOlaNQPhAt1raxaUpX4UWvupo5ic4 rSCzaA0i6gkKg5eiSfPubu8LKAzkbWBqbUHe7t1lkQE9Jy6ch0S6J1Yr853fEacNDuY6 IVrQ== X-Gm-Message-State: AOAM533C1KFLiAR2m+UMzzxd/wGW28Zhz8jDwtES8RKHW55/mnq2qbaK mTOlq7GrE0b8cJvjo80f1pf5ekBSIydaa18SXJSDUBSGWxafajkN3yfXigAZqxl1eH7E4pDm19i niZLLag0MtAd7UZg= X-Received: by 2002:adf:d1c4:: with SMTP id b4mr3967904wrd.233.1631804709077; Thu, 16 Sep 2021 08:05:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlaLIdYl7Z8ObP6Qcrr62jh73iYA6Zy3mfjl3rEwt43VS84CzyBPqU9W1sXBFB6Acxetymvg== X-Received: by 2002:adf:d1c4:: with SMTP id b4mr3967866wrd.233.1631804708844; Thu, 16 Sep 2021 08:05:08 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id o24sm7560945wmm.11.2021.09.16.08.05.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 08:05:08 -0700 (PDT) Subject: Re: [PATCH v3 02/16] iotests/mirror-top-perms: Adjust imports To: John Snow References: <20210916040955.628560-1-jsnow@redhat.com> <20210916040955.628560-3-jsnow@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <39a8cd4b-7188-4f03-862f-7a26000d6b8f@redhat.com> Date: Thu, 16 Sep 2021 17:05:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -46 X-Spam_score: -4.7 X-Spam_bar: ---- X-Spam_report: (-4.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.488, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , Eduardo Habkost , qemu-block@nongnu.org, Markus Armbruster , qemu-devel , Hanna Reitz , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/16/21 4:27 PM, John Snow wrote: > On Thu, Sep 16, 2021 at 12:27 AM Philippe Mathieu-Daudé > > wrote: > > On 9/16/21 6:09 AM, John Snow wrote: > > We need to import things from the qemu namespace; importing the > > namespace alone doesn't bring the submodules with it -- unless someone > > else (like iotests.py) imports them too. > > > > Adjust the imports. > > > > Signed-off-by: John Snow > > > --- > >  tests/qemu-iotests/tests/mirror-top-perms | 7 ++++--- > >  1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/tests/qemu-iotests/tests/mirror-top-perms > b/tests/qemu-iotests/tests/mirror-top-perms > > index 2fc8dd66e0..de18182590 100755 > > --- a/tests/qemu-iotests/tests/mirror-top-perms > > +++ b/tests/qemu-iotests/tests/mirror-top-perms > > @@ -25,7 +25,8 @@ from iotests import qemu_img > >  > >  # Import qemu after iotests.py has amended sys.path > >  # pylint: disable=wrong-import-order > > -import qemu > > +from qemu import qmp > > +from qemu.machine import machine > > Not straight-forward import name... > > > You mean the 'qemu.machine.machine' path? If so, I agree. It will be > fixed when I refactor QEMUMachine. A/QMP happens first. Good news!