From: Martin Schiller <ms@dev.tdt.de>
To: Xie He <xie.he.0141@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Andrew Hendry <andrew.hendry@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Linux X25 <linux-x25@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/5] net/lapb: support netdev events
Date: Tue, 24 Nov 2020 06:29:44 +0100 [thread overview]
Message-ID: <39b6386b4ce7462f6cb4448020735ed5@dev.tdt.de> (raw)
In-Reply-To: <CAJht_EOA4+DSjnKYZX3udrXX9jGHRmFw3OQesUb3AncD2oowwA@mail.gmail.com>
On 2020-11-23 23:09, Xie He wrote:
> On Mon, Nov 23, 2020 at 11:36 AM Jakub Kicinski <kuba@kernel.org>
> wrote:
>>
>> > > From this point of view it will be the best to handle the NETDEV_UP in
>> > > the lapb event handler and establish the link analog to the
>> > > NETDEV_CHANGE event if the carrier is UP.
>> >
>> > Thanks! This way we can make sure LAPB would automatically connect in
>> > all situations.
>> >
>> > Since we'll have a netif_carrier_ok check in NETDEV_UP handing, it
>> > might make the code look prettier to also have a netif_carrier_ok
>> > check in NETDEV_GOING_DOWN handing (for symmetry). Just a suggestion.
>> > You can do whatever looks good to you :)
>>
>> Xie other than this the patches look good to you?
>>
>> Martin should I expect a respin to follow Xie's suggestion
>> or should I apply v4?
>
> There should be a respin because we need to handle the NETDEV_UP
> event. The lapbether driver (and possibly some HDLC WAN drivers)
> doesn't generate carrier events so we need to do auto-connect in the
> NETDEV_UP event.
I'll send a v5 with the appropriate change.
next prev parent reply other threads:[~2020-11-24 5:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 5:40 [PATCH net-next v4 0/5] net/x25: netdev event handling Martin Schiller
2020-11-20 5:40 ` [PATCH net-next v4 1/5] net/x25: handle additional netdev events Martin Schiller
2020-11-20 5:40 ` [PATCH net-next v4 2/5] net/lapb: support " Martin Schiller
2020-11-20 23:11 ` Xie He
2020-11-20 23:50 ` Xie He
2020-11-23 6:55 ` Martin Schiller
2020-11-23 8:31 ` Xie He
2020-11-23 9:00 ` Martin Schiller
2020-11-23 9:36 ` Xie He
2020-11-23 10:08 ` Xie He
2020-11-23 10:38 ` Martin Schiller
2020-11-23 11:17 ` Xie He
2020-11-23 19:36 ` Jakub Kicinski
2020-11-23 22:09 ` Xie He
2020-11-24 5:29 ` Martin Schiller [this message]
2020-11-20 5:40 ` [PATCH net-next v4 3/5] net/lapb: fix t1 timer handling for LAPB_STATE_0 Martin Schiller
2020-11-20 5:40 ` [PATCH net-next v4 4/5] net/x25: fix restart request/confirm handling Martin Schiller
2020-11-20 5:40 ` [PATCH net-next v4 5/5] net/x25: remove x25_kill_by_device() Martin Schiller
2020-11-20 22:40 ` [PATCH net-next v4 0/5] net/x25: netdev event handling Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39b6386b4ce7462f6cb4448020735ed5@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=andrew.hendry@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.